From: Nhat Pham <nphamcs@gmail.com>
To: Ronald Monthero <debug.penguin32@gmail.com>
Cc: sjenning@redhat.com, akpm@linux-foundation.org,
Dan Streetman <ddstreet@ieee.org>,
Vitaly Wool <vitaly.wool@konsulko.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/zswap: Improve with alloc_workqueue() call
Date: Mon, 11 Dec 2023 09:15:50 -0500 [thread overview]
Message-ID: <CAKEwX=MzkBt1F2WZaacuCQ+E6eWt1AKvbGZ6JFHy5tkoYigqQg@mail.gmail.com> (raw)
In-Reply-To: <20231211052850.3513230-1-debug.penguin32@gmail.com>
On Sun, Dec 10, 2023 at 9:31 PM Ronald Monthero
<debug.penguin32@gmail.com> wrote:
>
> Use alloc_workqueue() to create and set finer
> work item attributes instead of create_workqueue()
> which is to be deprecated.
>
> Signed-off-by: Ronald Monthero <debug.penguin32@gmail.com>
> ---
> mm/zswap.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 74411dfdad92..64dbe3e944a2 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -1620,7 +1620,8 @@ static int zswap_setup(void)
> zswap_enabled = false;
> }
>
> - shrink_wq = create_workqueue("zswap-shrink");
> + shrink_wq = alloc_workqueue("zswap-shrink",
> + WQ_UNBOUND|WQ_MEM_RECLAIM, 0);
Hmmm this changes the current behavior a bit right? create_workqueue()
is currently defined as:
alloc_workqueue("%s", __WQ_LEGACY | WQ_MEM_RECLAIM, 1, (name))
I think this should be noted in the changelog, at the very least, even
if it is fine. We should be as explicit as possible about behavior
changes.
> if (!shrink_wq)
> goto fallback_fail;
>
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2023-12-11 14:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 5:28 [PATCH] mm/zswap: Improve with alloc_workqueue() call Ronald Monthero
2023-12-11 14:15 ` Nhat Pham [this message]
2023-12-13 13:20 ` Ronald Monthero
2023-12-14 0:28 ` Nhat Pham
2023-12-14 1:02 ` Nhat Pham
2023-12-15 9:03 ` Ronald Monthero
2023-12-20 0:21 ` Nhat Pham
2024-01-16 13:31 ` Ronald Monthero
2024-01-17 19:13 ` Nhat Pham
2024-01-17 19:30 ` Yosry Ahmed
2024-01-18 16:16 ` Johannes Weiner
2024-01-18 16:48 ` Johannes Weiner
2024-01-18 17:03 ` Yosry Ahmed
2024-01-18 18:08 ` Nhat Pham
2024-01-18 17:06 ` Yosry Ahmed
2024-01-18 17:39 ` Johannes Weiner
2024-01-18 18:03 ` Yosry Ahmed
2024-01-18 18:32 ` Nhat Pham
2024-02-21 13:32 ` Ronald Monthero
2024-01-18 18:03 ` Nhat Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKEwX=MzkBt1F2WZaacuCQ+E6eWt1AKvbGZ6JFHy5tkoYigqQg@mail.gmail.com' \
--to=nphamcs@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=debug.penguin32@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sjenning@redhat.com \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).