From: Dave Hansen <dave.hansen@intel.com>
To: Wei Wang <wei.w.wang@intel.com>,
linux-kernel@vger.kernel.org, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-mm@kvack.org, mst@redhat.com, david@redhat.com,
cornelia.huck@de.ibm.com, akpm@linux-foundation.org,
mgorman@techsingularity.net, aarcange@redhat.com,
amit.shah@redhat.com, pbonzini@redhat.com,
liliang.opensource@gmail.com
Subject: Re: [PATCH v11 4/6] mm: function to offer a page block on the free list
Date: Mon, 12 Jun 2017 07:10:12 -0700 [thread overview]
Message-ID: <b92af473-f00e-b956-ea97-eb4626601789@intel.com> (raw)
In-Reply-To: <1497004901-30593-5-git-send-email-wei.w.wang@intel.com>
Please stop cc'ing me on things also sent to closed mailing lists
(virtio-dev@lists.oasis-open.org). I'm happy to review things on open
lists, but I'm not fond of the closed lists bouncing things at me.
On 06/09/2017 03:41 AM, Wei Wang wrote:
> Add a function to find a page block on the free list specified by the
> caller. Pages from the page block may be used immediately after the
> function returns. The caller is responsible for detecting or preventing
> the use of such pages.
This description doesn't tell me very much about what's going on here.
Neither does the comment.
"Pages from the page block may be used immediately after the
function returns".
Used by who? Does the "may" here mean that it is OK, or is it a warning
that the contents will be thrown away immediately?
The hypervisor is going to throw away the contents of these pages,
right? As soon as the spinlock is released, someone can allocate a
page, and put good data in it. What keeps the hypervisor from throwing
away good data?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-12 14:10 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 10:41 [PATCH v11 0/6] Virtio-balloon Enhancement Wei Wang
2017-06-09 10:41 ` [PATCH v11 1/6] virtio-balloon: deflate via a page list Wei Wang
2017-06-09 10:41 ` [PATCH v11 2/6] virtio-balloon: coding format cleanup Wei Wang
2017-06-09 10:41 ` [PATCH v11 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS Wei Wang
2017-06-13 17:56 ` Michael S. Tsirkin
2017-06-13 17:59 ` Dave Hansen
2017-06-13 18:55 ` Michael S. Tsirkin
2017-06-15 8:10 ` [virtio-dev] " Wei Wang
2017-06-16 3:19 ` Michael S. Tsirkin
2017-06-28 15:04 ` Matthew Wilcox
2017-07-12 13:05 ` Wei Wang
2017-06-09 10:41 ` [PATCH v11 4/6] mm: function to offer a page block on the free list Wei Wang
2017-06-12 14:10 ` Dave Hansen [this message]
2017-06-12 16:28 ` Michael S. Tsirkin
2017-06-12 16:42 ` Dave Hansen
2017-06-12 20:34 ` Michael S. Tsirkin
2017-06-12 20:54 ` Dave Hansen
2017-06-13 2:56 ` Wei Wang
2017-06-20 16:44 ` Rik van Riel
2017-06-20 16:49 ` David Hildenbrand
2017-06-20 17:29 ` Rik van Riel
2017-06-20 18:26 ` Michael S. Tsirkin
2017-06-20 19:51 ` Rik van Riel
2017-06-21 12:41 ` Michael S. Tsirkin
2017-06-21 8:38 ` [Qemu-devel] " Wei Wang
2017-06-20 18:17 ` Michael S. Tsirkin
2017-06-20 18:54 ` David Hildenbrand
2017-06-20 18:56 ` Michael S. Tsirkin
2017-06-20 19:01 ` David Hildenbrand
2017-06-21 12:56 ` Christian Borntraeger
2017-06-21 13:47 ` David Hildenbrand
2017-06-09 10:41 ` [PATCH v11 5/6] mm: export symbol of next_zone and first_online_pgdat Wei Wang
2017-06-09 10:41 ` [PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ Wei Wang
2017-06-12 14:07 ` Dave Hansen
2017-06-13 10:17 ` Wei Wang
2017-06-20 16:18 ` Michael S. Tsirkin
2017-06-21 3:28 ` [virtio-dev] " Wei Wang
2017-06-21 12:28 ` Michael S. Tsirkin
2017-06-22 8:40 ` Wei Wang
2017-06-28 15:01 ` Michael S. Tsirkin
2017-07-12 12:57 ` Wei Wang
2017-06-09 11:18 ` [PATCH v11 0/6] Virtio-balloon Enhancement Wang, Wei W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b92af473-f00e-b956-ea97-eb4626601789@intel.com \
--to=dave.hansen@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amit.shah@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=liliang.opensource@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).