From: Rik van Riel <riel@redhat.com>
To: David Hildenbrand <david@redhat.com>,
Dave Hansen <dave.hansen@intel.com>,
Wei Wang <wei.w.wang@intel.com>,
linux-kernel@vger.kernel.org, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-mm@kvack.org, mst@redhat.com, cornelia.huck@de.ibm.com,
akpm@linux-foundation.org, mgorman@techsingularity.net,
aarcange@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com,
liliang.opensource@gmail.com
Cc: Nitesh Narayan Lal <nilal@redhat.com>
Subject: Re: [PATCH v11 4/6] mm: function to offer a page block on the free list
Date: Tue, 20 Jun 2017 13:29:00 -0400 [thread overview]
Message-ID: <1497979740.20270.102.camel@redhat.com> (raw)
In-Reply-To: <7b626551-6d1b-c8d5-4ef7-e357399e78dc@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]
On Tue, 2017-06-20 at 18:49 +0200, David Hildenbrand wrote:
> On 20.06.2017 18:44, Rik van Riel wrote:
> > Nitesh Lal (on the CC list) is working on a way
> > to efficiently batch recently freed pages for
> > free page hinting to the hypervisor.
> >
> > If that is done efficiently enough (eg. with
> > MADV_FREE on the hypervisor side for lazy freeing,
> > and lazy later re-use of the pages), do we still
> > need the harder to use batch interface from this
> > patch?
> >
>
> David's opinion incoming:
>
> No, I think proper free page hinting would be the optimum solution,
> if
> done right. This would avoid the batch interface and even turn
> virtio-balloon in some sense useless.
I agree with that. Let me go into some more detail of
what Nitesh is implementing:
1) In arch_free_page, the being-freed page is added
to a per-cpu set of freed pages.
2) Once that set is full, arch_free_pages goes into a
slow path, which:
2a) Iterates over the set of freed pages, and
2b) Checks whether they are still free, and
2c) Adds the still free pages to a list that is
to be passed to the hypervisor, to be MADV_FREEd.
2d) Makes that hypercall.
Meanwhile all arch_alloc_pages has to do is make sure it
does not allocate a page while it is currently being
MADV_FREEd on the hypervisor side.
The code Wei is working on looks like it could be
suitable for steps (2c) and (2d) above. Nitesh already
has code for steps 1 through 2b.
--
All rights reversed
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2017-06-20 17:29 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 10:41 [PATCH v11 0/6] Virtio-balloon Enhancement Wei Wang
2017-06-09 10:41 ` [PATCH v11 1/6] virtio-balloon: deflate via a page list Wei Wang
2017-06-09 10:41 ` [PATCH v11 2/6] virtio-balloon: coding format cleanup Wei Wang
2017-06-09 10:41 ` [PATCH v11 3/6] virtio-balloon: VIRTIO_BALLOON_F_PAGE_CHUNKS Wei Wang
2017-06-13 17:56 ` Michael S. Tsirkin
2017-06-13 17:59 ` Dave Hansen
2017-06-13 18:55 ` Michael S. Tsirkin
2017-06-15 8:10 ` [virtio-dev] " Wei Wang
2017-06-16 3:19 ` Michael S. Tsirkin
2017-06-28 15:04 ` Matthew Wilcox
2017-07-12 13:05 ` Wei Wang
2017-06-09 10:41 ` [PATCH v11 4/6] mm: function to offer a page block on the free list Wei Wang
2017-06-12 14:10 ` Dave Hansen
2017-06-12 16:28 ` Michael S. Tsirkin
2017-06-12 16:42 ` Dave Hansen
2017-06-12 20:34 ` Michael S. Tsirkin
2017-06-12 20:54 ` Dave Hansen
2017-06-13 2:56 ` Wei Wang
2017-06-20 16:44 ` Rik van Riel
2017-06-20 16:49 ` David Hildenbrand
2017-06-20 17:29 ` Rik van Riel [this message]
2017-06-20 18:26 ` Michael S. Tsirkin
2017-06-20 19:51 ` Rik van Riel
2017-06-21 12:41 ` Michael S. Tsirkin
2017-06-21 8:38 ` [Qemu-devel] " Wei Wang
2017-06-20 18:17 ` Michael S. Tsirkin
2017-06-20 18:54 ` David Hildenbrand
2017-06-20 18:56 ` Michael S. Tsirkin
2017-06-20 19:01 ` David Hildenbrand
2017-06-21 12:56 ` Christian Borntraeger
2017-06-21 13:47 ` David Hildenbrand
2017-06-09 10:41 ` [PATCH v11 5/6] mm: export symbol of next_zone and first_online_pgdat Wei Wang
2017-06-09 10:41 ` [PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ Wei Wang
2017-06-12 14:07 ` Dave Hansen
2017-06-13 10:17 ` Wei Wang
2017-06-20 16:18 ` Michael S. Tsirkin
2017-06-21 3:28 ` [virtio-dev] " Wei Wang
2017-06-21 12:28 ` Michael S. Tsirkin
2017-06-22 8:40 ` Wei Wang
2017-06-28 15:01 ` Michael S. Tsirkin
2017-07-12 12:57 ` Wei Wang
2017-06-09 11:18 ` [PATCH v11 0/6] Virtio-balloon Enhancement Wang, Wei W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497979740.20270.102.camel@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amit.shah@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=liliang.opensource@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).