From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>, linux-mm <linux-mm@kvack.org>,
David Rientjes <rientjes@google.com>,
Shakeel Butt <shakeelb@google.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [nacked] mm-oom-avoid-printk-iteration-under-rcu.patch removed from -mm tree
Date: Fri, 24 Apr 2020 10:16:19 +0900 [thread overview]
Message-ID: <c95dfafb-fe9c-19d7-8d42-bcd7d0946867@i-love.sakura.ne.jp> (raw)
In-Reply-To: <CALOAHbCsuWoMgOpzqXfqfHcDn+kHKojCmp7wvrfrXTpcGAGANA@mail.gmail.com>
On 2020/04/24 9:56, Yafang Shao wrote:
> I suggest to set KERN_NO_CONSOLES by default but the user can tune it
> back to the original behavior.
Yes, I'd like to set KERN_NO_CONSOLES by default.
> I'm not a fan of sysctl, but if there's no better chioce, enhancing
> vm.oom_dump_tasks seems a possible solution.
I don't think vm.oom_dump_tasks is the right variable to enhance. We can allow users
to suppress not only dump_tasks() output but also e.g. dump_stack() / show_mem()
output, for OOM-killer messages and memory allocation failure messages can take long
time (if printed to consoles) is an unhappy thing for OOM context and atomic context.
Since Dmitry Safonov is working on adding loglevel argument to show_stack(), we will
be able to control dump_stack() in near future. I think that we should introduce a new
sysctl variable under vm directory in order to implement bitmask for "which OOM and
memory allocation failure related messages should be printed to consoles". I think
that there is no need to print to consoles (i.e. saving to log files via userspace
syslog daemon is sufficient) for most systems.
prev parent reply other threads:[~2020-04-24 1:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200131043324.wkArXTf6-%akpm@linux-foundation.org>
2020-04-17 14:33 ` [nacked] mm-oom-avoid-printk-iteration-under-rcu.patch removed from -mm tree Tetsuo Handa
2020-04-17 15:26 ` Michal Hocko
2020-04-18 10:13 ` Tetsuo Handa
2020-04-20 7:33 ` Michal Hocko
2020-04-22 6:40 ` Tetsuo Handa
2020-04-22 6:59 ` Michal Hocko
2020-04-23 5:34 ` Tetsuo Handa
2020-04-23 6:35 ` Yafang Shao
2020-04-23 7:34 ` Michal Hocko
2020-04-23 10:22 ` Yafang Shao
2020-04-23 11:07 ` Michal Hocko
2020-04-23 13:28 ` Tetsuo Handa
2020-04-23 14:06 ` Michal Hocko
2020-04-23 14:14 ` Tetsuo Handa
2020-04-23 14:35 ` Michal Hocko
2020-04-24 13:02 ` Steven Rostedt
2020-04-24 15:18 ` Michal Hocko
2020-04-23 15:54 ` Sergey Senozhatsky
2020-04-23 22:56 ` Tetsuo Handa
2020-04-24 0:56 ` Yafang Shao
2020-04-24 1:16 ` Tetsuo Handa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c95dfafb-fe9c-19d7-8d42-bcd7d0946867@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).