linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: linux-modules@vger.kernel.org, "Michal Suchánek" <msuchanek@suse.de>
Subject: Re: [PATCH 1/2] testsuite: compress modules if feature is enabled
Date: Thu, 4 Feb 2021 11:24:48 +0100	[thread overview]
Message-ID: <20210130023600.24239-1-lucas.demarchi@intel.com> (raw)
Message-ID: <20210204102448.umXmKwV9iexUvrzwVjybzIIm9phiF_Hf84fJxHG4aAg@z> (raw)

Hi,

Reviewed-by: Petr Vorel <pvorel@suse.cz>
Great, thank you!

> +feature_enabled() {
> +	local feature=$1
> +	grep KMOD_FEATURES  $CONFIG_H | head -n 1 | grep -q \+$feature
nit: using grep single time is IMHO enough
grep -q "define KMOD_FEATURES.*\+$feature" $CONFIG_H
> +}

Kind regards,
Petr

             reply	other threads:[~2021-02-04 10:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-30  2:35 Lucas De Marchi [this message]
2021-01-30  2:36 ` [PATCH 2/2] testsuite: also test xz compression Lucas De Marchi
2021-02-04 10:32   ` Petr Vorel
2021-02-06  3:59   ` Lucas De Marchi
2021-02-04  9:17 ` [PATCH 1/2] testsuite: compress modules if feature is enabled Michal Suchánek
2021-02-04 10:24 ` Petr Vorel
2021-02-06  3:59 ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210130023600.24239-1-lucas.demarchi@intel.com \
    --to=pvorel@suse.cz \
    --cc=linux-modules@vger.kernel.org \
    --cc=lucas.demarchi@intel.com \
    --cc=msuchanek@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).