* [PATCH 0/2] mtd: spi-nor: Add two spi nor flash chips
@ 2018-12-09 17:03 Hauke Mehrtens
2018-12-09 17:03 ` [PATCH 1/2] mtd: spi-nor: Add support for EON EN25Q128 Hauke Mehrtens
2018-12-09 17:03 ` [PATCH 2/2] mtd: spi-nor: Add support for mx25u3235f Hauke Mehrtens
0 siblings, 2 replies; 7+ messages in thread
From: Hauke Mehrtens @ 2018-12-09 17:03 UTC (permalink / raw)
To: marek.vasut, dwmw2, computersforpeace, boris.brezillon, richard
Cc: linux-mtd, Hauke Mehrtens
These patches were applied in OpenWrt since some time and I would like
to integrate them into the mainline Linux kernel, I do not have the
devices, I only compared the settings with the datasheets I found.
André Valentin (1):
mtd: spi-nor: Add support for mx25u3235f
Piotr Dymacz (1):
mtd: spi-nor: Add support for EON EN25Q128
drivers/mtd/spi-nor/spi-nor.c | 2 ++
1 file changed, 2 insertions(+)
--
2.11.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] mtd: spi-nor: Add support for EON EN25Q128
2018-12-09 17:03 [PATCH 0/2] mtd: spi-nor: Add two spi nor flash chips Hauke Mehrtens
@ 2018-12-09 17:03 ` Hauke Mehrtens
2019-01-11 8:33 ` Tudor.Ambarus
2018-12-09 17:03 ` [PATCH 2/2] mtd: spi-nor: Add support for mx25u3235f Hauke Mehrtens
1 sibling, 1 reply; 7+ messages in thread
From: Hauke Mehrtens @ 2018-12-09 17:03 UTC (permalink / raw)
To: marek.vasut, dwmw2, computersforpeace, boris.brezillon, richard
Cc: linux-mtd, Piotr Dymacz
From: Piotr Dymacz <pepe2k@gmail.com>
The datasheet can be found here:
https://tonyho.github.io/static/SPINorFlash/docs/EN25Q128.pdf
Signed-off-by: Piotr Dymacz <pepe2k@gmail.com>
---
drivers/mtd/spi-nor/spi-nor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 0e9bbde30be0..a21b1a26130d 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1286,6 +1286,7 @@ static const struct flash_info spi_nor_ids[] = {
{ "en25q32b", INFO(0x1c3016, 0, 64 * 1024, 64, 0) },
{ "en25p64", INFO(0x1c2017, 0, 64 * 1024, 128, 0) },
{ "en25q64", INFO(0x1c3017, 0, 64 * 1024, 128, SECT_4K) },
+ { "en25q128", INFO(0x1c3018, 0, 64 * 1024, 256, SECT_4K) },
{ "en25qh32", INFO(0x1c7016, 0, 64 * 1024, 64, 0) },
{ "en25qh128", INFO(0x1c7018, 0, 64 * 1024, 256, 0) },
{ "en25qh256", INFO(0x1c7019, 0, 64 * 1024, 512, 0) },
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] mtd: spi-nor: Add support for mx25u3235f
2018-12-09 17:03 [PATCH 0/2] mtd: spi-nor: Add two spi nor flash chips Hauke Mehrtens
2018-12-09 17:03 ` [PATCH 1/2] mtd: spi-nor: Add support for EON EN25Q128 Hauke Mehrtens
@ 2018-12-09 17:03 ` Hauke Mehrtens
2019-01-11 8:54 ` Tudor.Ambarus
1 sibling, 1 reply; 7+ messages in thread
From: Hauke Mehrtens @ 2018-12-09 17:03 UTC (permalink / raw)
To: marek.vasut, dwmw2, computersforpeace, boris.brezillon, richard
Cc: linux-mtd, André Valentin
From: André Valentin <avalentin@marcant.net>
This flash chip was found on the ZyXEL NBG6817
The datasheet can be found here:
http://www.macronix.com/Lists/Datasheet/Attachments/7438/MX25U3235F,%201.8V,%2032Mb,%20v1.6.pdf
Signed-off-by: André Valentin <avalentin@marcant.net>
---
drivers/mtd/spi-nor/spi-nor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index a21b1a26130d..9925760339ba 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1375,6 +1375,7 @@ static const struct flash_info spi_nor_ids[] = {
{ "mx25l3205d", INFO(0xc22016, 0, 64 * 1024, 64, SECT_4K) },
{ "mx25l3255e", INFO(0xc29e16, 0, 64 * 1024, 64, SECT_4K) },
{ "mx25l6405d", INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
+ { "mx25u3235f", INFO(0xc22536, 0, 64 * 1024, 64, SECT_4K) },
{ "mx25u2033e", INFO(0xc22532, 0, 64 * 1024, 4, SECT_4K) },
{ "mx25u4035", INFO(0xc22533, 0, 64 * 1024, 8, SECT_4K) },
{ "mx25u8035", INFO(0xc22534, 0, 64 * 1024, 16, SECT_4K) },
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] mtd: spi-nor: Add support for EON EN25Q128
2018-12-09 17:03 ` [PATCH 1/2] mtd: spi-nor: Add support for EON EN25Q128 Hauke Mehrtens
@ 2019-01-11 8:33 ` Tudor.Ambarus
0 siblings, 0 replies; 7+ messages in thread
From: Tudor.Ambarus @ 2019-01-11 8:33 UTC (permalink / raw)
To: hauke, marek.vasut, dwmw2, computersforpeace, boris.brezillon, richard
Cc: linux-mtd, pepe2k
Hi, Hauke,
On 12/09/2018 07:03 PM, Hauke Mehrtens wrote:
> From: Piotr Dymacz <pepe2k@gmail.com>
>
> The datasheet can be found here:
> https://tonyho.github.io/static/SPINorFlash/docs/EN25Q128.pdf
I wouldn't add links to personal sites.
It would be nice to specify how you tested this memory.
>
> Signed-off-by: Piotr Dymacz <pepe2k@gmail.com>
You should add your SoB as you are sending a patch that is not from you.
> ---
> drivers/mtd/spi-nor/spi-nor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 0e9bbde30be0..a21b1a26130d 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1286,6 +1286,7 @@ static const struct flash_info spi_nor_ids[] = {
> { "en25q32b", INFO(0x1c3016, 0, 64 * 1024, 64, 0) },
> { "en25p64", INFO(0x1c2017, 0, 64 * 1024, 128, 0) },
> { "en25q64", INFO(0x1c3017, 0, 64 * 1024, 128, SECT_4K) },
> + { "en25q128", INFO(0x1c3018, 0, 64 * 1024, 256, SECT_4K) },
The flash supports SPINOR_OP_READ_1_1_2, SPINOR_OP_READ_1_2_2 and
SPINOR_OP_READ_1_4_4, but doesn't support SPINOR_OP_READ_1_1_4. I would advise
to set SPI_NOR_DUAL_READ so that you'll benefit of the SPINOR_OP_READ_1_1_2.
Looks like the flash doesn't have support for BFPT, unfortunately as of now you
can't benefit of read-1-4-4. Please set SPI_NOR_DUAL_READ and test if
SPINOR_OP_READ_1_1_2 works correctly and if so, submit a new patch.
Cheers,
ta
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] mtd: spi-nor: Add support for mx25u3235f
2018-12-09 17:03 ` [PATCH 2/2] mtd: spi-nor: Add support for mx25u3235f Hauke Mehrtens
@ 2019-01-11 8:54 ` Tudor.Ambarus
2019-01-16 22:38 ` Hauke Mehrtens
0 siblings, 1 reply; 7+ messages in thread
From: Tudor.Ambarus @ 2019-01-11 8:54 UTC (permalink / raw)
To: hauke, marek.vasut, dwmw2, computersforpeace, boris.brezillon, richard
Cc: avalentin, linux-mtd
Hi, Hauke,
On 12/09/2018 07:03 PM, Hauke Mehrtens wrote:
> From: André Valentin <avalentin@marcant.net>
>
> This flash chip was found on the ZyXEL NBG6817
>
> The datasheet can be found here:
> http://www.macronix.com/Lists/Datasheet/Attachments/7438/MX25U3235F,%201.8V,%2032Mb,%20v1.6.pdf
Did you test the flash to see if it works correctly? You should specify this in
the commit message.
>
> Signed-off-by: André Valentin <avalentin@marcant.net>
You should add your Signed-off-by tag as you are sending a patch that is not
from you.
> ---
> drivers/mtd/spi-nor/spi-nor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index a21b1a26130d..9925760339ba 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1375,6 +1375,7 @@ static const struct flash_info spi_nor_ids[] = {
> { "mx25l3205d", INFO(0xc22016, 0, 64 * 1024, 64, SECT_4K) },
> { "mx25l3255e", INFO(0xc29e16, 0, 64 * 1024, 64, SECT_4K) },
> { "mx25l6405d", INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
> + { "mx25u3235f", INFO(0xc22536, 0, 64 * 1024, 64, SECT_4K) },
> { "mx25u2033e", INFO(0xc22532, 0, 64 * 1024, 4, SECT_4K) },
It's nicer to order this alphabetically, the entry should be added here.
The flash supports Fast Read 1-1-2 (3Bh) and Fast Read 1-1-4 (6Bh) hence both
SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ flags should be set too. Can you please
test with these flags and if all ok, submit a new patch?
Cheers,
ta
> { "mx25u4035", INFO(0xc22533, 0, 64 * 1024, 8, SECT_4K) },
> { "mx25u8035", INFO(0xc22534, 0, 64 * 1024, 16, SECT_4K) },
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] mtd: spi-nor: Add support for mx25u3235f
2019-01-11 8:54 ` Tudor.Ambarus
@ 2019-01-16 22:38 ` Hauke Mehrtens
2019-01-17 7:31 ` Tudor.Ambarus at microchip.com
0 siblings, 1 reply; 7+ messages in thread
From: Hauke Mehrtens @ 2019-01-16 22:38 UTC (permalink / raw)
To: linux-mtd
On 1/11/19 9:54 AM, Tudor.Ambarus at microchip.com wrote:
> Hi, Hauke,
>
> On 12/09/2018 07:03 PM, Hauke Mehrtens wrote:
>> From: Andr? Valentin <avalentin@marcant.net>
>>
>> This flash chip was found on the ZyXEL NBG6817
>>
>> The datasheet can be found here:
>> http://www.macronix.com/Lists/Datasheet/Attachments/7438/MX25U3235F,%201.8V,%2032Mb,%20v1.6.pdf
>
> Did you test the flash to see if it works correctly? You should specify this in
> the commit message.
Sorry I do not have a device with this flash chip, this patch was
shipped in OpenWrt for a long time and I wanted to reduce the number of
patches we carry in OpenWrt.
Andr? can you please confirm that this works for you on your device.
>>
>> Signed-off-by: Andr? Valentin <avalentin@marcant.net>
>
> You should add your Signed-off-by tag as you are sending a patch that is not
> from you.
No Problem I can add this.
>> ---
>> drivers/mtd/spi-nor/spi-nor.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index a21b1a26130d..9925760339ba 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -1375,6 +1375,7 @@ static const struct flash_info spi_nor_ids[] = {
>> { "mx25l3205d", INFO(0xc22016, 0, 64 * 1024, 64, SECT_4K) },
>> { "mx25l3255e", INFO(0xc29e16, 0, 64 * 1024, 64, SECT_4K) },
>> { "mx25l6405d", INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
>> + { "mx25u3235f", INFO(0xc22536, 0, 64 * 1024, 64, SECT_4K) },
>> { "mx25u2033e", INFO(0xc22532, 0, 64 * 1024, 4, SECT_4K) },
>
> It's nicer to order this alphabetically, the entry should be added here.
Ok will change this.
>
> The flash supports Fast Read 1-1-2 (3Bh) and Fast Read 1-1-4 (6Bh) hence both
> SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ flags should be set too. Can you please
> test with these flags and if all ok, submit a new patch?
I do not know if the controller in the ZyXEL NBG6817 and the board is
capable of dual and quad reads.
Hauke
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] mtd: spi-nor: Add support for mx25u3235f
2019-01-16 22:38 ` Hauke Mehrtens
@ 2019-01-17 7:31 ` Tudor.Ambarus at microchip.com
0 siblings, 0 replies; 7+ messages in thread
From: Tudor.Ambarus at microchip.com @ 2019-01-17 7:31 UTC (permalink / raw)
To: linux-mtd
Hi, Hauke,
On 01/17/2019 12:38 AM, Hauke Mehrtens wrote:
> On 1/11/19 9:54 AM, Tudor.Ambarus at microchip.com wrote:
>> Hi, Hauke,
>>
>> On 12/09/2018 07:03 PM, Hauke Mehrtens wrote:
>>> From: Andr? Valentin <avalentin@marcant.net>
>>>
>>> This flash chip was found on the ZyXEL NBG6817
>>>
>>> The datasheet can be found here:
>>> http://www.macronix.com/Lists/Datasheet/Attachments/7438/MX25U3235F,%201.8V,%2032Mb,%20v1.6.pdf
>>
>> Did you test the flash to see if it works correctly? You should specify this in
>> the commit message.
>
> Sorry I do not have a device with this flash chip, this patch was
> shipped in OpenWrt for a long time and I wanted to reduce the number of
> patches we carry in OpenWrt.
>
> Andr? can you please confirm that this works for you on your device.
>
>>>
>>> Signed-off-by: Andr? Valentin <avalentin@marcant.net>
>>
>> You should add your Signed-off-by tag as you are sending a patch that is not
>> from you.
>
> No Problem I can add this.
>
>>> ---
>>> drivers/mtd/spi-nor/spi-nor.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>>> index a21b1a26130d..9925760339ba 100644
>>> --- a/drivers/mtd/spi-nor/spi-nor.c
>>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>>> @@ -1375,6 +1375,7 @@ static const struct flash_info spi_nor_ids[] = {
>>> { "mx25l3205d", INFO(0xc22016, 0, 64 * 1024, 64, SECT_4K) },
>>> { "mx25l3255e", INFO(0xc29e16, 0, 64 * 1024, 64, SECT_4K) },
>>> { "mx25l6405d", INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
>>> + { "mx25u3235f", INFO(0xc22536, 0, 64 * 1024, 64, SECT_4K) },
>>> { "mx25u2033e", INFO(0xc22532, 0, 64 * 1024, 4, SECT_4K) },
>>
>> It's nicer to order this alphabetically, the entry should be added here.
>
> Ok will change this.
>
>>
>> The flash supports Fast Read 1-1-2 (3Bh) and Fast Read 1-1-4 (6Bh) hence both
>> SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ flags should be set too. Can you please
>> test with these flags and if all ok, submit a new patch?
>
> I do not know if the controller in the ZyXEL NBG6817 and the board is
> capable of dual and quad reads.
You can add SPI_NOR_DUAL_READ and SPI_NOR_QUAD_READ flags and we'll wait for
Andre's or Ding's Tested-by tag.
Thanks,
ta
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-01-17 7:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-09 17:03 [PATCH 0/2] mtd: spi-nor: Add two spi nor flash chips Hauke Mehrtens
2018-12-09 17:03 ` [PATCH 1/2] mtd: spi-nor: Add support for EON EN25Q128 Hauke Mehrtens
2019-01-11 8:33 ` Tudor.Ambarus
2018-12-09 17:03 ` [PATCH 2/2] mtd: spi-nor: Add support for mx25u3235f Hauke Mehrtens
2019-01-11 8:54 ` Tudor.Ambarus
2019-01-16 22:38 ` Hauke Mehrtens
2019-01-17 7:31 ` Tudor.Ambarus at microchip.com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).