* Re: [PATCH] mtd: nand: jz4740: fix '__iomem *' vs. '* __iomem'
[not found] <20190117173907.62198-1-luc.vanoostenryck@gmail.com>
@ 2019-01-18 8:54 ` Miquel Raynal
2019-01-18 11:43 ` Boris Brezillon
1 sibling, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2019-01-18 8:54 UTC (permalink / raw)
To: Luc Van Oostenryck
Cc: Richard Weinberger, Lars-Peter Clausen, linux-mtd, Boris Brezillon
Hi Luc,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote on Thu, 17 Jan
2019 18:39:07 +0100:
> The function jz_nand_ioremap_resource() needs a pointer to an __iomem
> pointer as its last argument but this argument is declared as:
> void * __iomem *base
>
> Fix this by using the correct declaration:
> void __iomem **base
> which then also removes the following Sparse's warnings:
> 282:15: warning: incorrect type in assignment (different address spaces)
> 282:15: expected void *[noderef] <asn:2>
> 282:15: got void [noderef] <asn:2> *
> 322:57: warning: incorrect type in argument 4 (different address spaces)
> 322:57: expected void *[noderef] <asn:2> *base
> 322:57: got void [noderef] <asn:2> **
> 402:67: warning: incorrect type in argument 4 (different address spaces)
> 402:67: expected void *[noderef] <asn:2> *base
> 402:67: got void [noderef] <asn:2> **
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Boris, do you want to take it in your fixes branch?
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: mtd: nand: jz4740: fix '__iomem *' vs. '* __iomem'
[not found] <20190117173907.62198-1-luc.vanoostenryck@gmail.com>
2019-01-18 8:54 ` [PATCH] mtd: nand: jz4740: fix '__iomem *' vs. '* __iomem' Miquel Raynal
@ 2019-01-18 11:43 ` Boris Brezillon
1 sibling, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2019-01-18 11:43 UTC (permalink / raw)
To: Luc Van Oostenryck, linux-mtd
Cc: Richard Weinberger, Miquel Raynal, Lars-Peter Clausen, Boris Brezillon
On Thu, 2019-01-17 at 17:39:07 UTC, Luc Van Oostenryck wrote:
> The function jz_nand_ioremap_resource() needs a pointer to an __iomem
> pointer as its last argument but this argument is declared as:
> void * __iomem *base
>
> Fix this by using the correct declaration:
> void __iomem **base
> which then also removes the following Sparse's warnings:
> 282:15: warning: incorrect type in assignment (different address spaces)
> 282:15: expected void *[noderef] <asn:2>
> 282:15: got void [noderef] <asn:2> *
> 322:57: warning: incorrect type in argument 4 (different address spaces)
> 322:57: expected void *[noderef] <asn:2> *base
> 322:57: got void [noderef] <asn:2> **
> 402:67: warning: incorrect type in argument 4 (different address spaces)
> 402:67: expected void *[noderef] <asn:2> *base
> 402:67: got void [noderef] <asn:2> **
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied to http://git.infradead.org/linux-mtd.git mtd/fixes, thanks.
Boris
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-18 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190117173907.62198-1-luc.vanoostenryck@gmail.com>
2019-01-18 8:54 ` [PATCH] mtd: nand: jz4740: fix '__iomem *' vs. '* __iomem' Miquel Raynal
2019-01-18 11:43 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).