From: Marco Felsch <m.felsch@pengutronix.de>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: "bbrezillon@kernel.org" <bbrezillon@kernel.org>,
"richard@nod.at" <richard@nod.at>,
"frieder.schrempf@kontron.de" <frieder.schrempf@kontron.de>,
"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
"Shivamurthy Shastri \(sshivamurthy\)" <sshivamurthy@micron.com>
Subject: Re: [EXT] [PATCH] mtd: spinand: micron: add support for MT29F1G01AAADD
Date: Tue, 19 Nov 2019 10:27:04 +0100 [thread overview]
Message-ID: <20191119092704.mz4pie37z6ngxyyn@pengutronix.de> (raw)
In-Reply-To: <20191118183954.4091abdc@collabora.com>
Hi Boris,
On 19-11-18 18:39, Boris Brezillon wrote:
> On Mon, 18 Nov 2019 15:09:51 +0100
> Marco Felsch <m.felsch@pengutronix.de> wrote:
>
> > Hi Shiva,
> >
> > On 19-11-18 10:16, Shivamurthy Shastri (sshivamurthy) wrote:
> > > Hi Marco,
> > >
> > > >
> > > > The MT29F1G01AAADD is a single die, SLC based SPI NAND. It has a
> > > > capacity of 1Gb and supports 4-bit ECC. The datasheet can be found [1].
> > > >
> > > > Unfortunatly the linked device is marked as EoL, but I will expect that
> > > > the MT29F1G01AAADDH4-ITX behaves the same way.
> > > >
> > > > [1]
> > > > https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdata
> > > > sheet.octopart.com%2FMT29F1G01AAADDH4-IT%3AD-Micron-datasheet-
> > > > 11572380.pdf&data=02%7C01%7Csshivamurthy%40micron.com%7C21a
> > > > da5347828461980a408d7642021a9%7Cf38a5ecd28134862b11bac1d563c806f%
> > > > 7C0%7C1%7C637087961499818902&sdata=%2Fh%2FHfUoSnl8qqSVClVfp
> > > > ykvi3UiDEZFTn%2BVCsAf9IaM%3D&reserved=0
> > > >
> > > > Cc: Peter Pan <peterpandong@micron.com>
> > > > Cc: sshivamurthy@micron.com
> > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > > ---
> > > > v2:
> > > > - Convert 0x10 into 16 for ooblayout description
> > > > - Don't break web link within commit message
> > > >
> > > > drivers/mtd/nand/spi/micron.c | 68
> > > > +++++++++++++++++++++++++++++++++++
> > > > 1 file changed, 68 insertions(+)
> > > >
> > > > diff --git a/drivers/mtd/nand/spi/micron.c b/drivers/mtd/nand/spi/micron.c
> > > > index 7d7b1f7fcf71..70e278759bd3 100644
> > > > --- a/drivers/mtd/nand/spi/micron.c
> > > > +++ b/drivers/mtd/nand/spi/micron.c
> > > > @@ -34,6 +34,18 @@ static
> > > > SPINAND_OP_VARIANTS(update_cache_variants,
> > > > SPINAND_PROG_LOAD_X4(false, 0, NULL, 0),
> > > > SPINAND_PROG_LOAD(false, 0, NULL, 0));
> > > >
> > > > +static SPINAND_OP_VARIANTS(read_cache_variants_mt29f1g01aaadd,
> > > > + SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0),
> > > > + SPINAND_PAGE_READ_FROM_CACHE_X2_OP(0, 1, NULL, 0),
> > > > + SPINAND_PAGE_READ_FROM_CACHE_OP(true, 0, 1, NULL,
> > > > 0),
> > > > + SPINAND_PAGE_READ_FROM_CACHE_OP(false, 0, 1, NULL,
> > > > 0));
> > > > +
> > > > +static SPINAND_OP_VARIANTS(write_cache_variants_mt29f1g01aaadd,
> > > > + SPINAND_PROG_LOAD(true, 0, NULL, 0));
> > > > +
> > > > +static SPINAND_OP_VARIANTS(update_cache_variants_mt29f1g01aaadd,
> > > > + SPINAND_PROG_LOAD(false, 0, NULL, 0));
> > > > +
> > > > static int mt29f2g01abagd_ooblayout_ecc(struct mtd_info *mtd, int section,
> > > > struct mtd_oob_region *region)
> > > > {
> > > > @@ -90,6 +102,52 @@ static int mt29f2g01abagd_ecc_get_status(struct
> > > > spinand_device *spinand,
> > > > return -EINVAL;
> > > > }
> > > >
> > > > +static int mt29f1g01aaadd_ooblayout_ecc(struct mtd_info *mtd, int
> > > > section,
> > > > + struct mtd_oob_region *region)
> > > > +{
> > > > + if (section > 3)
> > > > + return -ERANGE;
> > > > +
> > > > + region->offset = (section * 16) + 8;
> > > > + region->length = 8;
> > > > +
> > > > + return 0;
> > > > +}
> > > > +
> > > > +static int mt29f1g01aaadd_ooblayout_free(struct mtd_info *mtd, int
> > > > section,
> > > > + struct mtd_oob_region *region)
> > > > +{
> > > > + if (section > 3)
> > > > + return -ERANGE;
> > > > +
> > > > + /* 2 bytes for the BBM + 2 bytes to skip non-ecc memory */
> > > > + region->offset = (section * 16) + 4;
> > > > + region->length = 4;
> > > > +
> > > > + return 0;
> > > > +}
> > > > +
> > > > +static const struct mtd_ooblayout_ops mt29f1g01aaadd_ooblayout = {
> > > > + .ecc = mt29f1g01aaadd_ooblayout_ecc,
> > > > + .free = mt29f1g01aaadd_ooblayout_free,
> > > > +};
> > > > +
> > > > +static int mt29f1g01aaadd_ecc_get_status(struct spinand_device *spinand,
> > > > + u8 status)
> > > > +{
> > > > + switch (status & STATUS_ECC_MASK) {
> > > > + case STATUS_ECC_NO_BITFLIPS:
> > > > + return 0;
> > > > + case STATUS_ECC_HAS_BITFLIPS:
> > > > + /* 1 to 4-bit error detected and corrected */
> > > > + return 4;
> > > > + case STATUS_ECC_UNCOR_ERROR:
> > > > + return -EBADMSG;
> > > > + default:
> > > > + return -EINVAL;
> > > > + }
> > > > +}
> > > > +
> > > > static const struct spinand_info micron_spinand_table[] = {
> > > > SPINAND_INFO("MT29F2G01ABAGD", 0x24,
> > > > NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 2, 1, 1),
> > > > @@ -100,6 +158,16 @@ static const struct spinand_info
> > > > micron_spinand_table[] = {
> > > > 0,
> > > > SPINAND_ECCINFO(&mt29f2g01abagd_ooblayout,
> > > > mt29f2g01abagd_ecc_get_status)),
> > > > + SPINAND_INFO("MT29F1G01AAADD", 0x12,
> > > > + NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 2, 1, 1),
> > > > + NAND_ECCREQ(4, 2048),
> > >
> > > I think, this should be NAND_ECCREQ(4, 512).
> >
> > I don't thinks so, according the datasheet [1], section ECC Protection:
> >
> > 8<--------------------------------------
> > During a PROGRAM operation, the device calculates an ECC code on the 2k
> > page in the cache register, before the page is written to the NAND
> > Flash array. The ECC code is stored in the spare area of the page.
> > 8<--------------------------------------
>
> Looking at "Table 11: ECC Protection" it really seems to be 4bit/512. I
> think the sentence you quoted just means the ECC is calculated for each
> 512 bytes block in the page and written at once (no subpage write).
Yes that part confuses me a bit and than I used the description above..
I will change that, thanks for the explanation.
> BTW, there's an easy way to know who's right => nandbiterrs.
Thanks for that hint :)
Regards,
Marco
>
> >
> > [1] https://datasheet.octopart.com/MT29F1G01AAADDH4-IT:D-Micron-datasheet-11572380.pdf
> >
> > Regards,
> > Marco
> >
> > >
> > > > + SPINAND_INFO_OP_VARIANTS(
> > > > +
> > > > &read_cache_variants_mt29f1g01aaadd,
> > > > +
> > > > &write_cache_variants_mt29f1g01aaadd,
> > > > +
> > > > &update_cache_variants_mt29f1g01aaadd),
> > > > + 0,
> > > > + SPINAND_ECCINFO(&mt29f1g01aaadd_ooblayout,
> > > > + mt29f1g01aaadd_ecc_get_status)),
> > > > };
> > > >
> > > > static int micron_spinand_detect(struct spinand_device *spinand)
> > > > --
> > > > 2.20.1
> > >
> > > Thanks,
> > > Shiva
> > >
> >
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-11-19 9:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 7:48 [PATCH] mtd: spinand: micron: add support for MT29F1G01AAADD Marco Felsch
2019-11-18 10:16 ` [EXT] " Shivamurthy Shastri (sshivamurthy)
2019-11-18 14:09 ` Marco Felsch
2019-11-18 17:39 ` Boris Brezillon
2019-11-19 9:27 ` Marco Felsch [this message]
2020-01-09 16:12 ` Miquel Raynal
2020-01-17 7:18 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119092704.mz4pie37z6ngxyyn@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=frieder.schrempf@kontron.de \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=sshivamurthy@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).