From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: "bbrezillon@kernel.org" <bbrezillon@kernel.org>,
"richard@nod.at" <richard@nod.at>,
"frieder.schrempf@kontron.de" <frieder.schrempf@kontron.de>,
"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"Shivamurthy Shastri \(sshivamurthy\)" <sshivamurthy@micron.com>
Subject: Re: [EXT] [PATCH] mtd: spinand: micron: add support for MT29F1G01AAADD
Date: Thu, 9 Jan 2020 17:12:00 +0100 [thread overview]
Message-ID: <20200109171200.49f299e5@xps13> (raw)
In-Reply-To: <20191119092704.mz4pie37z6ngxyyn@pengutronix.de>
Hi Marco,
> > > >
> > > > I think, this should be NAND_ECCREQ(4, 512).
> > >
> > > I don't thinks so, according the datasheet [1], section ECC Protection:
> > >
> > > 8<--------------------------------------
> > > During a PROGRAM operation, the device calculates an ECC code on the 2k
> > > page in the cache register, before the page is written to the NAND
> > > Flash array. The ECC code is stored in the spare area of the page.
> > > 8<--------------------------------------
> >
> > Looking at "Table 11: ECC Protection" it really seems to be 4bit/512. I
> > think the sentence you quoted just means the ECC is calculated for each
> > 512 bytes block in the page and written at once (no subpage write).
>
> Yes that part confuses me a bit and than I used the description above..
> I will change that, thanks for the explanation.
>
> > BTW, there's an easy way to know who's right => nandbiterrs.
>
> Thanks for that hint :)
>
> Regards,
> Marco
Would you mind sending an updated version of this patch please?
Thanks!
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-01-09 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 7:48 [PATCH] mtd: spinand: micron: add support for MT29F1G01AAADD Marco Felsch
2019-11-18 10:16 ` [EXT] " Shivamurthy Shastri (sshivamurthy)
2019-11-18 14:09 ` Marco Felsch
2019-11-18 17:39 ` Boris Brezillon
2019-11-19 9:27 ` Marco Felsch
2020-01-09 16:12 ` Miquel Raynal [this message]
2020-01-17 7:18 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109171200.49f299e5@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=frieder.schrempf@kontron.de \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=sshivamurthy@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).