* [PATCH] xfs: drop the useless LIST_HEAD in __mtd_del_partition()
@ 2022-05-27 10:01 Haowen Bai
2022-05-27 10:45 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Haowen Bai @ 2022-05-27 10:01 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: Haowen Bai, linux-mtd, linux-kernel
Drop LIST_HEAD where the variable it declares is never used.
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/mtd/mtdpart.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index d442fa94c872..976e9c30244e 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -326,7 +326,6 @@ static int __mtd_del_partition(struct mtd_info *mtd)
static int __del_mtd_partitions(struct mtd_info *mtd)
{
struct mtd_info *child, *next;
- LIST_HEAD(tmp_list);
int ret, err = 0;
list_for_each_entry_safe(child, next, &mtd->partitions, part.node) {
--
2.7.4
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: drop the useless LIST_HEAD in __mtd_del_partition()
2022-05-27 10:01 [PATCH] xfs: drop the useless LIST_HEAD in __mtd_del_partition() Haowen Bai
@ 2022-05-27 10:45 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2022-05-27 10:45 UTC (permalink / raw)
To: Haowen Bai
Cc: Richard Weinberger, Vignesh Raghavendra, linux-mtd, linux-kernel
Hi Haowen,
baihaowen@meizu.com wrote on Fri, 27 May 2022 18:01:18 +0800:
> Drop LIST_HEAD where the variable it declares is never used.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
The title seems wrong. A fixes tag would be appropriate.
> ---
> drivers/mtd/mtdpart.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
> index d442fa94c872..976e9c30244e 100644
> --- a/drivers/mtd/mtdpart.c
> +++ b/drivers/mtd/mtdpart.c
> @@ -326,7 +326,6 @@ static int __mtd_del_partition(struct mtd_info *mtd)
> static int __del_mtd_partitions(struct mtd_info *mtd)
> {
> struct mtd_info *child, *next;
> - LIST_HEAD(tmp_list);
> int ret, err = 0;
>
> list_for_each_entry_safe(child, next, &mtd->partitions, part.node) {
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-27 10:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-27 10:01 [PATCH] xfs: drop the useless LIST_HEAD in __mtd_del_partition() Haowen Bai
2022-05-27 10:45 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).