From: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Greg Ungerer <gerg@kernel.org>,
Boris Brezillon <boris.brezillon@collabora.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Boris Brezillon <bbrezillon@kernel.org>,
linux-mtd@lists.infradead.org
Subject: Re: GPMI iMX6ull timeout on DMA
Date: Mon, 18 Oct 2021 09:33:25 +0200 [thread overview]
Message-ID: <CAOf5uwk8o_m6FJwnRtkGqhkTQZh-3b3FJoc_OnnQq6JdBPPKLg@mail.gmail.com> (raw)
In-Reply-To: <20211018091919.08cf589a@xps13>
Hi
On Mon, Oct 18, 2021 at 9:19 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Michael,
>
> michael@amarulasolutions.com wrote on Fri, 15 Oct 2021 22:05:41 +0200:
>
> > Hi
> >
> > On Mon, Feb 01, 2021 at 04:14:33PM +0100, Miquel Raynal wrote:
> > > Hi Michael,
> > >
> > > Michael Nazzareno Trimarchi <michael@amarulasolutions.com> wrote on
> > > Mon, 1 Feb 2021 16:08:23 +0100:
> > >
> > > > Hi
> > > >
> > > > On Mon, Feb 1, 2021 at 3:32 PM Michael Nazzareno Trimarchi
> > > > <michael@amarulasolutions.com> wrote:
> > > > >
> > > > > Hi
> > > > >
> > > > > On Mon, Feb 1, 2021 at 3:13 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > > > > >
> > > > > > Hi Michael,
> > > > > >
> > > > > > Michael Nazzareno Trimarchi <michael@amarulasolutions.com> wrote on
> > > > > > Sat, 30 Jan 2021 10:41:29 +0100:
> > > > > >
> > > > > > > Hi Miquel
> > > > > > >
> > > > > > > commit f8e6ad14388067f91b26d044185d95623fbc9535
> > > > > > > Author: Michael Trimarchi <michael@amarulasolutions.com>
> > > > > > > Date: Fri Jan 29 08:46:53 2021 +0100
> > > > > > >
> > > > > > > mtd: nand: Calculate the clock before enable it
> > > > > > >
> > > > > > > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > > > > > > Change-Id: I79b0da39de0a9b32ea0b002fa200d7f44d4f8ce7
> > > > > > >
> > > > > > > diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> > > > > > > b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> > > > > > > index 322a008290e5..0bca52b3bc8f 100644
> > > > > > > --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> > > > > > > +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> > > > > > > @@ -377,6 +377,7 @@ static void gpmi_nfc_compute_timings(struct
> > > > > > > gpmi_nand_data *this,
> > > > > > > const struct nand_sdr_timings *sdr)
> > > > > > > {
> > > > > > > struct gpmi_nfc_hardware_timing *hw = &this->hw;
> > > > > > > + struct resources *r = &this->resources;
> > > > > > > unsigned int dll_threshold_ps = this->devdata->max_chain_delay;
> > > > > > > unsigned int period_ps, reference_period_ps;
> > > > > > > unsigned int data_setup_cycles, data_hold_cycles, addr_setup_cycles;
> > > > > > > @@ -440,6 +441,8 @@ static void gpmi_nfc_compute_timings(struct
> > > > > > > gpmi_nand_data *this,
> > > > > > > hw->ctrl1n |= BF_GPMI_CTRL1_RDN_DELAY(sample_delay_factor) |
> > > > > > > BM_GPMI_CTRL1_DLL_ENABLE |
> > > > > > > (use_half_period ? BM_GPMI_CTRL1_HALF_PERIOD : 0);
> > > > > > > +
> > > > > > > + clk_set_rate(r->clock[0], hw->clk_rate);
> > > > > > > }
> > > > > > >
> > > > > > > void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)
> > > > > > > @@ -449,8 +452,6 @@ void gpmi_nfc_apply_timings(struct gpmi_nand_data *this)
> > > > > > > void __iomem *gpmi_regs = r->gpmi_regs;
> > > > > > > unsigned int dll_wait_time_us;
> > > > > > >
> > > > > > > - clk_set_rate(r->clock[0], hw->clk_rate);
> > > > > > > -
> > > > > > > writel(hw->timing0, gpmi_regs + HW_GPMI_TIMING0);
> > > > > > > writel(hw->timing1, gpmi_regs + HW_GPMI_TIMING1);
> > > > > > >
> > > > > > > Right now I have this change applied and seems fine. That is the only
> > > > > > > difference I get. Clock is apply a bit earlier that when is enabled
> > > > > > > it.
> > > > > >
> > > > > > This is very interesting. So this would mean the issue you are
> > > > > > experiencing comes from the clock driver which kind of returns too
> > > > > > early from clk_set_rate()? Could you report this to the clk ML/NXP clk
> > > > > > maintainers and keep us in copy? If it is as global as it sounds, we
> > > > > > might not be the only ones affected.
> > > > > >
> > > > >
> > > > > The imx28 is broken too, so it's a general problem. I need to trace it down
> > > > > I have a reverting for lts but it\s not the way to go
> > > > >
> > > >
> > > > For imx28 you ask to set the rate to 22Mhz but you don't care about the clock
> > > > that you get back. You get back 12Mhz because the base clock is 24 Mhz and seems
> > > > that it can not get the point. You need to check if the clock
> > > > requested is in range or ask
> > > > for set_rate_clk_min to avoid to have somenthing lower. Then for
> > > > imx6ull because is sporadic
> > > > I think that is more connected to the clk_set_rate and when you change
> > > > the register. Can not be a
> > > > setting time?
> > >
> > > So, if I understand correctly, we face two different problems:
> > > - imx6*: seems like a clock issue regarding the clock settlement
> > > - imx28: actual NAND driver issue (does not check the validity of the
> > > new frequency). This should be handled properly in
> > > ->setup_interface().
> > >
> >
> > Somenthing like this? Not compile/tested
> >
> > diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> > index 4d08e4ab5c1b..cc8146ab1b78 100644
> > --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> > +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
> > @@ -644,7 +644,7 @@ static int bch_set_geometry(struct gpmi_nand_data *this)
> > * RDN_DELAY = ----------------------- {3}
> > * RP
> > */
> > -static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,
> > +static int gpmi_nfc_compute_timings(struct gpmi_nand_data *this,
> > const struct nand_sdr_timings *sdr)
> > {
> > struct gpmi_nfc_hardware_timing *hw = &this->hw;
> > @@ -656,6 +656,7 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,
> > int sample_delay_ps, sample_delay_factor;
> > u16 busy_timeout_cycles;
> > u8 wrn_dly_sel;
> > + long clk_rate;
> >
> > if (sdr->tRC_min >= 30000) {
> > /* ONFI non-EDO modes [0-3] */
> > @@ -671,6 +672,10 @@ static void gpmi_nfc_compute_timings(struct gpmi_nand_data *this,
> > wrn_dly_sel = BV_GPMI_CTRL1_WRN_DLY_SEL_NO_DELAY;
> > }
> >
> > + clk_rate = clk_round_rate(r->clock[0], hw->clk_rate);
> > + if (clk_rate < hw->clk_rate || clk_rate <= 0)
> > + return -ENOTSUPP;
>
> I believe clk_rate < hw->clk_rate will always match cases where
> clk_rate <= 0 ?
>
> The check looks very strict though. Will it even pass on i.MX6? Perhaps
> we could verify something like a 10% error which might grab all the
> erroneous situations?
According to what I read the clk is the min that we can accept. So any clock
from EDO4 to EDO5 should be ok. My concern is that calculation. I need to read
it properly. I don't think that put 10% or any will help us, until we
now that is possible or not.
I will even anyway put a warning
Michael
>
> if (abs(clk_rate - hw->clk_rate) > (hw->clk_rate / 10))
> return -ENOTSUPP;
>
> > +
> > /* SDR core timings are given in picoseconds */
> > period_ps = div_u64((u64)NSEC_PER_SEC * 1000, hw->clk_rate);
> >
> > @@ -746,6 +751,7 @@ static int gpmi_setup_interface(struct nand_chip *chip, int chipnr,
> > {
> > struct gpmi_nand_data *this = nand_get_controller_data(chip);
> > const struct nand_sdr_timings *sdr;
> > + int ret = 0;
> >
> > /* Retrieve required NAND timings */
> > sdr = nand_get_sdr_timings(conf);
> > @@ -761,11 +767,11 @@ static int gpmi_setup_interface(struct nand_chip *chip, int chipnr,
> > return 0;
> >
> > /* Do the actual derivation of the controller timings */
> > - gpmi_nfc_compute_timings(this, sdr);
> > -
> > - this->hw.must_apply_timings = true;
> > + ret = gpmi_nfc_compute_timings(this, sdr);
> > + if (!ret)
> > + this->hw.must_apply_timings = true;
> >
> > - return 0;
> > + return ret;
> > }
> >
> > /* Clears a BCH interrupt. */
> > > Thanks,
> > > Miquèl
>
> Otherwise looks good, thanks!
>
> Miquèl
--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________
Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-10-18 7:34 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 6:41 GPMI iMX6ull timeout on DMA Greg Ungerer
2019-07-29 8:36 ` Miquel Raynal
2019-07-29 8:42 ` Michael Nazzareno Trimarchi
2019-07-29 12:18 ` Greg Ungerer
2019-07-29 12:20 ` Michael Nazzareno Trimarchi
2019-07-29 12:33 ` Greg Ungerer
2019-07-29 12:47 ` Miquel Raynal
2019-07-29 12:49 ` Michael Nazzareno Trimarchi
2019-07-29 12:55 ` Miquel Raynal
2019-07-29 13:00 ` Michael Nazzareno Trimarchi
2019-07-29 13:22 ` Miquel Raynal
2019-07-29 20:00 ` Michael Nazzareno Trimarchi
2019-07-29 21:02 ` Miquel Raynal
2019-07-30 0:28 ` Greg Ungerer
2019-07-30 0:41 ` Greg Ungerer
2019-07-30 6:06 ` Greg Ungerer
2019-07-30 8:38 ` Miquel Raynal
2019-07-30 8:58 ` Boris Brezillon
2019-07-31 2:05 ` Greg Ungerer
2019-07-31 6:28 ` Boris Brezillon
2019-08-02 7:19 ` Greg Ungerer
2019-08-02 12:34 ` Greg Ungerer
2019-08-02 12:51 ` Boris Brezillon
2019-08-05 5:51 ` Greg Ungerer
2019-08-07 16:05 ` Miquel Raynal
2019-08-08 0:43 ` Greg Ungerer
2019-08-08 16:36 ` Boris Brezillon
2019-08-09 5:20 ` Greg Ungerer
2019-08-09 6:23 ` Boris Brezillon
2019-08-09 6:55 ` Greg Ungerer
2019-08-09 7:32 ` Boris Brezillon
2019-08-09 13:57 ` Greg Ungerer
2019-08-09 13:59 ` Boris Brezillon
2019-08-12 2:50 ` Greg Ungerer
2019-08-12 4:04 ` Greg Ungerer
2019-08-12 7:31 ` Boris Brezillon
2019-08-13 0:50 ` Greg Ungerer
2021-01-28 9:45 ` Michael Nazzareno Trimarchi
2021-01-28 10:26 ` Miquel Raynal
2021-01-28 10:35 ` Michael Nazzareno Trimarchi
2021-01-28 11:55 ` Michael Nazzareno Trimarchi
2021-01-29 12:43 ` Greg Ungerer
2021-01-30 9:41 ` Michael Nazzareno Trimarchi
2021-02-01 14:13 ` Miquel Raynal
2021-02-01 14:32 ` Michael Nazzareno Trimarchi
2021-02-01 15:08 ` Michael Nazzareno Trimarchi
2021-02-01 15:14 ` Miquel Raynal
2021-02-01 15:17 ` Michael Nazzareno Trimarchi
2021-10-15 20:05 ` Michael Trimarchi
2021-10-15 20:12 ` Michael Nazzareno Trimarchi
2021-10-18 7:19 ` Miquel Raynal
2021-10-18 7:33 ` Michael Nazzareno Trimarchi [this message]
2021-10-18 7:43 ` Miquel Raynal
2021-10-04 5:54 ` Christian Eggers
2021-10-04 6:27 ` Michael Nazzareno Trimarchi
2021-10-04 15:33 ` Miquel Raynal
2021-10-04 16:06 ` Han Xu
2021-10-05 6:02 ` Christian Eggers
2021-10-08 9:55 ` Christian Eggers
2021-10-08 12:08 ` Stefan Riedmüller
2021-10-08 12:27 ` Miquel Raynal
2021-10-08 13:11 ` Christian Eggers
2021-10-08 13:29 ` Miquel Raynal
2021-10-08 13:36 ` Miquel Raynal
2021-10-08 13:49 ` Christian Eggers
2021-10-08 16:07 ` Miquel Raynal
2021-10-09 5:53 ` Michael Nazzareno Trimarchi
2021-10-11 6:46 ` Miquel Raynal
2021-10-12 9:02 ` [RFC PATCH 1/2] mtd: rawnand: gpmi: Remove explicit default gpmi clock setting for i.MX6 Stefan Riedmueller
2021-10-12 9:02 ` [RFC PATCH 2/2] gpmi-nand: Add ERR007117 protection for nfc_apply_timings Stefan Riedmueller
2021-10-13 5:01 ` Han Xu
2021-10-22 8:45 ` Stefan Riedmüller
2021-10-22 14:35 ` han.xu
2021-10-25 9:39 ` Stefan Riedmüller
2021-10-28 9:28 ` Stefan Riedmüller
2021-11-01 4:01 ` han.xu
2021-10-13 6:10 ` Christian Eggers
2021-10-13 6:00 ` [RFC PATCH 1/2] mtd: rawnand: gpmi: Remove explicit default gpmi clock setting for i.MX6 Christian Eggers
2021-10-09 6:26 ` GPMI iMX6ull timeout on DMA Christian Eggers
2021-10-13 6:15 ` Christian Eggers
2021-10-08 13:13 ` Christian Eggers
2021-10-08 13:30 ` Miquel Raynal
2021-10-09 6:33 ` Christian Eggers
-- strict thread matches above, loose matches on Subject: below --
2018-10-02 13:22 GPMI IMX6ull timeout on dma Michael Nazzareno Trimarchi
2018-10-04 14:36 ` Michael Nazzareno Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOf5uwk8o_m6FJwnRtkGqhkTQZh-3b3FJoc_OnnQq6JdBPPKLg@mail.gmail.com \
--to=michael@amarulasolutions.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=gerg@kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).