linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Greg KH <greg@kroah.com>, Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-next@vger.kernel.org, Trent Piepho <xyzzy@speakeasy.org>,
	Kay Sievers <kay.sievers@vrfy.org>
Subject: linux-next: driver-core tree build failure
Date: Thu, 26 Mar 2009 18:34:33 +1100	[thread overview]
Message-ID: <20090326183433.75a895c7.sfr@canb.auug.org.au> (raw)

Hi Greg, Jesse,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/pci/hotplug/fakephp.c: In function 'legacy_add_slot':
drivers/pci/hotplug/fakephp.c:91: error: 'struct device' has no member named 'bus_id'

Caused by commit 83dbf66f04b96e65c6c18436c16d40f9cf8630aa ("PCI Hotplug:
restore fakephp interface with complete reimplementation") from the pci
tree which added another use of bus_id. (Commit
c32e967b935450c5178ebeaabb9ed889b14ed197 ("driver core: get rid of struct
device's bus_id string array") removes bus_id.)

I applied the batch below.  Jesse, this is suitable for the pci tree as
the dev_name() interface already exists in Linus' tree.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 26 Mar 2009 18:25:06 +1100
Subject: [PATCH] pci: update fakephp for bus_id removal

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/pci/hotplug/fakephp.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/hotplug/fakephp.c b/drivers/pci/hotplug/fakephp.c
index 2dc7828..21c2f5d 100644
--- a/drivers/pci/hotplug/fakephp.c
+++ b/drivers/pci/hotplug/fakephp.c
@@ -18,6 +18,7 @@
 #include <linux/sysfs.h>
 #include <linux/init.h>
 #include <linux/pci.h>
+#include <linux/device.h>
 #include "../pci.h"
 
 struct legacy_slot {
@@ -88,7 +89,7 @@ static int legacy_add_slot(struct pci_dev *pdev)
 
 	if (kobject_init_and_add(&slot->kobj, &legacy_ktype,
 				 &pci_slots_kset->kobj, "%s",
-				 pdev->dev.bus_id)) {
+				 dev_name(&pdev->dev))) {
 		dev_warn(&pdev->dev, "Failed to created legacy fake slot\n");
 		return -EINVAL;
 	}
-- 
1.6.2.1

             reply	other threads:[~2009-03-26  7:34 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-26  7:34 Stephen Rothwell [this message]
2009-03-26 23:00 ` linux-next: driver-core tree build failure Jesse Barnes
  -- strict thread matches above, loose matches on Subject: below --
2009-07-14  6:33 Stephen Rothwell
2009-07-14  7:31 ` David Brownell
2009-07-16 22:50   ` Greg KH
2009-06-23  6:01 Stephen Rothwell
2009-06-23 15:29 ` Greg KH
2009-06-23 16:28   ` Greg KH
2009-05-12  3:44 Stephen Rothwell
2009-05-12  4:05 ` Greg KH
2009-05-13  0:13   ` Greg KH
2009-05-13  1:39     ` Stephen Rothwell
2009-05-04  6:25 Stephen Rothwell
2009-05-04 13:00 ` Kay Sievers
2009-05-05  4:18   ` Stephen Rothwell
2009-05-05  4:29     ` Greg KH
2009-05-09 11:16 ` Stephen Rothwell
2009-05-09 13:51   ` Greg KH
2009-03-16  9:47 Stephen Rothwell
2009-03-22 12:22 ` Stephen Rothwell
2009-03-23  4:23   ` David Miller
2009-03-10  8:24 Stephen Rothwell
2009-03-10 13:31 ` Geert Uytterhoeven
2009-03-10 13:38   ` Herbert Xu
2009-03-10 13:53   ` Martin Schwidefsky
2009-03-10 15:29     ` Geert Uytterhoeven
2009-03-10 16:08       ` Martin Schwidefsky
2009-03-10 20:02         ` Jason Baron
2009-03-11  3:30           ` Greg KH
2009-03-11  8:33           ` Geert Uytterhoeven
2009-03-11 10:07           ` Greg Banks
2009-03-11 10:50             ` Geert Uytterhoeven
2009-03-11 15:12             ` Jason Baron
2009-01-26  0:50 Stephen Rothwell
2009-01-26  1:10 ` Greg KH
2009-01-26 12:19   ` Kay Sievers
2009-01-26 17:40     ` Greg KH
2008-12-22 12:59 Stephen Rothwell
2008-12-22 14:50 ` Mark McLoughlin
2008-12-23  4:29   ` Greg KH
2008-12-29  6:34     ` Stephen Rothwell
2008-12-30 15:28       ` Stephen Rothwell
2009-01-02  7:26         ` Greg KH
2009-01-03  4:32           ` Stephen Rothwell
2008-12-11  0:21 Stephen Rothwell
2008-12-11  4:55 ` Greg KH
2008-11-19  0:30 Stephen Rothwell
2008-11-19  0:40 ` Kay Sievers
2008-11-19  2:22   ` Stephen Rothwell
2008-11-19  2:24     ` Stephen Rothwell
2008-11-19  6:36     ` Greg KH
2008-11-19  5:43 ` Stephen Rothwell
2008-11-19  6:26   ` Greg KH
2008-11-19  6:51     ` Stephen Rothwell
2008-11-19  6:55       ` Greg KH
2008-09-12  3:53 Stephen Rothwell
2008-09-15 18:58 ` Greg KH
2008-08-15  8:25 Stephen Rothwell
2008-08-16  5:31 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090326183433.75a895c7.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=greg@kroah.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-next@vger.kernel.org \
    --cc=xyzzy@speakeasy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).