Re: linux-next: driver-core tree build failure

[Kay Sievers <kay.sievers@vrfy.org>]

On Mon, Jan 26, 2009 at 02:10, Greg KH <greg@kroah.com> wrote:
> On Mon, Jan 26, 2009 at 11:50:44AM +1100, Stephen Rothwell wrote:

>> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>>
>> arch/powerpc/platforms/ps3/system-bus.c: In function 'ps3_system_bus_probe':
>> arch/powerpc/platforms/ps3/system-bus.c:379: error: 'struct device' has no member named 'bus_id'
>> arch/powerpc/platforms/ps3/system-bus.c: In function 'ps3_system_bus_remove':
>> arch/powerpc/platforms/ps3/system-bus.c:401: error: 'struct device' has no member named 'bus_id'
>>
>> Caused by commit aab0d375e01d8c16e7e5b9bd915dfaa0a815418f ("powerpc:
>> struct device - replace bus_id with dev_name(), dev_set_name()") not
>> being thorough enough before commit
>> 73babb2d89a71d2110b65aab658e6309748827c2 ("driver core: get rid of struct
>> device's bus_id string array") was applied.
>>
>> I have reverted the latter commit.
>
> Gotta love the ps3 platform code, there is about 3 different fields
> called "bus_id" in that file :(

Yeah, that's "fun", especially if you don't have the environment to
compile it. :)

> Anyway, here's a patch that should fix this, Kay, look sane?

Looks fine, yes.

Thanks,
Kay