* [-next Sept 10] Build break - arch/s390/mm/pgtable.c (INIT_RCU_HEAD)
@ 2010-09-10 8:13 Sachin Sant
2010-09-10 10:28 ` Martin Schwidefsky
0 siblings, 1 reply; 5+ messages in thread
From: Sachin Sant @ 2010-09-10 8:13 UTC (permalink / raw)
To: linux-s390, linux-next; +Cc: Martin Schwidefsky
Today's next fails to build on a s390 box with
arch/s390/mm/pgtable.c: In function 'rcu_table_freelist_finish':
arch/s390/mm/pgtable.c:79: error: implicit declaration of function 'INIT_RCU_HEAD'
make[2]: *** [arch/s390/mm/pgtable.o] Error 1
This code in question was added via following commit:
commit e726023d9ff7e4968e3e0622782174a4695d68a4
S390] lockless get_user_pages_fast()
Thanks
-Sachin
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [-next Sept 10] Build break - arch/s390/mm/pgtable.c (INIT_RCU_HEAD)
2010-09-10 8:13 [-next Sept 10] Build break - arch/s390/mm/pgtable.c (INIT_RCU_HEAD) Sachin Sant
@ 2010-09-10 10:28 ` Martin Schwidefsky
2010-09-14 8:13 ` Sachin Sant
0 siblings, 1 reply; 5+ messages in thread
From: Martin Schwidefsky @ 2010-09-10 10:28 UTC (permalink / raw)
To: Sachin Sant; +Cc: linux-s390, linux-next
On Fri, 10 Sep 2010 13:43:20 +0530
Sachin Sant <sachinp@in.ibm.com> wrote:
> Today's next fails to build on a s390 box with
>
> arch/s390/mm/pgtable.c: In function 'rcu_table_freelist_finish':
> arch/s390/mm/pgtable.c:79: error: implicit declaration of function 'INIT_RCU_HEAD'
> make[2]: *** [arch/s390/mm/pgtable.o] Error 1
>
> This code in question was added via following commit:
>
> commit e726023d9ff7e4968e3e0622782174a4695d68a4
> S390] lockless get_user_pages_fast()
I guess that there is an #include <linux/rcupdate.h> missing in pgtable.c. I'll
add it to the patch.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [-next Sept 10] Build break - arch/s390/mm/pgtable.c (INIT_RCU_HEAD)
2010-09-10 10:28 ` Martin Schwidefsky
@ 2010-09-14 8:13 ` Sachin Sant
2010-09-14 8:36 ` Stephen Rothwell
0 siblings, 1 reply; 5+ messages in thread
From: Sachin Sant @ 2010-09-14 8:13 UTC (permalink / raw)
To: Martin Schwidefsky; +Cc: linux-s390, linux-next
Martin Schwidefsky wrote:
> On Fri, 10 Sep 2010 13:43:20 +0530
> Sachin Sant <sachinp@in.ibm.com> wrote:
>
>
>> Today's next fails to build on a s390 box with
>>
>> arch/s390/mm/pgtable.c: In function 'rcu_table_freelist_finish':
>> arch/s390/mm/pgtable.c:79: error: implicit declaration of function 'INIT_RCU_HEAD'
>> make[2]: *** [arch/s390/mm/pgtable.o] Error 1
>>
>> This code in question was added via following commit:
>>
>> commit e726023d9ff7e4968e3e0622782174a4695d68a4
>> S390] lockless get_user_pages_fast()
>>
>
> I guess that there is an #include <linux/rcupdate.h> missing in pgtable.c. I'll
> add it to the patch.
>
I don't see definition for INIT_RCU_HEAD in rcupdate.h so adding rcupdate.h might
not help.
Infact i can't find usage/implementation of INIT_RCU_HEAD anywhere else in the code.
Is this macro deprecated ?
Thanks
-Sachin
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [-next Sept 10] Build break - arch/s390/mm/pgtable.c (INIT_RCU_HEAD)
2010-09-14 8:13 ` Sachin Sant
@ 2010-09-14 8:36 ` Stephen Rothwell
2010-09-14 11:39 ` Martin Schwidefsky
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2010-09-14 8:36 UTC (permalink / raw)
To: Sachin Sant; +Cc: Martin Schwidefsky, linux-s390, linux-next
[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]
Hi Sachin, Martin,
On Tue, 14 Sep 2010 13:43:51 +0530 Sachin Sant <sachinp@in.ibm.com> wrote:
>
> Martin Schwidefsky wrote:
> > On Fri, 10 Sep 2010 13:43:20 +0530
> > Sachin Sant <sachinp@in.ibm.com> wrote:
> >
> >
> >> Today's next fails to build on a s390 box with
> >>
> >> arch/s390/mm/pgtable.c: In function 'rcu_table_freelist_finish':
> >> arch/s390/mm/pgtable.c:79: error: implicit declaration of function 'INIT_RCU_HEAD'
> >> make[2]: *** [arch/s390/mm/pgtable.o] Error 1
> >>
> >> This code in question was added via following commit:
> >>
> >> commit e726023d9ff7e4968e3e0622782174a4695d68a4
> >> S390] lockless get_user_pages_fast()
> >>
> >
> > I guess that there is an #include <linux/rcupdate.h> missing in pgtable.c. I'll
> > add it to the patch.
> >
> I don't see definition for INIT_RCU_HEAD in rcupdate.h so adding rcupdate.h might
> not help.
>
> Infact i can't find usage/implementation of INIT_RCU_HEAD anywhere else in the code.
> Is this macro deprecated ?
It has been removed by commit 5e8067adfdbaf97039a97540765b1e16eb8d61cc
("rcu head remove init") from the rcu and tip trees.
It was just initialising two internal pointers to NULL, so should not be
needed (for non automatic definitions) even in Linus' current tree.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [-next Sept 10] Build break - arch/s390/mm/pgtable.c (INIT_RCU_HEAD)
2010-09-14 8:36 ` Stephen Rothwell
@ 2010-09-14 11:39 ` Martin Schwidefsky
0 siblings, 0 replies; 5+ messages in thread
From: Martin Schwidefsky @ 2010-09-14 11:39 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Sachin Sant, linux-s390, linux-next
On Tue, 14 Sep 2010 18:36:48 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Sachin, Martin,
>
> On Tue, 14 Sep 2010 13:43:51 +0530 Sachin Sant <sachinp@in.ibm.com> wrote:
> >
> > Martin Schwidefsky wrote:
> > > On Fri, 10 Sep 2010 13:43:20 +0530
> > > Sachin Sant <sachinp@in.ibm.com> wrote:
> > >
> > >
> > >> Today's next fails to build on a s390 box with
> > >>
> > >> arch/s390/mm/pgtable.c: In function 'rcu_table_freelist_finish':
> > >> arch/s390/mm/pgtable.c:79: error: implicit declaration of function 'INIT_RCU_HEAD'
> > >> make[2]: *** [arch/s390/mm/pgtable.o] Error 1
> > >>
> > >> This code in question was added via following commit:
> > >>
> > >> commit e726023d9ff7e4968e3e0622782174a4695d68a4
> > >> S390] lockless get_user_pages_fast()
> > >>
> > >
> > > I guess that there is an #include <linux/rcupdate.h> missing in pgtable.c. I'll
> > > add it to the patch.
> > >
> > I don't see definition for INIT_RCU_HEAD in rcupdate.h so adding rcupdate.h might
> > not help.
> >
> > Infact i can't find usage/implementation of INIT_RCU_HEAD anywhere else in the code.
> > Is this macro deprecated ?
>
> It has been removed by commit 5e8067adfdbaf97039a97540765b1e16eb8d61cc
> ("rcu head remove init") from the rcu and tip trees.
>
> It was just initialising two internal pointers to NULL, so should not be
> needed (for non automatic definitions) even in Linus' current tree.
Ok, I'll drop the INIT_RCU_HEAD call from the patch. Without it linux-next compiles for me.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-09-14 11:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-10 8:13 [-next Sept 10] Build break - arch/s390/mm/pgtable.c (INIT_RCU_HEAD) Sachin Sant
2010-09-10 10:28 ` Martin Schwidefsky
2010-09-14 8:13 ` Sachin Sant
2010-09-14 8:36 ` Stephen Rothwell
2010-09-14 11:39 ` Martin Schwidefsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).