* linux-next: build failure after merge of the final tree (usb-gadget tree related)
@ 2013-08-13 8:17 Stephen Rothwell
2013-08-13 8:57 ` [PATCH] usb: phy: am335x: include linux/err.h Sebastian Andrzej Siewior
2013-08-13 19:48 ` linux-next: build failure after merge of the final tree (usb-gadget tree related) Felipe Balbi
0 siblings, 2 replies; 6+ messages in thread
From: Stephen Rothwell @ 2013-08-13 8:17 UTC (permalink / raw)
To: Felipe Balbi; +Cc: linux-next, linux-kernel, Sebastian Andrzej Siewior
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
Hi all,
After merging the final tree, today's linux-next build (powerpc allyesconfig)
failed like this:
drivers/usb/phy/phy-am335x-control.c: In function 'am335x_control_usb_probe':
drivers/usb/phy/phy-am335x-control.c:117:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
if (IS_ERR(ctrl_usb->phy_reg))
^
drivers/usb/phy/phy-am335x-control.c:118:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
return PTR_ERR(ctrl_usb->phy_reg);
^
Caused by commit 3bb869c8b3f1 ("usb: phy: Add AM335x PHY driver") from
the usb-gadget tree. Forgot to include linux/err.h.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] usb: phy: am335x: include linux/err.h
2013-08-13 8:17 linux-next: build failure after merge of the final tree (usb-gadget tree related) Stephen Rothwell
@ 2013-08-13 8:57 ` Sebastian Andrzej Siewior
2013-08-13 19:48 ` linux-next: build failure after merge of the final tree (usb-gadget tree related) Felipe Balbi
1 sibling, 0 replies; 6+ messages in thread
From: Sebastian Andrzej Siewior @ 2013-08-13 8:57 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Felipe Balbi, linux-next, linux-kernel, linux-usb
Stephen Rothwell reported that this driver does not compile on PowerPC
due to this missing include. One could argue why this driver is enabled
on PowerPC in the first place but it sure isn't wrong to include headers
for used function instead of to rely that they sneak in.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/usb/phy/phy-am335x-control.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/phy/phy-am335x-control.c b/drivers/usb/phy/phy-am335x-control.c
index 35494f1..7597545 100644
--- a/drivers/usb/phy/phy-am335x-control.c
+++ b/drivers/usb/phy/phy-am335x-control.c
@@ -1,5 +1,6 @@
#include <linux/module.h>
#include <linux/platform_device.h>
+#include <linux/err.h>
#include <linux/of.h>
#include <linux/io.h>
--
1.8.4.rc1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the final tree (usb-gadget tree related)
2013-08-13 8:17 linux-next: build failure after merge of the final tree (usb-gadget tree related) Stephen Rothwell
2013-08-13 8:57 ` [PATCH] usb: phy: am335x: include linux/err.h Sebastian Andrzej Siewior
@ 2013-08-13 19:48 ` Felipe Balbi
2013-08-13 19:51 ` Felipe Balbi
1 sibling, 1 reply; 6+ messages in thread
From: Felipe Balbi @ 2013-08-13 19:48 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Felipe Balbi, linux-next, linux-kernel, Sebastian Andrzej Siewior
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
Hi,
On Tue, Aug 13, 2013 at 06:17:19PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
>
> drivers/usb/phy/phy-am335x-control.c: In function 'am335x_control_usb_probe':
> drivers/usb/phy/phy-am335x-control.c:117:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> if (IS_ERR(ctrl_usb->phy_reg))
> ^
> drivers/usb/phy/phy-am335x-control.c:118:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
> return PTR_ERR(ctrl_usb->phy_reg);
> ^
>
> Caused by commit 3bb869c8b3f1 ("usb: phy: Add AM335x PHY driver") from
> the usb-gadget tree. Forgot to include linux/err.h.
>
> I have reverted that commit for today.
damn, I didn't catch that. Sebastian, can you send a patch ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the final tree (usb-gadget tree related)
2013-08-13 19:48 ` linux-next: build failure after merge of the final tree (usb-gadget tree related) Felipe Balbi
@ 2013-08-13 19:51 ` Felipe Balbi
2013-08-13 19:52 ` Sedat Dilek
0 siblings, 1 reply; 6+ messages in thread
From: Felipe Balbi @ 2013-08-13 19:51 UTC (permalink / raw)
To: Felipe Balbi
Cc: Stephen Rothwell, linux-next, linux-kernel, Sebastian Andrzej Siewior
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
On Tue, Aug 13, 2013 at 02:48:03PM -0500, Felipe Balbi wrote:
> Hi,
>
> On Tue, Aug 13, 2013 at 06:17:19PM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the final tree, today's linux-next build (powerpc allyesconfig)
> > failed like this:
> >
> > drivers/usb/phy/phy-am335x-control.c: In function 'am335x_control_usb_probe':
> > drivers/usb/phy/phy-am335x-control.c:117:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> > if (IS_ERR(ctrl_usb->phy_reg))
> > ^
> > drivers/usb/phy/phy-am335x-control.c:118:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
> > return PTR_ERR(ctrl_usb->phy_reg);
> > ^
> >
> > Caused by commit 3bb869c8b3f1 ("usb: phy: Add AM335x PHY driver") from
> > the usb-gadget tree. Forgot to include linux/err.h.
> >
> > I have reverted that commit for today.
>
> damn, I didn't catch that. Sebastian, can you send a patch ?
nevermind already patched it myself.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the final tree (usb-gadget tree related)
2013-08-13 19:51 ` Felipe Balbi
@ 2013-08-13 19:52 ` Sedat Dilek
2013-08-13 19:56 ` Felipe Balbi
0 siblings, 1 reply; 6+ messages in thread
From: Sedat Dilek @ 2013-08-13 19:52 UTC (permalink / raw)
To: balbi
Cc: Stephen Rothwell, linux-next, linux-kernel, Sebastian Andrzej Siewior
On Tue, Aug 13, 2013 at 9:51 PM, Felipe Balbi <balbi@ti.com> wrote:
> On Tue, Aug 13, 2013 at 02:48:03PM -0500, Felipe Balbi wrote:
>> Hi,
>>
>> On Tue, Aug 13, 2013 at 06:17:19PM +1000, Stephen Rothwell wrote:
>> > Hi all,
>> >
>> > After merging the final tree, today's linux-next build (powerpc allyesconfig)
>> > failed like this:
>> >
>> > drivers/usb/phy/phy-am335x-control.c: In function 'am335x_control_usb_probe':
>> > drivers/usb/phy/phy-am335x-control.c:117:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
>> > if (IS_ERR(ctrl_usb->phy_reg))
>> > ^
>> > drivers/usb/phy/phy-am335x-control.c:118:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
>> > return PTR_ERR(ctrl_usb->phy_reg);
>> > ^
>> >
>> > Caused by commit 3bb869c8b3f1 ("usb: phy: Add AM335x PHY driver") from
>> > the usb-gadget tree. Forgot to include linux/err.h.
>> >
>> > I have reverted that commit for today.
>>
>> damn, I didn't catch that. Sebastian, can you send a patch ?
>
> nevermind already patched it myself.
>
Sebastian sent some hours ago this one:
[PATCH] usb: phy: am335x: include linux/err.h
- Sedat -
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build failure after merge of the final tree (usb-gadget tree related)
2013-08-13 19:52 ` Sedat Dilek
@ 2013-08-13 19:56 ` Felipe Balbi
0 siblings, 0 replies; 6+ messages in thread
From: Felipe Balbi @ 2013-08-13 19:56 UTC (permalink / raw)
To: Sedat Dilek
Cc: balbi, Stephen Rothwell, linux-next, linux-kernel,
Sebastian Andrzej Siewior
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
On Tue, Aug 13, 2013 at 09:52:53PM +0200, Sedat Dilek wrote:
> On Tue, Aug 13, 2013 at 9:51 PM, Felipe Balbi <balbi@ti.com> wrote:
> > On Tue, Aug 13, 2013 at 02:48:03PM -0500, Felipe Balbi wrote:
> >> Hi,
> >>
> >> On Tue, Aug 13, 2013 at 06:17:19PM +1000, Stephen Rothwell wrote:
> >> > Hi all,
> >> >
> >> > After merging the final tree, today's linux-next build (powerpc allyesconfig)
> >> > failed like this:
> >> >
> >> > drivers/usb/phy/phy-am335x-control.c: In function 'am335x_control_usb_probe':
> >> > drivers/usb/phy/phy-am335x-control.c:117:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> >> > if (IS_ERR(ctrl_usb->phy_reg))
> >> > ^
> >> > drivers/usb/phy/phy-am335x-control.c:118:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
> >> > return PTR_ERR(ctrl_usb->phy_reg);
> >> > ^
> >> >
> >> > Caused by commit 3bb869c8b3f1 ("usb: phy: Add AM335x PHY driver") from
> >> > the usb-gadget tree. Forgot to include linux/err.h.
> >> >
> >> > I have reverted that commit for today.
> >>
> >> damn, I didn't catch that. Sebastian, can you send a patch ?
> >
> > nevermind already patched it myself.
> >
>
> Sebastian sent some hours ago this one:
>
> [PATCH] usb: phy: am335x: include linux/err.h
will replace with that.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-13 19:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-13 8:17 linux-next: build failure after merge of the final tree (usb-gadget tree related) Stephen Rothwell
2013-08-13 8:57 ` [PATCH] usb: phy: am335x: include linux/err.h Sebastian Andrzej Siewior
2013-08-13 19:48 ` linux-next: build failure after merge of the final tree (usb-gadget tree related) Felipe Balbi
2013-08-13 19:51 ` Felipe Balbi
2013-08-13 19:52 ` Sedat Dilek
2013-08-13 19:56 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).