From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Davidlohr Bueso <davidlohr@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: linux-next: build warning after merge of the akpm tree
Date: Tue, 20 May 2014 07:36:34 +1000 [thread overview]
Message-ID: <20140520073634.40179424@canb.auug.org.au> (raw)
In-Reply-To: <1400512396.2560.9.camel@buesod1.americas.hpqcorp.net>
[-- Attachment #1: Type: text/plain, Size: 2238 bytes --]
Hi,
On Mon, 19 May 2014 08:13:16 -0700 Davidlohr Bueso <davidlohr@hp.com> wrote:
>
> On Mon, 2014-05-19 at 18:13 +1000, Stephen Rothwell wrote:
> > Hi Andrew,
> >
> > After merging the akpm tree, today's linux-next build (arm
> > multi_v7_defconfig) produced these warnings:
> >
> >
> > ipc/ipcns_notifier.c:22:8: warning: excess elements in struct initializer [enabled by default]
> > ipc/ipcns_notifier.c:22:8: warning: (near initialization for 'ipcns_chain.rwsem') [enabled by default]
> > ipc/ipcns_notifier.c:22:8: warning: excess elements in struct initializer [enabled by default]
> > ipc/ipcns_notifier.c:22:8: warning: (near initialization for 'ipcns_chain.rwsem') [enabled by default]
> >
> > and many more in other files ...
>
> Hmm are all the warning the same? Is this just on arm? have you seen it
> in other archs? (Could you please send me the .config)
The warnings were all the same, I saw it only on arm (since that was
what I built) and I mentioned the config above.
> > Presumably a result of commit fe2038c57c03 ("rwsem: Support optimistic
> > spinning").
>
> If CONFIG_SMP, we add two new fields to the rwsem structure
> (include/linux/rwsem.h) and likewise we update the
> __RWSEM_INITIALIZER(name) macro. Afaict the only way to trigger
> something like that is to be using the spinlock variant
> (rwsem-spinlock.h).
Actually quite a few architectures do set
CONFIG_RWSEM_GENERIC_SPINLOCK, and so wouldn't it make more sense to
actually directly test that?
> The fix for that would be:
>
> diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
> index 3e108f1..091d993 100644
> --- a/include/linux/rwsem.h
> +++ b/include/linux/rwsem.h
> @@ -64,7 +64,7 @@ static inline int rwsem_is_locked(struct rw_semaphore *sem)
> # define __RWSEM_DEP_MAP_INIT(lockname)
> #endif
>
> -#ifdef CONFIG_SMP
> +#if defined(CONFIG_SMP) && defined(CONFIG_RWSEM_XCHGADD_ALGORITHM)
so
#if defined(CONFIG_SMP) && !defined(CONFIG_RWSEM_GENERIC_SPINLOCK)
?
> This was picked up today by -tip maintainers, so I guess it should also
> be removed from -mm.
Was a fix also picked up?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-19 21:36 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 8:13 linux-next: build warning after merge of the akpm tree Stephen Rothwell
2014-05-19 15:13 ` Davidlohr Bueso
2014-05-19 19:48 ` Andrew Morton
2014-05-19 20:56 ` Davidlohr Bueso
2014-05-19 21:17 ` Andrew Morton
2014-05-19 21:36 ` Stephen Rothwell [this message]
2014-05-19 22:38 ` Davidlohr Bueso
-- strict thread matches above, loose matches on Subject: below --
2021-01-28 8:46 Stephen Rothwell
2021-02-01 7:14 ` Vijayanand Jitta
2020-12-04 10:00 Stephen Rothwell
2020-12-05 5:19 ` Andrew Morton
2020-12-05 9:37 ` Stephen Rothwell
2020-12-07 12:08 ` Dmitry Vyukov
2020-12-07 12:38 ` Dmitry Vyukov
2020-12-07 12:52 ` Marco Elver
2020-12-09 10:06 ` Dmitry Vyukov
2020-12-08 12:01 ` Stephen Rothwell
2020-12-09 4:44 ` Michael Ellerman
2020-12-09 7:07 ` Stephen Rothwell
2020-12-10 0:19 ` Michael Ellerman
2020-12-10 21:17 ` Stephen Rothwell
2020-12-09 10:33 ` Stephen Rothwell
2020-12-09 18:56 ` Kees Cook
2020-02-28 4:35 Stephen Rothwell
2020-02-28 5:23 ` Arjun Roy
2020-01-06 6:11 Stephen Rothwell
2020-01-06 6:07 Stephen Rothwell
2020-01-07 23:11 ` Andrew Morton
2020-01-08 14:52 ` Steven Price
2018-11-30 5:40 Stephen Rothwell
2018-11-30 14:52 ` Dave Rodgman
2017-08-01 6:02 Stephen Rothwell
2017-08-01 6:15 ` Huang, Ying
2017-08-01 21:15 ` Arnd Bergmann
2017-06-26 6:30 Stephen Rothwell
2017-06-26 23:57 ` Wei Yang
2013-04-18 8:03 Stephen Rothwell
2013-04-10 8:33 Stephen Rothwell
2013-04-10 8:18 Stephen Rothwell
2013-02-20 6:34 Stephen Rothwell
2013-02-20 14:37 ` Peter Jones
2013-01-23 6:33 Stephen Rothwell
2013-01-23 6:43 ` Tang Chen
2012-11-09 3:43 Stephen Rothwell
2012-11-09 10:00 ` Grant Likely
2012-10-25 3:35 Stephen Rothwell
2012-04-27 5:44 Stephen Rothwell
2012-04-27 6:22 ` Cyrill Gorcunov
2012-04-27 6:28 ` Stephen Rothwell
2012-04-27 6:40 ` Cyrill Gorcunov
2011-08-10 2:13 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520073634.40179424@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=davidlohr@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).