From: Vijayanand Jitta <vjitta@codeaurora.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Vinayak Menon <vinmenon@codeaurora.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the akpm tree
Date: Mon, 1 Feb 2021 12:44:51 +0530 [thread overview]
Message-ID: <aa6b93c6-f4a7-add7-13ed-d60ae4e749ca@codeaurora.org> (raw)
In-Reply-To: <20210128194631.13e14818@canb.auug.org.au>
On 1/28/2021 2:16 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the akpm tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> lib/stackdepot.c: In function 'is_stack_depot_disabled':
> lib/stackdepot.c:154:2: warning: ignoring return value of 'kstrtobool' declared with attribute 'warn_unused_result' [-Wunused-result]
> 154 | kstrtobool(str, &stack_depot_disable);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> b9779abb09a8 ("lib: stackdepot: add support to disable stack depot")
>
> Interestingly, we have 2 declarations of kstrtobool - one in
> linux/kernel.h (which has __must_check) and one in linux/strings.h
> (which doesn't).
>
I have sent out the fix to lkml, Copied it below for your reference.
Please Feel free to apply or squash it to the original commit.
Thanks,
Vijay
--
From: Vijayanand Jitta <vjitta@codeaurora.org>
fix the below ignoring return value warning for kstrtobool
in is_stack_depot_disabled function.
lib/stackdepot.c: In function 'is_stack_depot_disabled':
lib/stackdepot.c:154:2: warning: ignoring return value of 'kstrtobool'
declared with attribute 'warn_unused_result' [-Wunused-result]
Fixes: b9779abb09a8 ("lib: stackdepot: add support to disable stack depot")
Signed-off-by: Vijayanand Jitta <vjitta@codeaurora.org>
---
lib/stackdepot.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index cc21116..49f67a0 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -151,8 +151,10 @@ static struct stack_record **stack_table;
static int __init is_stack_depot_disabled(char *str)
{
- kstrtobool(str, &stack_depot_disable);
- if (stack_depot_disable) {
+ int ret;
+
+ ret = kstrtobool(str, &stack_depot_disable);
+ if (!ret && stack_depot_disable) {
pr_info("Stack Depot is disabled\n");
stack_table = NULL;
}
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2021-02-01 7:27 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 8:46 linux-next: build warning after merge of the akpm tree Stephen Rothwell
2021-02-01 7:14 ` Vijayanand Jitta [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-04 10:00 Stephen Rothwell
2020-12-05 5:19 ` Andrew Morton
2020-12-05 9:37 ` Stephen Rothwell
2020-12-07 12:08 ` Dmitry Vyukov
2020-12-07 12:38 ` Dmitry Vyukov
2020-12-07 12:52 ` Marco Elver
2020-12-09 10:06 ` Dmitry Vyukov
2020-12-08 12:01 ` Stephen Rothwell
2020-12-09 4:44 ` Michael Ellerman
2020-12-09 7:07 ` Stephen Rothwell
2020-12-10 0:19 ` Michael Ellerman
2020-12-10 21:17 ` Stephen Rothwell
2020-12-09 10:33 ` Stephen Rothwell
2020-12-09 18:56 ` Kees Cook
2020-02-28 4:35 Stephen Rothwell
2020-02-28 5:23 ` Arjun Roy
2020-01-06 6:11 Stephen Rothwell
2020-01-06 6:07 Stephen Rothwell
2020-01-07 23:11 ` Andrew Morton
2020-01-08 14:52 ` Steven Price
2018-11-30 5:40 Stephen Rothwell
2018-11-30 14:52 ` Dave Rodgman
2017-08-01 6:02 Stephen Rothwell
2017-08-01 6:15 ` Huang, Ying
2017-08-01 21:15 ` Arnd Bergmann
2017-06-26 6:30 Stephen Rothwell
2017-06-26 23:57 ` Wei Yang
2014-05-19 8:13 Stephen Rothwell
2014-05-19 15:13 ` Davidlohr Bueso
2014-05-19 19:48 ` Andrew Morton
2014-05-19 20:56 ` Davidlohr Bueso
2014-05-19 21:17 ` Andrew Morton
2014-05-19 21:36 ` Stephen Rothwell
2014-05-19 22:38 ` Davidlohr Bueso
2013-04-18 8:03 Stephen Rothwell
2013-04-10 8:33 Stephen Rothwell
2013-04-10 8:18 Stephen Rothwell
2013-02-20 6:34 Stephen Rothwell
2013-02-20 14:37 ` Peter Jones
2013-01-23 6:33 Stephen Rothwell
2013-01-23 6:43 ` Tang Chen
2012-11-09 3:43 Stephen Rothwell
2012-11-09 10:00 ` Grant Likely
2012-10-25 3:35 Stephen Rothwell
2012-04-27 5:44 Stephen Rothwell
2012-04-27 6:22 ` Cyrill Gorcunov
2012-04-27 6:28 ` Stephen Rothwell
2012-04-27 6:40 ` Cyrill Gorcunov
2011-08-10 2:13 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa6b93c6-f4a7-add7-13ed-d60ae4e749ca@codeaurora.org \
--to=vjitta@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).