From: Steven Rostedt <rostedt@goodmis.org>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>,
Dave Hansen <dave@sr71.net>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-next <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Kristen Carlson Accardi <kristen@linux.intel.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>
Subject: Re: linux-next: Tree for Feb 4
Date: Thu, 5 Feb 2015 15:22:01 -0500 [thread overview]
Message-ID: <20150205152201.49d55905@gandalf.local.home> (raw)
In-Reply-To: <CA+icZUUC7vD_FBUWV+WLBx2M-iXvR8E90zWGxmUWQcdmbHiH2A@mail.gmail.com>
On Thu, 5 Feb 2015 21:07:27 +0100
Sedat Dilek <sedat.dilek@gmail.com> wrote:
> > Is this Paul's version of the patch or mine? If it is just mine, do you
> > know if Paul's version triggers this too?
> >
>
> This one which entered Pauls rcu-next tree.
>
> [1] http://git.kernel.org/cgit/linux/kernel/git/paulmck/linux-rcu.git/commit/?h=rcu/next&id=2b27cf7317d8a99a50bead9faccd54b46b6f0c41
That's mine.
It looks like the condition will be tested before it calls and rcu
code. Which is why I was confused that it still gave a splat. Paul
posted a patch before this that did the check outside the trace point.
This one:
http://marc.info/?l=linux-kernel&m=142310961217650&w=2
>
> >> ( I did not build from scratch but re-invoking make "updated" the
> >> files touched by Steven's patch, see attached build-log. )
> >>
> >> Unfortunately, the call-trace remains when doing an offlining of cpu1.
> >> ( It's good to see it's reproducible. )
> >
> > Was the tracepoint enabled? Or was there some other rcu call that
> > triggered this. Or would cpu_online(smp_processor_id()) return true at
> > this point?
> >
>
> Thanks Steve for jumping into this one!
>
> Good point.
> I looked at my kernel-config (which I already sent :-)).
>
> Do I need to enable...?
>
> # CONFIG_RCU_TRACE is not set
>
> ...or even more?
>
What I meant by the tracepoint being enabled, was not that it was
configured in (I'm assuming it was), but that you started tracing?
echo 1 > /sys/kernel/debug/tracing/events/enable
or
echo 1 > /sys/kernel/debug/tracing/events/tlb/tlb_flushed/enable
-- Steve
next prev parent reply other threads:[~2015-02-05 20:22 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 8:35 linux-next: Tree for Feb 4 Stephen Rothwell
2015-02-04 12:26 ` Sedat Dilek
2015-02-04 15:16 ` Jens Axboe
2015-02-04 15:21 ` Sedat Dilek
2015-02-04 15:31 ` Jens Axboe
2015-02-04 15:36 ` Sedat Dilek
2015-02-04 15:58 ` Martin K. Petersen
2015-02-04 16:06 ` Sedat Dilek
2015-02-05 3:17 ` Martin K. Petersen
2015-02-05 3:41 ` Sedat Dilek
2015-02-05 19:46 ` Sedat Dilek
2015-02-06 15:24 ` Sedat Dilek
2015-02-04 20:18 ` Sedat Dilek
2015-02-04 21:54 ` Rafael J. Wysocki
2015-02-04 21:53 ` Paul E. McKenney
2015-02-04 22:59 ` Rafael J. Wysocki
2015-02-04 23:51 ` Paul E. McKenney
2015-02-04 23:58 ` Sedat Dilek
2015-02-05 0:10 ` Paul E. McKenney
2015-02-05 0:30 ` Sedat Dilek
2015-02-05 0:57 ` Paul E. McKenney
2015-02-05 1:18 ` Sedat Dilek
2015-02-05 1:51 ` Paul E. McKenney
2015-02-05 1:53 ` Sedat Dilek
2015-02-05 2:12 ` Sedat Dilek
2015-02-05 4:13 ` Paul E. McKenney
2015-02-05 7:14 ` Dave Hansen
2015-02-05 14:37 ` Paul E. McKenney
2015-02-05 14:57 ` Sedat Dilek
2015-02-05 16:58 ` Paul E. McKenney
2015-02-05 18:03 ` Steven Rostedt
2015-02-05 18:08 ` Steven Rostedt
2015-02-05 18:11 ` Dave Hansen
2015-02-05 18:34 ` Paul E. McKenney
2015-02-05 18:35 ` Dave Hansen
2015-02-05 18:45 ` Paul E. McKenney
2015-02-05 19:25 ` Sedat Dilek
2015-02-05 19:33 ` Paul E. McKenney
2015-02-05 19:42 ` Sedat Dilek
2015-02-05 19:58 ` Steven Rostedt
2015-02-05 20:07 ` Sedat Dilek
2015-02-05 20:22 ` Steven Rostedt [this message]
2015-02-05 20:50 ` Sedat Dilek
2015-02-05 21:45 ` Sedat Dilek
2015-02-05 22:09 ` Steven Rostedt
2015-02-05 22:16 ` Sedat Dilek
2015-02-05 23:11 ` Steven Rostedt
2015-02-05 23:53 ` Sedat Dilek
2015-02-06 0:03 ` Sedat Dilek
2015-02-06 0:12 ` Steven Rostedt
2015-02-06 0:14 ` Sedat Dilek
2015-02-04 22:38 ` Sedat Dilek
2015-02-04 23:25 ` Rafael J. Wysocki
2015-02-04 23:54 ` Sedat Dilek
2015-02-04 22:46 ` Sedat Dilek
2015-02-04 23:30 ` Rafael J. Wysocki
2015-02-04 23:48 ` Sedat Dilek
-- strict thread matches above, loose matches on Subject: below --
2022-02-04 4:14 Stephen Rothwell
2021-02-04 9:13 Stephen Rothwell
2020-02-04 4:19 Stephen Rothwell
2019-02-04 5:35 Stephen Rothwell
2016-02-04 3:48 Stephen Rothwell
2014-02-04 5:07 Stephen Rothwell
[not found] ` <CAP=VYLpgLC_4yuPtQH_yAd8S9cqQAVu2uB2=Wf3q_zgY4uzkLw@mail.gmail.com>
2014-02-04 22:23 ` Stephen Rothwell
2014-02-05 0:41 ` Stephen Rothwell
2013-02-04 7:39 Stephen Rothwell
2013-02-04 13:56 ` James Hogan
2013-02-04 20:33 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205152201.49d55905@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dave@sr71.net \
--cc=hpa@linux.intel.com \
--cc=kristen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=riel@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=sedat.dilek@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).