linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: manual merge of the cgroup tree with the tip tree
@ 2015-12-21  4:41 Stephen Rothwell
  2015-12-21  4:48 ` Tejun Heo
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2015-12-21  4:41 UTC (permalink / raw)
  To: Tejun Heo, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
  Cc: linux-next, linux-kernel, Fenghua Yu, Johannes Weiner

Hi Tejun,

Today's linux-next merge of the cgroup tree got a conflict in:

  init/Kconfig

between commits:

  257372262056 ("x86/intel_rdt: Add support for Cache Allocation detection")
  5ad9144cdb9a ("x86,cgroup/intel_rdt : Add a cgroup interface to manage Intel cache allocation")

from the tip tree and commit:

  6bf024e69333 ("cgroup: put controller Kconfig options in meaningful order")

from the cgroup tree.

I fixed it up (see below - I wasn't sure where to put the new INTEL_RDT
config option) and can carry the fix as necessary (no action is required).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc init/Kconfig
index 4139128e3cab,f8754f502c36..000000000000
--- a/init/Kconfig
+++ b/init/Kconfig
@@@ -935,77 -940,6 +935,18 @@@ menuconfig CGROUP
  
  if CGROUPS
  
 +config INTEL_RDT
 +	bool "Intel Resource Director Technology support"
 +	depends on X86_64 && CPU_SUP_INTEL
 +	help
 +	  This option provides support for Cache allocation which is a
 +	  sub-feature of Intel Resource Director  Technology(RDT).
 +	  Current implementation supports L3 cache allocation.
 +	  Using this feature a user can specify the amount of L3 cache space
 +	  into which an application can fill.
 +
 +	  Say N if unsure.
 +
- config CGROUP_DEBUG
- 	bool "Example debug cgroup subsystem"
- 	default n
- 	help
- 	  This option enables a simple cgroup subsystem that
- 	  exports useful debugging information about the cgroups
- 	  framework.
- 
- 	  Say N if unsure.
- 
- config CGROUP_FREEZER
- 	bool "Freezer cgroup subsystem"
- 	help
- 	  Provides a way to freeze and unfreeze all tasks in a
- 	  cgroup.
- 
- config CGROUP_PIDS
- 	bool "PIDs cgroup subsystem"
- 	help
- 	  Provides enforcement of process number limits in the scope of a
- 	  cgroup. Any attempt to fork more processes than is allowed in the
- 	  cgroup will fail. PIDs are fundamentally a global resource because it
- 	  is fairly trivial to reach PID exhaustion before you reach even a
- 	  conservative kmemcg limit. As a result, it is possible to grind a
- 	  system to halt without being limited by other cgroup policies. The
- 	  PIDs cgroup subsystem is designed to stop this from happening.
- 
- 	  It should be noted that organisational operations (such as attaching
- 	  to a cgroup hierarchy will *not* be blocked by the PIDs subsystem),
- 	  since the PIDs limit only affects a process's ability to fork, not to
- 	  attach to a cgroup.
- 
- config CGROUP_DEVICE
- 	bool "Device controller for cgroups"
- 	help
- 	  Provides a cgroup implementing whitelists for devices which
- 	  a process in the cgroup can mknod or open.
- 
- config CPUSETS
- 	bool "Cpuset support"
- 	help
- 	  This option will let you create and manage CPUSETs which
- 	  allow dynamically partitioning a system into sets of CPUs and
- 	  Memory Nodes and assigning tasks to run only within those sets.
- 	  This is primarily useful on large SMP or NUMA systems.
- 
- 	  Say N if unsure.
- 
- config PROC_PID_CPUSET
- 	bool "Include legacy /proc/<pid>/cpuset file"
- 	depends on CPUSETS
- 	default y
- 
- config CGROUP_CPUACCT
- 	bool "Simple CPU accounting cgroup subsystem"
- 	help
- 	  Provides a simple Resource Controller for monitoring the
- 	  total CPU consumed by the tasks in a cgroup.
- 
  config PAGE_COUNTER
         bool
  

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: manual merge of the cgroup tree with the tip tree
  2015-12-21  4:41 linux-next: manual merge of the cgroup tree with the tip tree Stephen Rothwell
@ 2015-12-21  4:48 ` Tejun Heo
  2016-01-11 15:15   ` Ingo Molnar
  0 siblings, 1 reply; 7+ messages in thread
From: Tejun Heo @ 2015-12-21  4:48 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra,
	linux-next, linux-kernel, Fenghua Yu, Johannes Weiner

On Mon, Dec 21, 2015 at 03:41:19PM +1100, Stephen Rothwell wrote:
> Hi Tejun,
> 
> Today's linux-next merge of the cgroup tree got a conflict in:
> 
>   init/Kconfig
> 
> between commits:
> 
>   257372262056 ("x86/intel_rdt: Add support for Cache Allocation detection")
>   5ad9144cdb9a ("x86,cgroup/intel_rdt : Add a cgroup interface to manage Intel cache allocation")

Ingo, can you please revert the rdt cgroup.  I still don't think this
is the right approach and tglx's new proposal seems a lot better.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: manual merge of the cgroup tree with the tip tree
  2015-12-21  4:48 ` Tejun Heo
@ 2016-01-11 15:15   ` Ingo Molnar
  0 siblings, 0 replies; 7+ messages in thread
From: Ingo Molnar @ 2016-01-11 15:15 UTC (permalink / raw)
  To: Tejun Heo
  Cc: Stephen Rothwell, Thomas Gleixner, Ingo Molnar, H. Peter Anvin,
	Peter Zijlstra, linux-next, linux-kernel, Fenghua Yu,
	Johannes Weiner


* Tejun Heo <tj@kernel.org> wrote:

> On Mon, Dec 21, 2015 at 03:41:19PM +1100, Stephen Rothwell wrote:
> > Hi Tejun,
> > 
> > Today's linux-next merge of the cgroup tree got a conflict in:
> > 
> >   init/Kconfig
> > 
> > between commits:
> > 
> >   257372262056 ("x86/intel_rdt: Add support for Cache Allocation detection")
> >   5ad9144cdb9a ("x86,cgroup/intel_rdt : Add a cgroup interface to manage Intel cache allocation")
> 
> Ingo, can you please revert the rdt cgroup.  I still don't think this
> is the right approach and tglx's new proposal seems a lot better.
> 
> Thanks.

Ok, it's all zapped.

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: linux-next: manual merge of the cgroup tree with the tip tree
  2022-09-12  5:59 Stephen Rothwell
@ 2022-10-10 21:00 ` Stephen Rothwell
  0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2022-10-10 21:00 UTC (permalink / raw)
  To: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
  Cc: Tejun Heo, Chengming Zhou, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 2062 bytes --]

Hi all,

On Mon, 12 Sep 2022 15:59:41 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>

> Today's linux-next merge of the cgroup tree got a conflict in:
> 
>   kernel/cgroup/cgroup.c
> 
> between commit:
> 
>   34f26a15611a ("sched/psi: Per-cgroup PSI accounting disable/re-enable interface")
> 
> from the tip tree and commit:
> 
>   8a693f7766f9 ("cgroup: Remove CFTYPE_PRESSURE")
> 
> from the cgroup tree.
> 
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
> 
> 
> diff --cc kernel/cgroup/cgroup.c
> index 3dcd2a0041b3,e24015877d3c..000000000000
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@@ -5222,8 -5159,6 +5247,7 @@@ static struct cftype cgroup_psi_files[
>   #ifdef CONFIG_PSI
>   	{
>   		.name = "io.pressure",
> - 		.flags = CFTYPE_PRESSURE,
>  +		.file_offset = offsetof(struct cgroup, psi_files[PSI_IO]),
>   		.seq_show = cgroup_io_pressure_show,
>   		.write = cgroup_io_pressure_write,
>   		.poll = cgroup_pressure_poll,
> @@@ -5231,8 -5166,6 +5255,7 @@@
>   	},
>   	{
>   		.name = "memory.pressure",
> - 		.flags = CFTYPE_PRESSURE,
>  +		.file_offset = offsetof(struct cgroup, psi_files[PSI_MEM]),
>   		.seq_show = cgroup_memory_pressure_show,
>   		.write = cgroup_memory_pressure_write,
>   		.poll = cgroup_pressure_poll,
> @@@ -5240,8 -5173,6 +5263,7 @@@
>   	},
>   	{
>   		.name = "cpu.pressure",
> - 		.flags = CFTYPE_PRESSURE,
>  +		.file_offset = offsetof(struct cgroup, psi_files[PSI_CPU]),
>   		.seq_show = cgroup_cpu_pressure_show,
>   		.write = cgroup_cpu_pressure_write,
>   		.poll = cgroup_pressure_poll,

This is now a conflict between the tip tree and Linus' tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* linux-next: manual merge of the cgroup tree with the tip tree
@ 2022-09-12  5:59 Stephen Rothwell
  2022-10-10 21:00 ` Stephen Rothwell
  0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2022-09-12  5:59 UTC (permalink / raw)
  To: Tejun Heo, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
  Cc: Chengming Zhou, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1802 bytes --]

Hi all,

Today's linux-next merge of the cgroup tree got a conflict in:

  kernel/cgroup/cgroup.c

between commit:

  34f26a15611a ("sched/psi: Per-cgroup PSI accounting disable/re-enable interface")

from the tip tree and commit:

  8a693f7766f9 ("cgroup: Remove CFTYPE_PRESSURE")

from the cgroup tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc kernel/cgroup/cgroup.c
index 3dcd2a0041b3,e24015877d3c..000000000000
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@@ -5222,8 -5159,6 +5247,7 @@@ static struct cftype cgroup_psi_files[
  #ifdef CONFIG_PSI
  	{
  		.name = "io.pressure",
- 		.flags = CFTYPE_PRESSURE,
 +		.file_offset = offsetof(struct cgroup, psi_files[PSI_IO]),
  		.seq_show = cgroup_io_pressure_show,
  		.write = cgroup_io_pressure_write,
  		.poll = cgroup_pressure_poll,
@@@ -5231,8 -5166,6 +5255,7 @@@
  	},
  	{
  		.name = "memory.pressure",
- 		.flags = CFTYPE_PRESSURE,
 +		.file_offset = offsetof(struct cgroup, psi_files[PSI_MEM]),
  		.seq_show = cgroup_memory_pressure_show,
  		.write = cgroup_memory_pressure_write,
  		.poll = cgroup_pressure_poll,
@@@ -5240,8 -5173,6 +5263,7 @@@
  	},
  	{
  		.name = "cpu.pressure",
- 		.flags = CFTYPE_PRESSURE,
 +		.file_offset = offsetof(struct cgroup, psi_files[PSI_CPU]),
  		.seq_show = cgroup_cpu_pressure_show,
  		.write = cgroup_cpu_pressure_write,
  		.poll = cgroup_pressure_poll,

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* linux-next: manual merge of the cgroup tree with the tip tree
@ 2015-12-21  4:41 Stephen Rothwell
  0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2015-12-21  4:41 UTC (permalink / raw)
  To: Tejun Heo, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
  Cc: linux-next, linux-kernel, Fenghua Yu, Oleg Nesterov

Hi Tejun,

Today's linux-next merge of the cgroup tree got a conflict in:

  include/linux/cgroup_subsys.h

between commit:

  5ad9144cdb9a ("x86,cgroup/intel_rdt : Add a cgroup interface to manage Intel cache allocation")

from the tip tree and commit:

  b53202e63089 ("cgroup: kill cgrp_ss_priv[CGROUP_CANFORK_COUNT] and friends")

from the cgroup tree.

I fixed it up (see below) and can carry the fix as necessary (no action
is required).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc include/linux/cgroup_subsys.h
index c559ef5cae23,0df0336acee9..000000000000
--- a/include/linux/cgroup_subsys.h
+++ b/include/linux/cgroup_subsys.h
@@@ -58,15 -52,6 +52,10 @@@ SUBSYS(net_prio
  SUBSYS(hugetlb)
  #endif
  
 +#if IS_ENABLED(CONFIG_INTEL_RDT)
 +SUBSYS(intel_rdt)
 +#endif
 +
- /*
-  * Subsystems that implement the can_fork() family of callbacks.
-  */
- SUBSYS_TAG(CANFORK_START)
- 
  #if IS_ENABLED(CONFIG_CGROUP_PIDS)
  SUBSYS(pids)
  #endif

^ permalink raw reply	[flat|nested] 7+ messages in thread

* linux-next: manual merge of the cgroup tree with the tip tree
@ 2015-10-16  5:40 Stephen Rothwell
  0 siblings, 0 replies; 7+ messages in thread
From: Stephen Rothwell @ 2015-10-16  5:40 UTC (permalink / raw)
  To: Tejun Heo, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, Peter Zijlstra
  Cc: linux-next, linux-kernel, Kirill Tkhai

Hi Tejun,

Today's linux-next merge of the cgroup tree got conflicts in:

  kernel/events/core.c
  kernel/sched/core.c

between commits:

  516792e67c39 ("perf/core: Delete PF_EXITING checks from perf_cgroup_exit() callback")
  446685e9bfa1 ("sched/core: Delete PF_EXITING checks from cpu_cgroup_exit() callback")

from the tip tree and commit:

  2e91fa7f6d45 ("cgroup: keep zombies associated with their original cgroups")

from the cgroup tree.

I fixed it up (the latter removed the two functions that were modified
by the former 2 commits) and can carry the fix as necessary (no action
is required).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-10-10 21:02 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-21  4:41 linux-next: manual merge of the cgroup tree with the tip tree Stephen Rothwell
2015-12-21  4:48 ` Tejun Heo
2016-01-11 15:15   ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2022-09-12  5:59 Stephen Rothwell
2022-10-10 21:00 ` Stephen Rothwell
2015-12-21  4:41 Stephen Rothwell
2015-10-16  5:40 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).