* [PATCH-next] liquidio: fix implicit irq include causing build failures
@ 2017-07-23 14:44 Paul Gortmaker
2017-07-24 23:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2017-07-23 14:44 UTC (permalink / raw)
To: netdev
Cc: linux-next, Paul Gortmaker, Derek Chickles, Satanand Burla,
Felix Manlunas, Raghu Vatsavayi
To fix
In file included from drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:24:0:
drivers/net/ethernet/cavium/liquidio/octeon_device.h:216:2: error: expected specifier-qualifier-list before ‘irqreturn_t’
irqreturn_t (*process_interrupt_regs)(void *);
^
as seen on arm64 allmodconfig builds.
Cc: Derek Chickles <derek.chickles@caviumnetworks.com>
Cc: Satanand Burla <satananda.burla@caviumnetworks.com>
Cc: Felix Manlunas <felix.manlunas@caviumnetworks.com>
Cc: Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
[Seen on current linux-next, where similar implicit irq includes
were recently revealed by some header shuffle somewhere.]
drivers/net/ethernet/cavium/liquidio/octeon_device.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.h b/drivers/net/ethernet/cavium/liquidio/octeon_device.h
index c90ed48ae8ab..ad464788c923 100644
--- a/drivers/net/ethernet/cavium/liquidio/octeon_device.h
+++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.h
@@ -22,6 +22,8 @@
#ifndef _OCTEON_DEVICE_H_
#define _OCTEON_DEVICE_H_
+#include <linux/interrupt.h>
+
/** PCI VendorId Device Id */
#define OCTEON_CN68XX_PCIID 0x91177d
#define OCTEON_CN66XX_PCIID 0x92177d
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH-next] liquidio: fix implicit irq include causing build failures
2017-07-23 14:44 [PATCH-next] liquidio: fix implicit irq include causing build failures Paul Gortmaker
@ 2017-07-24 23:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-07-24 23:26 UTC (permalink / raw)
To: paul.gortmaker
Cc: netdev, linux-next, derek.chickles, satananda.burla,
felix.manlunas, raghu.vatsavayi
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Sun, 23 Jul 2017 10:44:52 -0400
> To fix
>
> In file included from drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:24:0:
> drivers/net/ethernet/cavium/liquidio/octeon_device.h:216:2: error: expected specifier-qualifier-list before ‘irqreturn_t’
> irqreturn_t (*process_interrupt_regs)(void *);
> ^
>
> as seen on arm64 allmodconfig builds.
>
> Cc: Derek Chickles <derek.chickles@caviumnetworks.com>
> Cc: Satanand Burla <satananda.burla@caviumnetworks.com>
> Cc: Felix Manlunas <felix.manlunas@caviumnetworks.com>
> Cc: Raghu Vatsavayi <raghu.vatsavayi@caviumnetworks.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-24 23:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-23 14:44 [PATCH-next] liquidio: fix implicit irq include causing build failures Paul Gortmaker
2017-07-24 23:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).