linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

[Stephen Rothwell]

Hi all,

On Mon, 31 Jul 2017 07:24:25 -0000 noreply@ellerman.id.au wrote:
>
> FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/13110910/
> 
> Commit:   Add linux-next specific files for 20170731
>           742f220ee69c8102eabea45e45d92aa18721fab1
> Compiler: s390x-linux-gcc (GCC) 4.6.3
> 
> Possible errors
> ---------------
> 
> include/linux/msi.h:196:21: fatal error: asm/msi.h: No such file or directory
> make[2]: *** [arch/s390/kernel/asm-offsets.s] Error 1
> make[1]: *** [prepare0] Error 2
> make: *** [sub-make] Error 2

Caused by commit

  03274850279c ("staging: fsl-mc: allow the driver compile multi-arch")

I will revert that commit tomorrow unless it if fixed in the mean time.
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

[Laurentiu Tudor]

Hi Stephen,

That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not 
all arches implement the support for the option. I can submit a patch 
that adds explicit dependencies on arches that it was build-tested (x86, 
arm, powerpc, all both 32 and 64 bits) similar to how it's done here 
[1]. Let me know if you're ok with this fix and i'll submit the fix to 
staging.

---
Thanks & Best Regards, Laurentiu

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/Kconfig#n28

On 07/31/2017 12:35 PM, Stephen Rothwell wrote:
> Hi all,
>
> On Mon, 31 Jul 2017 07:24:25 -0000 noreply@ellerman.id.au wrote:
>>
>> FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24
>>
>> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fkisskb.ellerman.id.au%2Fkisskb%2Fbuildresult%2F13110910%2F&data=01%7C01%7Claurentiu.tudor%40nxp.com%7C0b58775ead154830f76f08d4d7f78d99%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0&sdata=A84bbMQe7VRz9OPK13PzaidBEfjm43Ik%2FbfCDJ89ZzM%3D&reserved=0
>>
>> Commit:   Add linux-next specific files for 20170731
>>            742f220ee69c8102eabea45e45d92aa18721fab1
>> Compiler: s390x-linux-gcc (GCC) 4.6.3
>>
>> Possible errors
>> ---------------
>>
>> include/linux/msi.h:196:21: fatal error: asm/msi.h: No such file or directory
>> make[2]: *** [arch/s390/kernel/asm-offsets.s] Error 1
>> make[1]: *** [prepare0] Error 2
>> make: *** [sub-make] Error 2
>
> Caused by commit
>
>    03274850279c ("staging: fsl-mc: allow the driver compile multi-arch")
>
> I will revert that commit tomorrow unless it if fixed in the mean time.
>

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

[Greg KH]

On Mon, Jul 31, 2017 at 09:55:14AM +0000, Laurentiu Tudor wrote:
> Hi Stephen,
> 
> That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not 
> all arches implement the support for the option. I can submit a patch 
> that adds explicit dependencies on arches that it was build-tested (x86, 
> arm, powerpc, all both 32 and 64 bits) similar to how it's done here 
> [1]. Let me know if you're ok with this fix and i'll submit the fix to 
> staging.

Ugh, you should not be selecting that option, but rather depending on
the option, right?

thanks,

greg k-h

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

[Laurentiu Tudor]

On 07/31/2017 06:58 PM, Greg KH wrote:
> On Mon, Jul 31, 2017 at 09:55:14AM +0000, Laurentiu Tudor wrote:
>> Hi Stephen,
>>
>> That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not
>> all arches implement the support for the option. I can submit a patch
>> that adds explicit dependencies on arches that it was build-tested (x86,
>> arm, powerpc, all both 32 and 64 bits) similar to how it's done here
>> [1]. Let me know if you're ok with this fix and i'll submit the fix to
>> staging.
>
> Ugh, you should not be selecting that option, but rather depending on
> the option, right?

All users in the kernel use "select", so i don't think so. An 
interesting use that adds explicit dependencies on architectures can be
seen here [1], in the generic code. I've proposed a patch [2] that does 
a similar thing for mc-bus. I think it's a good approach as it keeps 
things under control by explicitly specifying the architectures on which
the driver was compile-tested.

---
Best Regards, Laurentiu

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/Kconfig#n28
[2] https://patchwork.kernel.org/patch/9871861/

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

[Stephen Rothwell]

Hi all,

On Tue, 1 Aug 2017 08:29:31 +0000 Laurentiu Tudor <laurentiu.tudor@nxp.com> wrote:
>
> On 07/31/2017 06:58 PM, Greg KH wrote:
> > On Mon, Jul 31, 2017 at 09:55:14AM +0000, Laurentiu Tudor wrote:  
> >> Hi Stephen,
> >>
> >> That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not
> >> all arches implement the support for the option. I can submit a patch
> >> that adds explicit dependencies on arches that it was build-tested (x86,
> >> arm, powerpc, all both 32 and 64 bits) similar to how it's done here
> >> [1]. Let me know if you're ok with this fix and i'll submit the fix to
> >> staging.  
> >
> > Ugh, you should not be selecting that option, but rather depending on
> > the option, right?  
> 
> All users in the kernel use "select", so i don't think so. An 
> interesting use that adds explicit dependencies on architectures can be
> seen here [1], in the generic code. I've proposed a patch [2] that does 
> a similar thing for mc-bus. I think it's a good approach as it keeps 
> things under control by explicitly specifying the architectures on which
> the driver was compile-tested.
> 
> ---
> Best Regards, Laurentiu
> 
> [1] 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/Kconfig#n28
> [2] https://patchwork.kernel.org/patch/9871861/

Any resolution of this?
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

[Stephen Rothwell]

Hi all,

On Mon, 7 Aug 2017 10:22:08 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Tue, 1 Aug 2017 08:29:31 +0000 Laurentiu Tudor <laurentiu.tudor@nxp.com> wrote:
> >
> > On 07/31/2017 06:58 PM, Greg KH wrote:  
> > > On Mon, Jul 31, 2017 at 09:55:14AM +0000, Laurentiu Tudor wrote:    
> > >>
> > >> That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not
> > >> all arches implement the support for the option. I can submit a patch
> > >> that adds explicit dependencies on arches that it was build-tested (x86,
> > >> arm, powerpc, all both 32 and 64 bits) similar to how it's done here
> > >> [1]. Let me know if you're ok with this fix and i'll submit the fix to
> > >> staging.    
> > >
> > > Ugh, you should not be selecting that option, but rather depending on
> > > the option, right?    
> > 
> > All users in the kernel use "select", so i don't think so. An 
> > interesting use that adds explicit dependencies on architectures can be
> > seen here [1], in the generic code. I've proposed a patch [2] that does 
> > a similar thing for mc-bus. I think it's a good approach as it keeps 
> > things under control by explicitly specifying the architectures on which
> > the driver was compile-tested.
> > 
> > ---
> > Best Regards, Laurentiu
> > 
> > [1] 
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/Kconfig#n28
> > [2] https://patchwork.kernel.org/patch/9871861/  
> 
> Any resolution of this?

Ping?
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

[Greg KH]

On Fri, Aug 11, 2017 at 09:41:09AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Mon, 7 Aug 2017 10:22:08 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Tue, 1 Aug 2017 08:29:31 +0000 Laurentiu Tudor <laurentiu.tudor@nxp.com> wrote:
> > >
> > > On 07/31/2017 06:58 PM, Greg KH wrote:  
> > > > On Mon, Jul 31, 2017 at 09:55:14AM +0000, Laurentiu Tudor wrote:    
> > > >>
> > > >> That's because the fsl-mc driver selects GENERIC_MSI_IRQ_DOMAIN and not
> > > >> all arches implement the support for the option. I can submit a patch
> > > >> that adds explicit dependencies on arches that it was build-tested (x86,
> > > >> arm, powerpc, all both 32 and 64 bits) similar to how it's done here
> > > >> [1]. Let me know if you're ok with this fix and i'll submit the fix to
> > > >> staging.    
> > > >
> > > > Ugh, you should not be selecting that option, but rather depending on
> > > > the option, right?    
> > > 
> > > All users in the kernel use "select", so i don't think so. An 
> > > interesting use that adds explicit dependencies on architectures can be
> > > seen here [1], in the generic code. I've proposed a patch [2] that does 
> > > a similar thing for mc-bus. I think it's a good approach as it keeps 
> > > things under control by explicitly specifying the architectures on which
> > > the driver was compile-tested.
> > > 
> > > ---
> > > Best Regards, Laurentiu
> > > 
> > > [1] 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/Kconfig#n28
> > > [2] https://patchwork.kernel.org/patch/9871861/  
> > 
> > Any resolution of this?
> 
> Ping?

I have a patch in my queue, somewhere, that should resolve this, I
think.  I have 600+ staging patches in my todo queue right now, that's
what I get for trying to have a vacation...

I'll get to it soon, it's not lost, thanks.

greg k-h

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

[Stephen Rothwell]

Hi Greg,

On Thu, 10 Aug 2017 16:48:42 -0700 Greg KH <gregkh@linuxfoundation.org> wrote:
>
> I have a patch in my queue, somewhere, that should resolve this, I
> think.  I have 600+ staging patches in my todo queue right now, that's
> what I get for trying to have a vacation...
> 
> I'll get to it soon, it's not lost, thanks.

No worries, just checking.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

[Greg KH]

On Fri, Aug 11, 2017 at 10:04:35AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Thu, 10 Aug 2017 16:48:42 -0700 Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > I have a patch in my queue, somewhere, that should resolve this, I
> > think.  I have 600+ staging patches in my todo queue right now, that's
> > what I get for trying to have a vacation...
> > 
> > I'll get to it soon, it's not lost, thanks.
> 
> No worries, just checking.

Ok, should now be fixed in my tree.

thanks,

greg k-h

Re: linux-next: build failure in the staging tree (Was: kisskb: FAILED linux-next/s390-allmodconfig/s390x Mon Jul 31, 17:24)

[Stephen Rothwell]

Hi Greg,

On Mon, 14 Aug 2017 15:19:29 -0700 Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Aug 11, 2017 at 10:04:35AM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > On Thu, 10 Aug 2017 16:48:42 -0700 Greg KH <gregkh@linuxfoundation.org> wrote:  
> > >
> > > I have a patch in my queue, somewhere, that should resolve this, I
> > > think.  I have 600+ staging patches in my todo queue right now, that's
> > > what I get for trying to have a vacation...
> > > 
> > > I'll get to it soon, it's not lost, thanks.  
> > 
> > No worries, just checking.  
> 
> Ok, should now be fixed in my tree.

Thank for letting me know.

-- 
Cheers,
Stephen Rothwell