* linux-next: build warning after merge of the phy-next tree
@ 2017-08-22 5:07 Stephen Rothwell
2017-08-24 5:23 ` Stephen Rothwell
0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2017-08-22 5:07 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, John Crispin,
Harvey Hunt
Hi Kishon,
After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
drivers/phy/ralink/phy-ralink-usb.c:195:13: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
phy->clk = (u32) match->data;
^
Introduced by commit
2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warning after merge of the phy-next tree
2017-08-22 5:07 linux-next: build warning after merge of the phy-next tree Stephen Rothwell
@ 2017-08-24 5:23 ` Stephen Rothwell
2017-08-24 8:01 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2017-08-24 5:23 UTC (permalink / raw)
To: Greg KH
Cc: Kishon Vijay Abraham I, Linux-Next Mailing List,
Linux Kernel Mailing List, John Crispin, Harvey Hunt
Hi Greg,
On Tue, 22 Aug 2017 15:07:33 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Kishon,
>
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
> drivers/phy/ralink/phy-ralink-usb.c:195:13: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> phy->clk = (u32) match->data;
> ^
>
> Introduced by commit
>
> 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
I now get this warning after merging the usb tree ...
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warning after merge of the phy-next tree
2017-08-24 5:23 ` Stephen Rothwell
@ 2017-08-24 8:01 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 10+ messages in thread
From: Kishon Vijay Abraham I @ 2017-08-24 8:01 UTC (permalink / raw)
To: Stephen Rothwell, Greg KH
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, John Crispin,
Harvey Hunt
Stephen,
On Thursday 24 August 2017 10:53 AM, Stephen Rothwell wrote:
> Hi Greg,
>
> On Tue, 22 Aug 2017 15:07:33 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> Hi Kishon,
>>
>> After merging the phy-next tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
>> drivers/phy/ralink/phy-ralink-usb.c:195:13: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>> phy->clk = (u32) match->data;
>> ^
>>
>> Introduced by commit
>>
>> 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
>
> I now get this warning after merging the usb tree ...
I've now sent a patch from Arnd to fix it.
Thanks
Kishon
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warning after merge of the phy-next tree
2020-01-07 5:17 Stephen Rothwell
@ 2020-01-07 5:26 ` Ramuthevar, Vadivel MuruganX
0 siblings, 0 replies; 10+ messages in thread
From: Ramuthevar, Vadivel MuruganX @ 2020-01-07 5:26 UTC (permalink / raw)
To: Stephen Rothwell, Kishon Vijay Abraham I
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andy Shevchenko
Hi,
On 7/1/2020 1:17 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the phy-next tree, today's linux-next build (86_64
> allmodconfig) produced this warning:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/intel/phy-intel-emmc.o
> see include/linux/module.h for more information
>
> Introduced by commit
>
> 95f1061f715e ("phy: intel-lgm-emmc: Add support for eMMC PHY")
sorry, will fix it and update.
Thanks!
---
Regards
Vadivel
^ permalink raw reply [flat|nested] 10+ messages in thread
* linux-next: build warning after merge of the phy-next tree
@ 2020-01-07 5:17 Stephen Rothwell
2020-01-07 5:26 ` Ramuthevar, Vadivel MuruganX
0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2020-01-07 5:17 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Ramuthevar Vadivel Murugan, Andy Shevchenko
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
Hi all,
After merging the phy-next tree, today's linux-next build (86_64
allmodconfig) produced this warning:
WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/intel/phy-intel-emmc.o
see include/linux/module.h for more information
Introduced by commit
95f1061f715e ("phy: intel-lgm-emmc: Add support for eMMC PHY")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warning after merge of the phy-next tree
2019-03-28 0:29 Stephen Rothwell
@ 2019-03-28 3:03 ` Srinath Mannam
0 siblings, 0 replies; 10+ messages in thread
From: Srinath Mannam @ 2019-03-28 3:03 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Kishon Vijay Abraham I, Linux Next Mailing List,
Linux Kernel Mailing List
Hi Stephen,
Thanks for the notice.
I sent patch to fix this warning.
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1964942.html
Regards,
Srinath.
On Thu, Mar 28, 2019 at 5:59 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Kishon,
>
> After merging the phy-next tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> In file included from include/linux/phy/phy.h:19,
> from drivers/phy/broadcom/phy-bcm-sr-usb.c:10:
> drivers/phy/broadcom/phy-bcm-sr-usb.c: In function 'bcm_usb_phy_probe':
> include/linux/device.h:1138:19: warning: 'phy_cfg' may be used uninitialized in this function [-Wmaybe-uninitialized]
> dev->driver_data = data;
> ~~~~~~~~~~~~~~~~~^~~~~~
> drivers/phy/broadcom/phy-bcm-sr-usb.c:289:26: note: 'phy_cfg' was declared here
> struct bcm_usb_phy_cfg *phy_cfg;
> ^~~~~~~
>
> Introduced by commit
>
> a3b96057577c ("phy: sr-usb: Add Stingray USB PHY driver")
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 10+ messages in thread
* linux-next: build warning after merge of the phy-next tree
@ 2019-03-28 0:29 Stephen Rothwell
2019-03-28 3:03 ` Srinath Mannam
0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2019-03-28 0:29 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Srinath Mannam
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
Hi Kishon,
After merging the phy-next tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
In file included from include/linux/phy/phy.h:19,
from drivers/phy/broadcom/phy-bcm-sr-usb.c:10:
drivers/phy/broadcom/phy-bcm-sr-usb.c: In function 'bcm_usb_phy_probe':
include/linux/device.h:1138:19: warning: 'phy_cfg' may be used uninitialized in this function [-Wmaybe-uninitialized]
dev->driver_data = data;
~~~~~~~~~~~~~~~~~^~~~~~
drivers/phy/broadcom/phy-bcm-sr-usb.c:289:26: note: 'phy_cfg' was declared here
struct bcm_usb_phy_cfg *phy_cfg;
^~~~~~~
Introduced by commit
a3b96057577c ("phy: sr-usb: Add Stingray USB PHY driver")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warning after merge of the phy-next tree
2016-11-16 13:28 ` wlf
@ 2016-11-16 16:39 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 10+ messages in thread
From: Kishon Vijay Abraham I @ 2016-11-16 16:39 UTC (permalink / raw)
To: wlf, Stephen Rothwell; +Cc: linux-next, linux-kernel
Hi,
On Wednesday 16 November 2016 06:58 PM, wlf wrote:
> Hi Stephen,
>
> 在 2016年11月16日 11:00, Stephen Rothwell 写道:
>> Hi Kishon,
>>
>> After merging the phy-next tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/phy/phy-rockchip-inno-usb2.c: In function 'rockchip_chg_detect_work':
>> drivers/phy/phy-rockchip-inno-usb2.c:717:7: warning: 'tmout' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
>> if (tmout) {
>> ^
>>
>> Introduced by commit
>>
>> 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")
Thank you for reporting this issue.
> The variable "tmout" is initialized in the prior code "case
> USB_CHG_STATE_WAIT_FOR_DCD",
> and this case will be executed before "if (tmout)", so I think it's a
> mis-warning for some
> special compiler.
>
> Could you provide me some suggestion about this warning? Should I upload a new
> patch to
> fix this compiler mis-warning or just ignore it ? :-)
Arnd has already sent a fix it. I've picked that one.
Thanks
Kishon
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: linux-next: build warning after merge of the phy-next tree
2016-11-16 3:00 Stephen Rothwell
@ 2016-11-16 13:28 ` wlf
2016-11-16 16:39 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 10+ messages in thread
From: wlf @ 2016-11-16 13:28 UTC (permalink / raw)
To: Stephen Rothwell, Kishon Vijay Abraham I; +Cc: linux-next, linux-kernel
Hi Stephen,
在 2016年11月16日 11:00, Stephen Rothwell 写道:
> Hi Kishon,
>
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/phy/phy-rockchip-inno-usb2.c: In function 'rockchip_chg_detect_work':
> drivers/phy/phy-rockchip-inno-usb2.c:717:7: warning: 'tmout' may be used uninitialized in this function [-Wmaybe-uninitialized]
> if (tmout) {
> ^
>
> Introduced by commit
>
> 0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")
The variable "tmout" is initialized in the prior code "case
USB_CHG_STATE_WAIT_FOR_DCD",
and this case will be executed before "if (tmout)", so I think it's a
mis-warning for some
special compiler.
Could you provide me some suggestion about this warning? Should I upload
a new patch to
fix this compiler mis-warning or just ignore it ? :-)
Best regards,
wulf
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* linux-next: build warning after merge of the phy-next tree
@ 2016-11-16 3:00 Stephen Rothwell
2016-11-16 13:28 ` wlf
0 siblings, 1 reply; 10+ messages in thread
From: Stephen Rothwell @ 2016-11-16 3:00 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: linux-next, linux-kernel, William Wu
Hi Kishon,
After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/phy/phy-rockchip-inno-usb2.c: In function 'rockchip_chg_detect_work':
drivers/phy/phy-rockchip-inno-usb2.c:717:7: warning: 'tmout' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (tmout) {
^
Introduced by commit
0c42fe48fd23 ("phy: rockchip-inno-usb2: support otg-port for rk3399")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-01-07 5:26 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-22 5:07 linux-next: build warning after merge of the phy-next tree Stephen Rothwell
2017-08-24 5:23 ` Stephen Rothwell
2017-08-24 8:01 ` Kishon Vijay Abraham I
-- strict thread matches above, loose matches on Subject: below --
2020-01-07 5:17 Stephen Rothwell
2020-01-07 5:26 ` Ramuthevar, Vadivel MuruganX
2019-03-28 0:29 Stephen Rothwell
2019-03-28 3:03 ` Srinath Mannam
2016-11-16 3:00 Stephen Rothwell
2016-11-16 13:28 ` wlf
2016-11-16 16:39 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).