linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Ruslan Babayev <ruslan@babayev.com>,
	Andrew de Quincey <adq_dvb@lidskialf.net>
Subject: Re: linux-next: build warning after merge of the i2c tree
Date: Wed, 12 Jun 2019 08:48:24 -0300	[thread overview]
Message-ID: <20190612084824.16671efa@coco.lan> (raw)
In-Reply-To: <20190612110904.qhuoxyljgoo76yjj@ninjato>

Em Wed, 12 Jun 2019 13:09:04 +0200
Wolfram Sang <wsa@the-dreams.de> escreveu:

> Hi Mauro,
> 
> > That entire use of _P, _R and _ri looks weird into my eyes. The code there  
> 
> Yes.
> 
> > do things like:
> > 
> > #define _P 32
> > 
> > ...
> > 
> >         if (_P == 64)
> >                 reg1[1] |= 0x40;  
> 
> Yup, I saw this, too, but didn't feel like refactoring the driver.
> Thanks for stepping up!
> 
> > I'll work on a patch to address it.  
> 
> OK, so that means I should send my pull request after yours in the next
> merge window? To avoid the build breakage?

Either that or you can apply my patch on your tree before the
patch that caused the breakage. 

Just let me know what works best for you.

> 
> Kind regards,
> 
>    Wolfram
> 



Thanks,
Mauro

  reply	other threads:[~2019-06-12 11:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11  0:25 linux-next: build warning after merge of the i2c tree Stephen Rothwell
2019-06-12  8:19 ` Wolfram Sang
2019-06-12 11:02   ` Mauro Carvalho Chehab
2019-06-12 11:09     ` Wolfram Sang
2019-06-12 11:48       ` Mauro Carvalho Chehab [this message]
2019-06-12 12:04         ` Wolfram Sang
2019-06-12 12:32           ` Mauro Carvalho Chehab
2019-06-12 13:15             ` Stephen Rothwell
2019-06-12 13:24               ` Wolfram Sang
2019-06-12 11:25   ` [PATCH] media: tua6100: Remove some ugly defines Mauro Carvalho Chehab
2019-06-12 12:01     ` Wolfram Sang
2019-06-18 21:38     ` Wolfram Sang
2019-07-08  9:25     ` Wolfram Sang
  -- strict thread matches above, loose matches on Subject: below --
2021-08-18  6:29 linux-next: build warning after merge of the i2c tree Stephen Rothwell
2021-08-18  6:54 ` Jie Deng
2021-08-18  7:04   ` Stephen Rothwell
2021-08-18  7:13     ` Jie Deng
2019-08-02  3:21 Stephen Rothwell
2019-08-02  6:04 ` Uwe Kleine-König
2017-06-05  1:11 Stephen Rothwell
2017-06-15  1:34 ` Stephen Rothwell
2017-06-15  7:02   ` Wolfram Sang
2017-06-15  8:48     ` Stephen Rothwell
2014-03-06  2:50 Stephen Rothwell
2010-03-28 23:54 Stephen Rothwell
2010-03-29 13:21 ` Jean Delvare
2010-03-29 14:12   ` Stephen Rothwell
2010-02-17  0:38 Stephen Rothwell
2010-02-17  8:34 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190612084824.16671efa@coco.lan \
    --to=mchehab@infradead.org \
    --cc=adq_dvb@lidskialf.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=ruslan@babayev.com \
    --cc=sfr@canb.auug.org.au \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).