From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Corey Minyard <cminyard@mvista.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Feng Tang <feng.tang@intel.com>
Subject: linux-next: build failure after merge of the ipmi tree
Date: Mon, 20 Apr 2020 13:09:59 +1000 [thread overview]
Message-ID: <20200420130959.489a4136@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1921 bytes --]
Hi all,
After merging the ipmi tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/char/ipmi/ipmi_msghandler.c: In function 'free_user_work':
drivers/char/ipmi/ipmi_msghandler.c:1156:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
1156 | vfree(user);
| ^~~~~
| kvfree
drivers/char/ipmi/ipmi_msghandler.c: In function 'ipmi_create_user':
drivers/char/ipmi/ipmi_msghandler.c:1188:13: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
1188 | new_user = vzalloc(sizeof(*new_user));
| ^~~~~~~
| kvzalloc
drivers/char/ipmi/ipmi_msghandler.c:1188:11: warning: assignment to 'struct ipmi_user *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1188 | new_user = vzalloc(sizeof(*new_user));
| ^
Caused by commit
d6850a47c933 ("ipmi: use vzalloc instead of kmalloc for user creation")
I have applied the following patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 20 Apr 2020 13:03:29 +1000
Subject: [PATCH] ipmi: vzalloc use requires vmallo.h inclusion
Fixes: d6850a47c933 ("ipmi: use vzalloc instead of kmalloc for user creation")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/char/ipmi/ipmi_msghandler.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 96f157323646..9afd220cd824 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -33,6 +33,7 @@
#include <linux/workqueue.h>
#include <linux/uuid.h>
#include <linux/nospec.h>
+#include <linux/vmalloc.h>
#define IPMI_DRIVER_VERSION "39.2"
--
2.25.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2020-04-20 3:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 3:09 Stephen Rothwell [this message]
2020-04-20 3:51 ` linux-next: build failure after merge of the ipmi tree Feng Tang
-- strict thread matches above, loose matches on Subject: below --
2022-11-04 1:48 Stephen Rothwell
2022-11-04 2:14 ` Corey Minyard
2021-10-01 2:52 Stephen Rothwell
2021-10-01 12:15 ` Corey Minyard
2019-04-03 3:33 Stephen Rothwell
2019-04-03 20:27 ` Corey Minyard
2019-04-03 21:12 ` Corey Minyard
2019-04-04 0:14 ` Paul E. McKenney
2017-09-28 4:45 Stephen Rothwell
2017-09-28 17:34 ` Corey Minyard
2014-12-17 3:03 Stephen Rothwell
2014-12-17 4:22 ` Corey Minyard
2014-11-17 8:20 Stephen Rothwell
2014-11-17 8:14 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420130959.489a4136@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=cminyard@mvista.com \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).