From: Corey Minyard <minyard@acm.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Corey Minyard <cminyard@mvista.com>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the ipmi tree
Date: Thu, 3 Nov 2022 21:14:41 -0500 [thread overview]
Message-ID: <Y2R1kdOS7pHaEtBV@minyard.net> (raw)
In-Reply-To: <20221104124840.51ab5b5c@canb.auug.org.au>
On Fri, Nov 04, 2022 at 12:48:40PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the ipmi tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/char/ipmi/ipmi_ssif.c: In function 'shutdown_ssif':
> drivers/char/ipmi/ipmi_ssif.c:1276:9: error: implicit declaration of function 'del_timer_shutdown'; did you mean 'device_shutdown'? [-Werror=implicit-function-declaration]
> 1276 | del_timer_shutdown(&ssif_info->watch_timer);
> | ^~~~~~~~~~~~~~~~~~
> | device_shutdown
> cc1: all warnings being treated as errors
> drivers/char/ipmi/ipmi_msghandler.c: In function 'cleanup_ipmi':
> drivers/char/ipmi/ipmi_msghandler.c:5547:17: error: implicit declaration of function 'del_timer_shutdown'; did you mean 'device_shutdown'? [-Werror=implicit-function-declaration]
> 5547 | del_timer_shutdown(&ipmi_timer);
> | ^~~~~~~~~~~~~~~~~~
> | device_shutdown
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 306ab2918b4c ("timers: ipmi: Use del_timer_shutdown() before freeing timer")
>
> I have used the ipmi tree from next-20221103 for today.
That patch shouldn't have gone it, it's fixed now.
Thanks,
-corey
next prev parent reply other threads:[~2022-11-04 2:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 1:48 linux-next: build failure after merge of the ipmi tree Stephen Rothwell
2022-11-04 2:14 ` Corey Minyard [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-01 2:52 Stephen Rothwell
2021-10-01 12:15 ` Corey Minyard
2020-04-20 3:09 Stephen Rothwell
2020-04-20 3:51 ` Feng Tang
2019-04-03 3:33 Stephen Rothwell
2019-04-03 20:27 ` Corey Minyard
2019-04-03 21:12 ` Corey Minyard
2019-04-04 0:14 ` Paul E. McKenney
2017-09-28 4:45 Stephen Rothwell
2017-09-28 17:34 ` Corey Minyard
2014-12-17 3:03 Stephen Rothwell
2014-12-17 4:22 ` Corey Minyard
2014-11-17 8:20 Stephen Rothwell
2014-11-17 8:14 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2R1kdOS7pHaEtBV@minyard.net \
--to=minyard@acm.org \
--cc=cminyard@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).