[next] WARNING: CPU: 2 PID: 66 at kernel/locking/rwsem.c:1298 __up_read

[next] WARNING: CPU: 2 PID: 66 at kernel/locking/rwsem.c:1298 __up_read

[Naresh Kamboju]

[Please ignore this email if it is already reported]

Regression found on qemu_arm64.
Following kernel warnings reported on Linux next-20211130 while booting.


metadata:
  git branch: master
  git repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
  git commit: 34f255a1e91ab44ff8926cf8294ff9144e62e861
  git describe: next-20211130
  make_kernelversion: 5.16.0-rc3
  kernel-config: https://builds.tuxbuild.com/21dB06iPvDP58giSGHdE5W3Qc68/config
  kernel-Image: https://builds.tuxbuild.com/21dB06iPvDP58giSGHdE5W3Qc68/Image.gz
  build location: https://builds.tuxbuild.com/21dB06iPvDP58giSGHdE5W3Qc68/

kernel warning:
--------------
[    0.000000] Booting Linux on physical CPU 0x0000000000 [0x000f0510]
[    0.000000] Linux version 5.16.0-rc3-next-20211130
(tuxmake@tuxmake) (aarch64-linux-gnu-gcc (Debian 11.2.0-9) 11.2.0, GNU
ld (GNU Binutils for Debian) 2.37) #1 SMP PREEMPT @1638261010
[    0.000000] Machine model: linux,dummy-virt
<trim>
[   69.203007] INFO: trying to register non-static key.
[   69.203752] The code is fine but needs lockdep annotation, or maybe
[   69.204508] you didn't initialize this object before use?
[   69.205174] turning off the locking correctness validator.
[   69.206024] CPU: 2 PID: 66 Comm: kworker/2:1H Not tainted
5.16.0-rc3-next-20211130 #1
[   69.207053] Hardware name: linux,dummy-virt (DT)
[   69.208000] Workqueue: kblockd blk_mq_run_work_fn
[   69.209944] Call trace:
[   69.210435]  dump_backtrace+0x0/0x1dc
[   69.211123]  show_stack+0x24/0x30
[   69.211698]  dump_stack_lvl+0x8c/0xb8
[   69.212296]  dump_stack+0x18/0x34
[   69.212911]  register_lock_class+0x4c8/0x4ec
[   69.213544]  __lock_acquire+0x78/0x20cc
[   69.214122]  lock_acquire.part.0+0xe0/0x230
[   69.214737]  lock_acquire+0x68/0x84
[   69.215303]  down_read+0x78/0x94
[   69.215863]  mtd_read_oob_std+0xb0/0x184
[   69.216464]  mtd_read_oob+0x8c/0x150
[   69.217043]  mtd_read+0x70/0xb0
[   69.217595]  concat_read+0xe0/0x1b4
[   69.218151]  mtd_read_oob_std+0x174/0x184
[   69.218759]  mtd_read_oob+0x8c/0x150
[   69.219336]  mtd_read+0x70/0xb0
[   69.219872]  mtdblock_readsect+0x80/0x19c
[   69.220457]  mtd_queue_rq+0x4d4/0x650
[   69.221020]  blk_mq_dispatch_rq_list+0x1b8/0x8b4
[   69.221654]  __blk_mq_do_dispatch_sched+0x270/0x300
[   69.222327]  __blk_mq_sched_dispatch_requests+0x11c/0x17c
[   69.223014]  blk_mq_sched_dispatch_requests+0x44/0x80
[   69.223684]  __blk_mq_run_hw_queue+0x70/0xcc
[   69.224309]  blk_mq_run_work_fn+0x2c/0x40
[   69.224916]  process_one_work+0x280/0x700
[   69.225522]  worker_thread+0x80/0x454
[   69.226105]  kthread+0x17c/0x190
[   69.226667]  ret_from_fork+0x10/0x20
[   69.229322] ------------[ cut here ]------------
[   69.230151] DEBUG_RWSEMS_WARN_ON(sem->magic != sem): count = 0x100,
magic = 0x0, owner = 0xffff0000c0e6e601, curr 0xffff0000c0e6e600, list
not empty
[   69.232197] WARNING: CPU: 2 PID: 66 at kernel/locking/rwsem.c:1298
__up_read+0x1e8/0x270
[   69.233176] Modules linked in:
[   69.233944] CPU: 2 PID: 66 Comm: kworker/2:1H Not tainted
5.16.0-rc3-next-20211130 #1
[   69.234814] Hardware name: linux,dummy-virt (DT)
[   69.235441] Workqueue: kblockd blk_mq_run_work_fn
[   69.236290] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[   69.237159] pc : __up_read+0x1e8/0x270
[   69.237792] lr : __up_read+0x1e8/0x270
[   69.238398] sp : ffff8000084436f0
[   69.238917] x29: ffff8000084436f0 x28: ffff0000c2c44408 x27: 0000000000040000
[   69.240164] x26: ffff8000084439f8 x25: 0000000000000000 x24: 0000000000000000
[   69.241315] x23: 0000000000000000 x22: 0000000000000000 x21: ffff800008443838
[   69.242441] x20: ffffa75da2ec4000 x19: ffff0000c2ac28b0 x18: ffffffffffffffff
[   69.243563] x17: 30322d7478656e2d x16: 3363722d302e3631 x15: ffff800088443407
[   69.244683] x14: 000000000000000f x13: 656e776f202c3078 x12: 30203d2063696761
[   69.245802] x11: ffffa75da2f49b48 x10: 00000000fffff000 x9 : ffffa75da0540b84
[   69.246974] x8 : 00000000ffffefff x7 : ffffa75da2f49b48 x6 : 0000000000000001
[   69.248078] x5 : ffffa75da2ec1000 x4 : ffffa75da2ec1440 x3 : 0000000000000000
[   69.249181] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff0000c0e6e600
[   69.250363] Call trace:
[   69.250847]  __up_read+0x1e8/0x270
[   69.251419]  up_read+0x4c/0x80
[   69.251950]  mtd_read_oob_std+0xe8/0x184
[   69.252536]  mtd_read_oob+0x8c/0x150
[   69.253099]  mtd_read+0x70/0xb0
[   69.253630]  concat_read+0xe0/0x1b4
[   69.254183]  mtd_read_oob_std+0x174/0x184
[   69.254786]  mtd_read_oob+0x8c/0x150
[   69.255350]  mtd_read+0x70/0xb0
[   69.255890]  mtdblock_readsect+0x80/0x19c
[   69.256477]  mtd_queue_rq+0x4d4/0x650
[   69.257044]  blk_mq_dispatch_rq_list+0x1b8/0x8b4
[   69.257677]  __blk_mq_do_dispatch_sched+0x270/0x300
[   69.258337]  __blk_mq_sched_dispatch_requests+0x11c/0x17c
[   69.258983]  blk_mq_sched_dispatch_requests+0x44/0x80
[   69.259634]  __blk_mq_run_hw_queue+0x70/0xcc
[   69.260254]  blk_mq_run_work_fn+0x2c/0x40
[   69.260848]  process_one_work+0x280/0x700
[   69.261447]  worker_thread+0x80/0x454
[   69.262022]  kthread+0x17c/0x190
[   69.262569]  ret_from_fork+0x10/0x20
[   69.263285] irq event stamp: 41
[   69.263815] hardirqs last  enabled at (41): [<ffffa75da18e8884>]
exit_to_kernel_mode+0x34/0x170
[   69.264778] hardirqs last disabled at (39): [<ffffa75da0410de4>]
__do_softirq+0x564/0x5f8
[   69.265691] softirqs last  enabled at (40): [<ffffa75da0410d00>]
__do_softirq+0x480/0x5f8
[   69.266539] softirqs last disabled at (35): [<ffffa75da04a6f7c>]
__irq_exit_rcu+0x17c/0x1b0
[   69.267544] ---[ end trace dce9abbec763b35e ]---


Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

link:
-----------
https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20211130/testrun/6599984/suite/linux-log-parser/test/check-kernel-warning-4048437/log

step to reproduce:
------------------
/usr/bin/qemu-system-aarch64 -cpu max -machine virt-2.10 -nographic \
 -net nic,model=virtio,macaddr=BA:DD:AD:FC:09:08 -net tap -m 4096 \
 -monitor none -kernel kernel/Image.gz \
 --append "console=ttyAMA0 root=/dev/vda rw" \
 -hda rootfs/rpb-console-image-lkft-juno-20211006155038.rootfs.ext4 \
 -m 4096 -smp 4 -nographic


--
Linaro LKFT
https://lkft.linaro.org

Re: [next] WARNING: CPU: 2 PID: 66 at kernel/locking/rwsem.c:1298 __up_read

[Anders Roxell]

On Tue, 30 Nov 2021 at 18:01, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> [Please ignore this email if it is already reported]
>
> Regression found on qemu_arm64.
> Following kernel warnings reported on Linux next-20211130 while booting.

I bisected down to 1ebe2e5f9d68 ("block: remove GENHD_FL_EXT_DEVT")

and when I reverted 1ebe2e5f9d68 ("block: remove GENHD_FL_EXT_DEVT") and the
3 releated patches so patch 1ebe2e5f9d68 was reverted cleanly I
managed to boot without
a warning.

Related patches from next-20211130:
9f18db572c97 ("block: don't set GENHD_FL_NO_PART for hidden gendisks")
430cc5d3ab4d ("block: cleanup the GENHD_FL_* definitions")
a4561f9fccc5 ("sr: set GENHD_FL_REMOVABLE earlier")

With this said, if I revert 9d6abd489e70 ("mtd: core: protect access
to MTD devices while in suspend")
I didn't see the warning either.

Any idea what can be wrong here or what a fix could be?

Only apply this patch from Geert
https://lore.kernel.org/lkml/c26dfdf9ce56e92d23530a09db386b283e62845d.1638289204.git.geert+renesas@glider.be/
makes the warning go away too.

Cheers,
Anders

Re: [next] WARNING: CPU: 2 PID: 66 at kernel/locking/rwsem.c:1298 __up_read

[Boris Brezillon]

On Thu, 2 Dec 2021 13:28:46 +0100
Anders Roxell <anders.roxell@linaro.org> wrote:

> On Tue, 30 Nov 2021 at 18:01, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
> >
> > [Please ignore this email if it is already reported]
> >
> > Regression found on qemu_arm64.
> > Following kernel warnings reported on Linux next-20211130 while booting.  
> 
> I bisected down to 1ebe2e5f9d68 ("block: remove GENHD_FL_EXT_DEVT")
> 
> and when I reverted 1ebe2e5f9d68 ("block: remove GENHD_FL_EXT_DEVT") and the
> 3 releated patches so patch 1ebe2e5f9d68 was reverted cleanly I
> managed to boot without
> a warning.
> 
> Related patches from next-20211130:
> 9f18db572c97 ("block: don't set GENHD_FL_NO_PART for hidden gendisks")
> 430cc5d3ab4d ("block: cleanup the GENHD_FL_* definitions")
> a4561f9fccc5 ("sr: set GENHD_FL_REMOVABLE earlier")
> 
> With this said, if I revert 9d6abd489e70 ("mtd: core: protect access
> to MTD devices while in suspend")
> I didn't see the warning either.

I think 9d6abd489e70 ("mtd: core: protect access to MTD devices while
in suspend") is at fault here. Miquel, would you mind
reverting/dropping the "mtd: core: protect access to mtd devices while
in  suspend" series?

> 
> Any idea what can be wrong here or what a fix could be?
> 
> Only apply this patch from Geert
> https://lore.kernel.org/lkml/c26dfdf9ce56e92d23530a09db386b283e62845d.1638289204.git.geert+renesas@glider.be/
> makes the warning go away too.
> 
> Cheers,
> Anders

Re: [next] WARNING: CPU: 2 PID: 66 at kernel/locking/rwsem.c:1298 __up_read

[Miquel Raynal]

Hello,

boris.brezillon@collabora.com wrote on Thu, 2 Dec 2021 14:19:58 +0100:

> On Thu, 2 Dec 2021 13:28:46 +0100
> Anders Roxell <anders.roxell@linaro.org> wrote:
> 
> > On Tue, 30 Nov 2021 at 18:01, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:  
> > >
> > > [Please ignore this email if it is already reported]
> > >
> > > Regression found on qemu_arm64.
> > > Following kernel warnings reported on Linux next-20211130 while booting.    
> > 
> > I bisected down to 1ebe2e5f9d68 ("block: remove GENHD_FL_EXT_DEVT")
> > 
> > and when I reverted 1ebe2e5f9d68 ("block: remove GENHD_FL_EXT_DEVT") and the
> > 3 releated patches so patch 1ebe2e5f9d68 was reverted cleanly I
> > managed to boot without
> > a warning.
> > 
> > Related patches from next-20211130:
> > 9f18db572c97 ("block: don't set GENHD_FL_NO_PART for hidden gendisks")
> > 430cc5d3ab4d ("block: cleanup the GENHD_FL_* definitions")
> > a4561f9fccc5 ("sr: set GENHD_FL_REMOVABLE earlier")
> > 
> > With this said, if I revert 9d6abd489e70 ("mtd: core: protect access
> > to MTD devices while in suspend")
> > I didn't see the warning either.  
> 
> I think 9d6abd489e70 ("mtd: core: protect access to MTD devices while
> in suspend") is at fault here. Miquel, would you mind
> reverting/dropping the "mtd: core: protect access to mtd devices while
> in  suspend" series?

FYI I've just dropped the entire series. The change will probably be
effective in linux-next starting from next Monday.

> 
> > 
> > Any idea what can be wrong here or what a fix could be?
> > 
> > Only apply this patch from Geert
> > https://lore.kernel.org/lkml/c26dfdf9ce56e92d23530a09db386b283e62845d.1638289204.git.geert+renesas@glider.be/
> > makes the warning go away too.
> > 
> > Cheers,
> > Anders  
> 


Thanks,
Miquèl