* Coverity: mt7996_rf_regval_set(): Integer handling issues
@ 2022-12-02 22:05 coverity-bot
0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2022-12-02 22:05 UTC (permalink / raw)
To: Shayne Chen
Cc: Lorenzo Bianconi, linux-wireless, Jakub Kicinski, Kalle Valo,
StanleyYP Wang, Matthias Brugger, Peter Chiu, Eric Dumazet,
Money Wang, linux-arm-kernel, netdev, Howard Hsu, linux-mediatek,
Felix Fietkau, David S. Miller, Evelyn Tsai, linux-kernel,
MeiChia Chiu, Paolo Abeni, Sean Wang, Bo Jiao, Ryder Lee,
Sujuan Chen, Gustavo A. R. Silva, linux-next, linux-hardening
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20221202 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Thu Dec 1 17:29:14 2022 +0100
98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices")
Coverity reported the following:
*** CID 1527816: Integer handling issues (INCOMPATIBLE_CAST)
drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c:657 in mt7996_rf_regval_set()
651
652 static int
653 mt7996_rf_regval_set(void *data, u64 val)
654 {
655 struct mt7996_dev *dev = data;
656
vvv CID 1527816: Integer handling issues (INCOMPATIBLE_CAST)
vvv Pointer "&val" points to an object whose effective type is "unsigned long long" (64 bits, unsigned) but is dereferenced as a narrower "unsigned int" (32 bits, unsigned). This may lead to unexpected results depending on machine endianness.
657 return mt7996_mcu_rf_regval(dev, dev->mt76.debugfs_reg, (u32 *)&val, true);
658 }
659
660 DEFINE_DEBUGFS_ATTRIBUTE(fops_rf_regval, mt7996_rf_regval_get,
661 mt7996_rf_regval_set, "0x%08llx\n");
662
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1527816 ("Integer handling issues")
Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices")
Thanks for your attention!
--
Coverity-bot
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-12-02 22:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-02 22:05 Coverity: mt7996_rf_regval_set(): Integer handling issues coverity-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).