linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: manual merge of the rpmsg tree with the spi tree
@ 2022-11-28  2:41 Stephen Rothwell
  2022-12-05 17:24 ` Mathieu Poirier
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2022-11-28  2:41 UTC (permalink / raw)
  To: Bjorn Andersson, Mathieu Poirier, Mark Brown
  Cc: Amit Kumar Mahapatra, Ben Levinsky, Linux Kernel Mailing List,
	Linux Next Mailing List, Michal Simek, Rajan Vaja, Tanmay Shah

[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]

Hi all,

Today's linux-next merge of the rpmsg tree got a conflict in:

  include/linux/firmware/xlnx-zynqmp.h

between commit:

  1e400cb9cff2 ("firmware: xilinx: Add qspi firmware interface")

from the spi tree and commit:

  b2bd0a8c3ab1 ("firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.")

from the rpmsg tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc include/linux/firmware/xlnx-zynqmp.h
index fac37680ffe7,cf92e739fa3b..000000000000
--- a/include/linux/firmware/xlnx-zynqmp.h
+++ b/include/linux/firmware/xlnx-zynqmp.h
@@@ -135,7 -138,10 +138,11 @@@ enum pm_ret_status 
  };
  
  enum pm_ioctl_id {
+ 	IOCTL_GET_RPU_OPER_MODE = 0,
+ 	IOCTL_SET_RPU_OPER_MODE = 1,
+ 	IOCTL_RPU_BOOT_ADDR_CONFIG = 2,
+ 	IOCTL_TCM_COMB_CONFIG = 3,
 +	IOCTL_SET_TAPDELAY_BYPASS = 4,
  	IOCTL_SD_DLL_RESET = 6,
  	IOCTL_SET_SD_TAPDELAY = 7,
  	IOCTL_SET_PLL_FRAC_MODE = 8,

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: manual merge of the rpmsg tree with the spi tree
  2022-11-28  2:41 linux-next: manual merge of the rpmsg tree with the spi tree Stephen Rothwell
@ 2022-12-05 17:24 ` Mathieu Poirier
  2022-12-05 19:55   ` Mark Brown
  0 siblings, 1 reply; 4+ messages in thread
From: Mathieu Poirier @ 2022-12-05 17:24 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Mark Brown, Amit Kumar Mahapatra, Ben Levinsky,
	Linux Kernel Mailing List, Linux Next Mailing List, Michal Simek,
	Rajan Vaja, Tanmay Shah, Bjorn Andersson

Hi Stephen - thanks for the legwork on this.


On Sun, 27 Nov 2022 at 19:41, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> Today's linux-next merge of the rpmsg tree got a conflict in:
>
>   include/linux/firmware/xlnx-zynqmp.h
>
> between commit:
>
>   1e400cb9cff2 ("firmware: xilinx: Add qspi firmware interface")
>

Mark - since this is in the SPI tree, can you send me a pull request
for this commit?  I will do the refactoring on my side.

Thanks,
Mathieu

> from the spi tree and commit:
>
>   b2bd0a8c3ab1 ("firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.")
>
> from the rpmsg tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> --
> Cheers,
> Stephen Rothwell
>
> diff --cc include/linux/firmware/xlnx-zynqmp.h
> index fac37680ffe7,cf92e739fa3b..000000000000
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@@ -135,7 -138,10 +138,11 @@@ enum pm_ret_status
>   };
>
>   enum pm_ioctl_id {
> +       IOCTL_GET_RPU_OPER_MODE = 0,
> +       IOCTL_SET_RPU_OPER_MODE = 1,
> +       IOCTL_RPU_BOOT_ADDR_CONFIG = 2,
> +       IOCTL_TCM_COMB_CONFIG = 3,
>  +      IOCTL_SET_TAPDELAY_BYPASS = 4,
>         IOCTL_SD_DLL_RESET = 6,
>         IOCTL_SET_SD_TAPDELAY = 7,
>         IOCTL_SET_PLL_FRAC_MODE = 8,

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: manual merge of the rpmsg tree with the spi tree
  2022-12-05 17:24 ` Mathieu Poirier
@ 2022-12-05 19:55   ` Mark Brown
  2022-12-05 21:40     ` Stephen Rothwell
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2022-12-05 19:55 UTC (permalink / raw)
  To: Mathieu Poirier
  Cc: Stephen Rothwell, Amit Kumar Mahapatra, Ben Levinsky,
	Linux Kernel Mailing List, Linux Next Mailing List, Michal Simek,
	Rajan Vaja, Tanmay Shah, Bjorn Andersson

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

On Mon, Dec 05, 2022 at 10:24:48AM -0700, Mathieu Poirier wrote:
> On Sun, 27 Nov 2022 at 19:41, Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> >   1e400cb9cff2 ("firmware: xilinx: Add qspi firmware interface")

> Mark - since this is in the SPI tree, can you send me a pull request
> for this commit?  I will do the refactoring on my side.

That would basically be the entire SPI tree up to that point since it's
all mostly on one branch...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: manual merge of the rpmsg tree with the spi tree
  2022-12-05 19:55   ` Mark Brown
@ 2022-12-05 21:40     ` Stephen Rothwell
  0 siblings, 0 replies; 4+ messages in thread
From: Stephen Rothwell @ 2022-12-05 21:40 UTC (permalink / raw)
  To: Mark Brown
  Cc: Mathieu Poirier, Amit Kumar Mahapatra, Ben Levinsky,
	Linux Kernel Mailing List, Linux Next Mailing List, Michal Simek,
	Rajan Vaja, Tanmay Shah, Bjorn Andersson

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

Hi Mark,

On Mon, 5 Dec 2022 19:55:19 +0000 Mark Brown <broonie@kernel.org> wrote:
>
> On Mon, Dec 05, 2022 at 10:24:48AM -0700, Mathieu Poirier wrote:
> > On Sun, 27 Nov 2022 at 19:41, Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> 
> > >   1e400cb9cff2 ("firmware: xilinx: Add qspi firmware interface")  
> 
> > Mark - since this is in the SPI tree, can you send me a pull request
> > for this commit?  I will do the refactoring on my side.  
> 
> That would basically be the entire SPI tree up to that point since it's
> all mostly on one branch...

Both sides just need to mention it to Linus when you send your pull
requests - it is not a problematic conflict.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-12-05 21:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-28  2:41 linux-next: manual merge of the rpmsg tree with the spi tree Stephen Rothwell
2022-12-05 17:24 ` Mathieu Poirier
2022-12-05 19:55   ` Mark Brown
2022-12-05 21:40     ` Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).