From: Qian Cai <cai@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Networking <netdev@vger.kernel.org>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the bpf-next tree
Date: Wed, 11 Nov 2020 09:03:14 -0500 [thread overview]
Message-ID: <288207f247a2e1c6c7940f87e337d3b881c7de17.camel@redhat.com> (raw)
In-Reply-To: <20201111120121.48dd970d@canb.auug.org.au>
On Wed, 2020-11-11 at 12:01 +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the bpf-next tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> kernel/bpf/btf.c:4481:20: warning: 'btf_parse_module' defined but not used [-
> Wunused-function]
> 4481 | static struct btf *btf_parse_module(const char *module_name, const
> void *data, unsigned int data_size)
> | ^~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> 36e68442d1af ("bpf: Load and verify kernel module BTFs")
>
It loos like btf_parse_module() is only used when
CONFIG_DEBUG_INFO_BTF_MODULES=y, so this should fix it.
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
index 0f1fd2669d69..e877eeebc616 100644
--- a/kernel/bpf/btf.c
+++ b/kernel/bpf/btf.c
@@ -4478,6 +4478,7 @@ struct btf *btf_parse_vmlinux(void)
return ERR_PTR(err);
}
+#ifdef CONFIG_DEBUG_INFO_BTF_MODULES
static struct btf *btf_parse_module(const char *module_name, const void *data, unsigned int data_size)
{
struct btf_verifier_env *env = NULL;
@@ -4546,6 +4547,7 @@ static struct btf *btf_parse_module(const char *module_name, const void *data, u
}
return ERR_PTR(err);
}
+#endif /* CONFIG_DEBUG_INFO_BTF_MODULES */
struct btf *bpf_prog_get_target_btf(const struct bpf_prog *prog)
{
next prev parent reply other threads:[~2020-11-11 14:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 1:01 linux-next: build warning after merge of the bpf-next tree Stephen Rothwell
2020-11-11 14:03 ` Qian Cai [this message]
2020-11-11 18:15 ` Andrii Nakryiko
-- strict thread matches above, loose matches on Subject: below --
2024-02-06 4:33 Stephen Rothwell
2023-10-13 0:40 Stephen Rothwell
2023-10-13 5:30 ` Stephen Rothwell
2023-10-13 16:54 ` Martin KaFai Lau
2023-02-15 3:45 Stephen Rothwell
2023-02-06 3:54 Stephen Rothwell
2023-02-06 3:59 ` Alexei Starovoitov
2021-12-05 23:55 Stephen Rothwell
2021-12-06 0:43 ` Stephen Rothwell
2021-12-07 3:22 ` Andrii Nakryiko
2020-07-14 2:16 Stephen Rothwell
2020-07-14 9:00 ` Jiri Olsa
2020-07-14 9:27 ` Geert Uytterhoeven
2020-07-14 10:33 ` Stephen Rothwell
2020-07-14 10:47 ` Jiri Olsa
2020-07-14 11:15 ` Jiri Olsa
2020-07-14 14:54 ` Alexei Starovoitov
2019-10-17 23:56 Stephen Rothwell
2019-10-18 5:01 ` Alexei Starovoitov
2019-10-28 0:02 ` Stephen Rothwell
2020-01-10 22:28 ` Alexandre Ghiti
2020-01-10 23:18 ` Alexei Starovoitov
2020-01-11 14:06 ` Alexandre Ghiti
2020-01-11 0:20 ` Palmer Dabbelt
2020-01-11 14:31 ` Alexandre Ghiti
2020-01-13 4:33 ` Zong Li
2020-01-14 5:23 ` Alexei Starovoitov
2020-01-15 20:48 ` Alexandre Ghiti
2019-03-24 22:28 Stephen Rothwell
2019-03-24 22:39 ` Willem de Bruijn
2018-05-09 4:49 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=288207f247a2e1c6c7940f87e337d3b881c7de17.camel@redhat.com \
--to=cai@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).