From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Networking <netdev@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Willem de Bruijn <willemb@google.com>,
David Miller <davem@davemloft.net>
Subject: Re: linux-next: build warning after merge of the bpf-next tree
Date: Sun, 24 Mar 2019 18:39:26 -0400 [thread overview]
Message-ID: <CAF=yD-JnqrLrnkF+iqQ6JGhVj-8Z5q=pDRb5aKiVeYoxUaOgAw@mail.gmail.com> (raw)
In-Reply-To: <20190325092804.650ebdb0@canb.auug.org.au>
On Sun, Mar 24, 2019 at 6:30 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the bpf-next tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> net/core/filter.c: In function 'bpf_skb_adjust_room':
> net/core/filter.c:3022:31: warning: 'inner_trans' may be used uninitialized in this function [-Wmaybe-uninitialized]
> skb->inner_transport_header = inner_trans;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
> net/core/filter.c:2979:26: note: 'inner_trans' was declared here
> u16 mac_len, inner_net, inner_trans;
> ^~~~~~~~~~~
> net/core/filter.c:3021:29: warning: 'inner_net' may be used uninitialized in this function [-Wmaybe-uninitialized]
> skb->inner_network_header = inner_net;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
> net/core/filter.c:2979:15: note: 'inner_net' was declared here
> u16 mac_len, inner_net, inner_trans;
> ^~~~~~~~~
> net/core/filter.c:3026:3: warning: 'mac_len' may be used uninitialized in this function [-Wmaybe-uninitialized]
> skb_set_network_header(skb, mac_len);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> net/core/filter.c:2979:6: note: 'mac_len' was declared here
> u16 mac_len, inner_net, inner_trans;
> ^~~~~~~
>
> Introduced by commit
>
> 868d523535c2 ("bpf: add bpf_skb_adjust_room encap flags")
>
>
> This looks like a false positive, it seems that they are only set and
> used when encap is true.
Indeed. Sorry about that.
The fix for this is now in bpf-next, commit 62b31b42cff9 ("bpf:
silence uninitialized var warning in bpf_skb_net_grow").
next prev parent reply other threads:[~2019-03-24 22:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 22:28 linux-next: build warning after merge of the bpf-next tree Stephen Rothwell
2019-03-24 22:39 ` Willem de Bruijn [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-06 4:33 Stephen Rothwell
2023-10-13 0:40 Stephen Rothwell
2023-10-13 5:30 ` Stephen Rothwell
2023-10-13 16:54 ` Martin KaFai Lau
2023-02-15 3:45 Stephen Rothwell
2023-02-06 3:54 Stephen Rothwell
2023-02-06 3:59 ` Alexei Starovoitov
2021-12-05 23:55 Stephen Rothwell
2021-12-06 0:43 ` Stephen Rothwell
2021-12-07 3:22 ` Andrii Nakryiko
2020-11-11 1:01 Stephen Rothwell
2020-11-11 14:03 ` Qian Cai
2020-11-11 18:15 ` Andrii Nakryiko
2020-07-14 2:16 Stephen Rothwell
2020-07-14 9:00 ` Jiri Olsa
2020-07-14 9:27 ` Geert Uytterhoeven
2020-07-14 10:33 ` Stephen Rothwell
2020-07-14 10:47 ` Jiri Olsa
2020-07-14 11:15 ` Jiri Olsa
2020-07-14 14:54 ` Alexei Starovoitov
2019-10-17 23:56 Stephen Rothwell
2019-10-18 5:01 ` Alexei Starovoitov
2019-10-28 0:02 ` Stephen Rothwell
2020-01-10 22:28 ` Alexandre Ghiti
2020-01-10 23:18 ` Alexei Starovoitov
2020-01-11 14:06 ` Alexandre Ghiti
2020-01-11 0:20 ` Palmer Dabbelt
2020-01-11 14:31 ` Alexandre Ghiti
2020-01-13 4:33 ` Zong Li
2020-01-14 5:23 ` Alexei Starovoitov
2020-01-15 20:48 ` Alexandre Ghiti
2018-05-09 4:49 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=yD-JnqrLrnkF+iqQ6JGhVj-8Z5q=pDRb5aKiVeYoxUaOgAw@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).