From: Jia Jie Ho <jiajie.ho@starfivetech.com>
To: Conor Dooley <conor.dooley@microchip.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Crypto List <linux-crypto@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH] crypto: starfive - Depend on AMBA_PL08X instead of selecting it
Date: Tue, 23 May 2023 15:31:13 +0800 [thread overview]
Message-ID: <33a663b7-a353-69b9-7fed-b7758cadb12b@starfivetech.com> (raw)
In-Reply-To: <20230523-pelvis-unwritten-bedc9c75d899@wendy>
On 23/5/2023 2:56 pm, Conor Dooley wrote:
> On Tue, May 23, 2023 at 10:33:38AM +0800, Herbert Xu wrote:
>> On Tue, May 23, 2023 at 10:36:37AM +1000, Stephen Rothwell wrote:
>> >
>> > That did not fix it :-(
>>
>> OK, this patch should fix it:
>>
>> ---8<---
>> A platform option like AMBA should never be selected by a driver.
>> Use a dependency instead.
>
> Randy submitted a patch to change the driver to not conflict with
> the arch symbols:
> https://lore.kernel.org/all/20230523000606.9405-1-rdunlap@infradead.org/
>
> The corresponding change here makes sense to me,
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> @StarFive folks, you will need to go and submit a patch for
> arch/riscv/Kconfig.socs that selects ARM_AMBA for your platform.
>
Sure, I'll submit a patch for this.
Thanks
Jia Jie
next prev parent reply other threads:[~2023-05-23 7:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 0:52 linux-next: build failure after merge of the crypto tree Stephen Rothwell
2023-05-22 5:15 ` Herbert Xu
2023-05-23 0:36 ` Stephen Rothwell
2023-05-23 2:33 ` [PATCH] crypto: starfive - Depend on AMBA_PL08X instead of selecting it Herbert Xu
2023-05-23 6:56 ` Conor Dooley
2023-05-23 7:31 ` Jia Jie Ho [this message]
2023-05-25 1:25 ` Stephen Rothwell
2023-06-06 9:12 ` Geert Uytterhoeven
2023-06-06 9:31 ` Herbert Xu
2023-06-06 9:34 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33a663b7-a353-69b9-7fed-b7758cadb12b@starfivetech.com \
--to=jiajie.ho@starfivetech.com \
--cc=conor.dooley@microchip.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).