From: Herbert Xu <herbert@gondor.apana.org.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Conor Dooley <conor.dooley@microchip.com>,
Linux Crypto List <linux-crypto@vger.kernel.org>,
Huan Feng <huan.feng@starfivetech.com>,
Jia Jie Ho <jiajie.ho@starfivetech.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH] crypto: starfive - Depend on AMBA_PL08X instead of selecting it
Date: Tue, 6 Jun 2023 17:31:21 +0800 [thread overview]
Message-ID: <ZH786WIea+k3S/jW@gondor.apana.org.au> (raw)
In-Reply-To: <CAMuHMdU5pBh8bk21Xrzk0Ocs7cAF+QTLn60uKOHa1z=TB6Lcuw@mail.gmail.com>
On Tue, Jun 06, 2023 at 11:12:05AM +0200, Geert Uytterhoeven wrote:
>
> > ---8<---
> > A platform option like AMBA should never be selected by a driver.
> > Use a dependency instead.
>
> FTR:
>
> arch/arm/mach-s3c/Kconfig.s3c64xx=config S3C64XX_PL080
> arch/arm/mach-s3c/Kconfig.s3c64xx- def_bool DMADEVICES
> arch/arm/mach-s3c/Kconfig.s3c64xx: select AMBA_PL08X
Well that isn't a driver I think so it might be OK?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-06-06 9:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 0:52 linux-next: build failure after merge of the crypto tree Stephen Rothwell
2023-05-22 5:15 ` Herbert Xu
2023-05-23 0:36 ` Stephen Rothwell
2023-05-23 2:33 ` [PATCH] crypto: starfive - Depend on AMBA_PL08X instead of selecting it Herbert Xu
2023-05-23 6:56 ` Conor Dooley
2023-05-23 7:31 ` Jia Jie Ho
2023-05-25 1:25 ` Stephen Rothwell
2023-06-06 9:12 ` Geert Uytterhoeven
2023-06-06 9:31 ` Herbert Xu [this message]
2023-06-06 9:34 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH786WIea+k3S/jW@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=conor.dooley@microchip.com \
--cc=geert@linux-m68k.org \
--cc=huan.feng@starfivetech.com \
--cc=jiajie.ho@starfivetech.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).