* Re: [PATCH] ARM: s3c: Fix a build error after the s3c24xx dma driver was removed
[not found] ` <b759a3e7-7a45-3dc9-14ba-8b01da798f10@linaro.org>
@ 2022-11-25 8:51 ` Uwe Kleine-König
2022-11-25 8:52 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2022-11-25 8:51 UTC (permalink / raw)
To: Krzysztof Kozlowski, Vinod Koul
Cc: Arnd Bergmann, kernel, linux-samsung-soc, Ben Dooks,
linux-kernel, Alim Akhtar, dmaengine, Simtec Linux Team,
linux-next
[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]
Hello,
On Sun, Nov 20, 2022 at 12:22:31PM +0100, Krzysztof Kozlowski wrote:
> On 20/11/2022 11:31, Krzysztof Kozlowski wrote:
> > On 18/11/2022 22:54, Uwe Kleine-König wrote:
> >> The linux/platform_data/dma-s3c24xx.h header file was removed. It didn't
> >> declare or define any symbol needed in devs.c though, so the #include
> >> can just be dropped.
> >>
> >> Fixes: cccc46ae3623 ("dmaengine: remove s3c24xx driver")
> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >> ---
> >
> > The file was not removed... or it should not have been yet. The s3c24xx
> > dma driver removal should be part of Arnd series taken via SoC ARM.
The patch enters next with the merge of
git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
Ah, the patch that became cccc46ae3623 (i.e. patch #14) is part of a
bigger series. Its patch #1 removes s3c24xx.c (which you pointed out to be still
broken) and patch #2 includes the change I suggested here.
> I think that commit should be just dropped instead.
+1
BTW, cccc46ae3623 is included in next since next-20221107 and breaks
(at least) arm/s3c2410_defconfig. So I would consider reverting
cccc46ae3623 a fix. (Added linux-next to Cc:)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: s3c: Fix a build error after the s3c24xx dma driver was removed
2022-11-25 8:51 ` [PATCH] ARM: s3c: Fix a build error after the s3c24xx dma driver was removed Uwe Kleine-König
@ 2022-11-25 8:52 ` Krzysztof Kozlowski
2022-12-02 11:20 ` Regression in dmaengine/next " Uwe Kleine-König
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-25 8:52 UTC (permalink / raw)
To: Uwe Kleine-König, Vinod Koul
Cc: Arnd Bergmann, kernel, linux-samsung-soc, Ben Dooks,
linux-kernel, Alim Akhtar, dmaengine, Simtec Linux Team,
linux-next
On 25/11/2022 09:51, Uwe Kleine-König wrote:
> Hello,
>
> On Sun, Nov 20, 2022 at 12:22:31PM +0100, Krzysztof Kozlowski wrote:
>> On 20/11/2022 11:31, Krzysztof Kozlowski wrote:
>>> On 18/11/2022 22:54, Uwe Kleine-König wrote:
>>>> The linux/platform_data/dma-s3c24xx.h header file was removed. It didn't
>>>> declare or define any symbol needed in devs.c though, so the #include
>>>> can just be dropped.
>>>>
>>>> Fixes: cccc46ae3623 ("dmaengine: remove s3c24xx driver")
>>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>>> ---
>>>
>>> The file was not removed... or it should not have been yet. The s3c24xx
>>> dma driver removal should be part of Arnd series taken via SoC ARM.
>
> The patch enters next with the merge of
>
> git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
>
> Ah, the patch that became cccc46ae3623 (i.e. patch #14) is part of a
> bigger series. Its patch #1 removes s3c24xx.c (which you pointed out to be still
> broken) and patch #2 includes the change I suggested here.
>
>> I think that commit should be just dropped instead.
>
> +1
>
> BTW, cccc46ae3623 is included in next since next-20221107 and breaks
> (at least) arm/s3c2410_defconfig. So I would consider reverting
> cccc46ae3623 a fix. (Added linux-next to Cc:)
Yes. The build failure of next was reported already by kernel test robot.
Vinod, can we drop this patch?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Regression in dmaengine/next was removed
2022-11-25 8:52 ` Krzysztof Kozlowski
@ 2022-12-02 11:20 ` Uwe Kleine-König
2022-12-02 11:42 ` Vinod Koul
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2022-12-02 11:20 UTC (permalink / raw)
To: Vinod Koul
Cc: Krzysztof Kozlowski, Arnd Bergmann, linux-samsung-soc, Ben Dooks,
linux-kernel, Simtec Linux Team, linux-next, Alim Akhtar,
dmaengine, kernel
[-- Attachment #1: Type: text/plain, Size: 1869 bytes --]
Hello,
I made the subject a bit more expressive.
On Fri, Nov 25, 2022 at 09:52:51AM +0100, Krzysztof Kozlowski wrote:
> On 25/11/2022 09:51, Uwe Kleine-König wrote:
> > On Sun, Nov 20, 2022 at 12:22:31PM +0100, Krzysztof Kozlowski wrote:
> >> On 20/11/2022 11:31, Krzysztof Kozlowski wrote:
> >>> On 18/11/2022 22:54, Uwe Kleine-König wrote:
> >>>> The linux/platform_data/dma-s3c24xx.h header file was removed. It didn't
> >>>> declare or define any symbol needed in devs.c though, so the #include
> >>>> can just be dropped.
> >>>>
> >>>> Fixes: cccc46ae3623 ("dmaengine: remove s3c24xx driver")
> >>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >>>> ---
> >>>
> >>> The file was not removed... or it should not have been yet. The s3c24xx
> >>> dma driver removal should be part of Arnd series taken via SoC ARM.
> >
> > The patch enters next with the merge of
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
> >
> > Ah, the patch that became cccc46ae3623 (i.e. patch #14) is part of a
> > bigger series. Its patch #1 removes s3c24xx.c (which you pointed out to be still
> > broken) and patch #2 includes the change I suggested here.
> >
> >> I think that commit should be just dropped instead.
> >
> > +1
> >
> > BTW, cccc46ae3623 is included in next since next-20221107 and breaks
> > (at least) arm/s3c2410_defconfig. So I would consider reverting
> > cccc46ae3623 a fix. (Added linux-next to Cc:)
>
> Yes. The build failure of next was reported already by kernel test robot.
>
> Vinod, can we drop this patch?
That patch is still contained in the next tags of this week. :-(
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Regression in dmaengine/next was removed
2022-12-02 11:20 ` Regression in dmaengine/next " Uwe Kleine-König
@ 2022-12-02 11:42 ` Vinod Koul
2022-12-05 8:56 ` Uwe Kleine-König
0 siblings, 1 reply; 5+ messages in thread
From: Vinod Koul @ 2022-12-02 11:42 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Krzysztof Kozlowski, Arnd Bergmann, linux-samsung-soc, Ben Dooks,
linux-kernel, Simtec Linux Team, linux-next, Alim Akhtar,
dmaengine, kernel
On 02-12-22, 12:20, Uwe Kleine-König wrote:
> Hello,
>
> I made the subject a bit more expressive.
>
> On Fri, Nov 25, 2022 at 09:52:51AM +0100, Krzysztof Kozlowski wrote:
> > On 25/11/2022 09:51, Uwe Kleine-König wrote:
> > > On Sun, Nov 20, 2022 at 12:22:31PM +0100, Krzysztof Kozlowski wrote:
> > >> On 20/11/2022 11:31, Krzysztof Kozlowski wrote:
> > >>> On 18/11/2022 22:54, Uwe Kleine-König wrote:
> > >>>> The linux/platform_data/dma-s3c24xx.h header file was removed. It didn't
> > >>>> declare or define any symbol needed in devs.c though, so the #include
> > >>>> can just be dropped.
> > >>>>
> > >>>> Fixes: cccc46ae3623 ("dmaengine: remove s3c24xx driver")
> > >>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > >>>> ---
> > >>>
> > >>> The file was not removed... or it should not have been yet. The s3c24xx
> > >>> dma driver removal should be part of Arnd series taken via SoC ARM.
> > >
> > > The patch enters next with the merge of
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
> > >
> > > Ah, the patch that became cccc46ae3623 (i.e. patch #14) is part of a
> > > bigger series. Its patch #1 removes s3c24xx.c (which you pointed out to be still
> > > broken) and patch #2 includes the change I suggested here.
> > >
> > >> I think that commit should be just dropped instead.
> > >
> > > +1
> > >
> > > BTW, cccc46ae3623 is included in next since next-20221107 and breaks
> > > (at least) arm/s3c2410_defconfig. So I would consider reverting
> > > cccc46ae3623 a fix. (Added linux-next to Cc:)
> >
> > Yes. The build failure of next was reported already by kernel test robot.
> >
> > Vinod, can we drop this patch?
>
> That patch is still contained in the next tags of this week. :-(
Apologies for delay, I was moving...
I have reverted and pushed now
Thanks for following up!
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Regression in dmaengine/next was removed
2022-12-02 11:42 ` Vinod Koul
@ 2022-12-05 8:56 ` Uwe Kleine-König
0 siblings, 0 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2022-12-05 8:56 UTC (permalink / raw)
To: Vinod Koul
Cc: kernel, Arnd Bergmann, linux-samsung-soc, Alim Akhtar,
linux-kernel, Krzysztof Kozlowski, linux-next, Ben Dooks,
dmaengine, Simtec Linux Team
[-- Attachment #1: Type: text/plain, Size: 2411 bytes --]
Hello Vinod,
On Fri, Dec 02, 2022 at 05:12:53PM +0530, Vinod Koul wrote:
> On 02-12-22, 12:20, Uwe Kleine-König wrote:
> > I made the subject a bit more expressive.
I wonder what I intended to write there, something like "Regression in
dmaengine/next in arm/s3c2410_defconfig", sorry to make it look as if
you already fixed the regression :-)
> > On Fri, Nov 25, 2022 at 09:52:51AM +0100, Krzysztof Kozlowski wrote:
> > > On 25/11/2022 09:51, Uwe Kleine-König wrote:
> > > > On Sun, Nov 20, 2022 at 12:22:31PM +0100, Krzysztof Kozlowski wrote:
> > > >> On 20/11/2022 11:31, Krzysztof Kozlowski wrote:
> > > >>> On 18/11/2022 22:54, Uwe Kleine-König wrote:
> > > >>>> The linux/platform_data/dma-s3c24xx.h header file was removed. It didn't
> > > >>>> declare or define any symbol needed in devs.c though, so the #include
> > > >>>> can just be dropped.
> > > >>>>
> > > >>>> Fixes: cccc46ae3623 ("dmaengine: remove s3c24xx driver")
> > > >>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > >>>> ---
> > > >>>
> > > >>> The file was not removed... or it should not have been yet. The s3c24xx
> > > >>> dma driver removal should be part of Arnd series taken via SoC ARM.
> > > >
> > > > The patch enters next with the merge of
> > > >
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
> > > >
> > > > Ah, the patch that became cccc46ae3623 (i.e. patch #14) is part of a
> > > > bigger series. Its patch #1 removes s3c24xx.c (which you pointed out to be still
> > > > broken) and patch #2 includes the change I suggested here.
> > > >
> > > >> I think that commit should be just dropped instead.
> > > >
> > > > +1
> > > >
> > > > BTW, cccc46ae3623 is included in next since next-20221107 and breaks
> > > > (at least) arm/s3c2410_defconfig. So I would consider reverting
> > > > cccc46ae3623 a fix. (Added linux-next to Cc:)
> > >
> > > Yes. The build failure of next was reported already by kernel test robot.
> > >
> > > Vinod, can we drop this patch?
> >
> > That patch is still contained in the next tags of this week. :-(
>
> Apologies for delay, I was moving...
>
> I have reverted and pushed now
Thanks!
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-05 8:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20221021203329.4143397-14-arnd@kernel.org>
[not found] ` <20221118215401.505480-1-u.kleine-koenig@pengutronix.de>
[not found] ` <f0425349-d965-0a40-0672-27dfbe45eb44@linaro.org>
[not found] ` <b759a3e7-7a45-3dc9-14ba-8b01da798f10@linaro.org>
2022-11-25 8:51 ` [PATCH] ARM: s3c: Fix a build error after the s3c24xx dma driver was removed Uwe Kleine-König
2022-11-25 8:52 ` Krzysztof Kozlowski
2022-12-02 11:20 ` Regression in dmaengine/next " Uwe Kleine-König
2022-12-02 11:42 ` Vinod Koul
2022-12-05 8:56 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).