* [PATCH -next] xtensa: Export __invalidate_icache_range
@ 2014-02-27 13:41 Geert Uytterhoeven
2014-02-27 18:40 ` Kees Cook
2014-02-27 21:52 ` Max Filippov
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-02-27 13:41 UTC (permalink / raw)
To: Chris Zankel, Max Filippov
Cc: Kees Cook, linux-xtensa, linux-next, linux-kernel, Geert Uytterhoeven
When modular code calls flush_icache_range():
ERROR: "__invalidate_icache_range" [drivers/misc/lkdtm.ko] undefined!
make[1]: *** [__modpost] Error 1
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
http://kisskb.ellerman.id.au/kisskb/buildresult/10663772/
arch/xtensa/kernel/xtensa_ksyms.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/xtensa/kernel/xtensa_ksyms.c b/arch/xtensa/kernel/xtensa_ksyms.c
index 80b33ed51f31..88eab32be29e 100644
--- a/arch/xtensa/kernel/xtensa_ksyms.c
+++ b/arch/xtensa/kernel/xtensa_ksyms.c
@@ -105,6 +105,7 @@ EXPORT_SYMBOL(csum_partial_copy_generic);
* Architecture-specific symbols
*/
EXPORT_SYMBOL(__xtensa_copy_user);
+EXPORT_SYMBOL(__invalidate_icache_range);
/*
* Kernel hacking ...
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] xtensa: Export __invalidate_icache_range
2014-02-27 13:41 [PATCH -next] xtensa: Export __invalidate_icache_range Geert Uytterhoeven
@ 2014-02-27 18:40 ` Kees Cook
2014-02-27 21:52 ` Max Filippov
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2014-02-27 18:40 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Chris Zankel, Max Filippov, linux-xtensa, Linux-Next, LKML
On Thu, Feb 27, 2014 at 5:41 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> When modular code calls flush_icache_range():
>
> ERROR: "__invalidate_icache_range" [drivers/misc/lkdtm.ko] undefined!
> make[1]: *** [__modpost] Error 1
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Ah, good catch!
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> http://kisskb.ellerman.id.au/kisskb/buildresult/10663772/
>
> arch/xtensa/kernel/xtensa_ksyms.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/xtensa/kernel/xtensa_ksyms.c b/arch/xtensa/kernel/xtensa_ksyms.c
> index 80b33ed51f31..88eab32be29e 100644
> --- a/arch/xtensa/kernel/xtensa_ksyms.c
> +++ b/arch/xtensa/kernel/xtensa_ksyms.c
> @@ -105,6 +105,7 @@ EXPORT_SYMBOL(csum_partial_copy_generic);
> * Architecture-specific symbols
> */
> EXPORT_SYMBOL(__xtensa_copy_user);
> +EXPORT_SYMBOL(__invalidate_icache_range);
>
> /*
> * Kernel hacking ...
> --
> 1.7.9.5
>
--
Kees Cook
Chrome OS Security
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] xtensa: Export __invalidate_icache_range
2014-02-27 13:41 [PATCH -next] xtensa: Export __invalidate_icache_range Geert Uytterhoeven
2014-02-27 18:40 ` Kees Cook
@ 2014-02-27 21:52 ` Max Filippov
1 sibling, 0 replies; 3+ messages in thread
From: Max Filippov @ 2014-02-27 21:52 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Chris Zankel, Kees Cook, linux-xtensa, linux-next, LKML
On Thu, Feb 27, 2014 at 5:41 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> When modular code calls flush_icache_range():
>
> ERROR: "__invalidate_icache_range" [drivers/misc/lkdtm.ko] undefined!
> make[1]: *** [__modpost] Error 1
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> http://kisskb.ellerman.id.au/kisskb/buildresult/10663772/
>
> arch/xtensa/kernel/xtensa_ksyms.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my xtensa tree.
-- Max
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-27 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-27 13:41 [PATCH -next] xtensa: Export __invalidate_icache_range Geert Uytterhoeven
2014-02-27 18:40 ` Kees Cook
2014-02-27 21:52 ` Max Filippov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).