* [PATCH] thermal: add missing HAS_IOMEM dependency for SPEAr13x thermal sensor driver
@ 2012-02-29 12:40 Heiko Carstens
2012-02-29 14:17 ` Vincenzo Frascino
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Carstens @ 2012-02-29 12:40 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-next, Heiko Carstens, Vincenzo Frascino, Viresh Kumar
Fix this build error on s390:
drivers/thermal/spear_thermal.c: In function 'thermal_get_temp':
drivers/thermal/spear_thermal.c:49:2: error:
implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
Cc: Vincenzo Frascino <vincenzo.frascino@st.com>
Cc: Viresh Kumar <viresh.kumar@st.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
drivers/thermal/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 2633fe0..06101a7 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -21,7 +21,7 @@ config THERMAL_HWMON
config SPEAR_THERMAL
bool "SPEAr thermal sensor driver"
- depends on THERMAL
+ depends on THERMAL && HAS_IOMEM
help
Enable this to plug the SPEAr thermal sensor driver into the Linux
thermal framework
--
1.7.9
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: add missing HAS_IOMEM dependency for SPEAr13x thermal sensor driver
2012-02-29 12:40 [PATCH] thermal: add missing HAS_IOMEM dependency for SPEAr13x thermal sensor driver Heiko Carstens
@ 2012-02-29 14:17 ` Vincenzo Frascino
2012-02-29 18:53 ` Paul Gortmaker
0 siblings, 1 reply; 3+ messages in thread
From: Vincenzo Frascino @ 2012-02-29 14:17 UTC (permalink / raw)
To: Heiko Carstens; +Cc: Andrew Morton, linux-next, Viresh KUMAR
Thanks Heiko,
Il 29/02/2012 13:40, Heiko Carstens ha scritto:
> Fix this build error on s390:
>
> drivers/thermal/spear_thermal.c: In function 'thermal_get_temp':
> drivers/thermal/spear_thermal.c:49:2: error:
> implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
>
> Cc: Vincenzo Frascino <vincenzo.frascino@st.com>
> Cc: Viresh Kumar <viresh.kumar@st.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> drivers/thermal/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 2633fe0..06101a7 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -21,7 +21,7 @@ config THERMAL_HWMON
>
> config SPEAR_THERMAL
> bool "SPEAr thermal sensor driver"
> - depends on THERMAL
> + depends on THERMAL && HAS_IOMEM
> help
> Enable this to plug the SPEAr thermal sensor driver into the Linux
> thermal framework
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@st.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: add missing HAS_IOMEM dependency for SPEAr13x thermal sensor driver
2012-02-29 14:17 ` Vincenzo Frascino
@ 2012-02-29 18:53 ` Paul Gortmaker
0 siblings, 0 replies; 3+ messages in thread
From: Paul Gortmaker @ 2012-02-29 18:53 UTC (permalink / raw)
To: Vincenzo Frascino; +Cc: Heiko Carstens, Andrew Morton, linux-next, Viresh KUMAR
On Wed, Feb 29, 2012 at 9:17 AM, Vincenzo Frascino
<vincenzo.frascino@st.com> wrote:
> Thanks Heiko,
>
> Il 29/02/2012 13:40, Heiko Carstens ha scritto:
>> Fix this build error on s390:
>>
>> drivers/thermal/spear_thermal.c: In function 'thermal_get_temp':
>> drivers/thermal/spear_thermal.c:49:2: error:
>> implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
>>
>> Cc: Vincenzo Frascino <vincenzo.frascino@st.com>
>> Cc: Viresh Kumar <viresh.kumar@st.com>
>> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>> ---
>> drivers/thermal/Kconfig | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index 2633fe0..06101a7 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -21,7 +21,7 @@ config THERMAL_HWMON
>>
>> config SPEAR_THERMAL
>> bool "SPEAr thermal sensor driver"
>> - depends on THERMAL
>> + depends on THERMAL && HAS_IOMEM
No, we dont need this. The better patch was already posted:
https://lkml.org/lkml/2012/2/26/155
I've tested the above "depends on PLAT_SPEAR" patch and
confirmed it fixes the s390 build failures that just appeared in
linux-next. This is the patch we need in the akpm queue.
Thanks,
Paul.
--
>> help
>> Enable this to plug the SPEAr thermal sensor driver into the Linux
>> thermal framework
> Reviewed-by: Vincenzo Frascino <vincenzo.frascino@st.com>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-29 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-29 12:40 [PATCH] thermal: add missing HAS_IOMEM dependency for SPEAr13x thermal sensor driver Heiko Carstens
2012-02-29 14:17 ` Vincenzo Frascino
2012-02-29 18:53 ` Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).