linux-next: build failure after merge of the chrome-platform tree

linux-next: build failure after merge of the chrome-platform tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

Hi all,

After merging the chrome-platform tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: "emergency_sync" [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!

Caused by commit

  a6edd5f5d9cc ("platform/chrome: cros_ec_lpc: Emergency sync filesystem on EC panic")

I have used the chrome-platform tree from next-20230719 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the chrome-platform tree

[Tzung-Bi Shih]

On Thu, Jul 20, 2023 at 12:46:11PM +1000, Stephen Rothwell wrote:
> After merging the chrome-platform tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: modpost: "emergency_sync" [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!
> 
> Caused by commit
> 
>   a6edd5f5d9cc ("platform/chrome: cros_ec_lpc: Emergency sync filesystem on EC panic")
> 
> I have used the chrome-platform tree from next-20230719 for today.

Thanks for reporting.  I have dropped the commit from chrome-platform for-next
branch until a fix is seen.

Re: linux-next: build failure after merge of the chrome-platform tree

[Tzung-Bi Shih]

On Thu, Jul 20, 2023 at 12:46:11PM +1000, Stephen Rothwell wrote:
> After merging the chrome-platform tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: modpost: "emergency_sync" [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!
> 
> Caused by commit
> 
>   a6edd5f5d9cc ("platform/chrome: cros_ec_lpc: Emergency sync filesystem on EC panic")
> 
> I have used the chrome-platform tree from next-20230719 for today.

Thanks for reporting.  I have dropped the commit from chrome-platform for-next
branch.

Re: linux-next: build failure after merge of the chrome-platform tree

[Rob Barnes]

The patch to fix this issue was submitted here:
https://lore.kernel.org/lkml/221b9a4a-275f-80a4-bba6-fb13a3beec0a@roeck-us.net/T/

However, it's looking unlikely that it will be accepted. So I think we
should revert a6edd5f5d9cc for now. Let me know if I need to submit a
revert patch?

On Wed, Jul 19, 2023 at 11:00 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> On Thu, Jul 20, 2023 at 12:46:11PM +1000, Stephen Rothwell wrote:
> > After merging the chrome-platform tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > ERROR: modpost: "emergency_sync" [drivers/platform/chrome/cros_ec_lpcs.ko] undefined!
> >
> > Caused by commit
> >
> >   a6edd5f5d9cc ("platform/chrome: cros_ec_lpc: Emergency sync filesystem on EC panic")
> >
> > I have used the chrome-platform tree from next-20230719 for today.
>
> Thanks for reporting.  I have dropped the commit from chrome-platform for-next
> branch.

Re: linux-next: build failure after merge of the chrome-platform tree

[Tzung-Bi Shih]

On Thu, Jul 20, 2023 at 09:32:11AM -0600, Rob Barnes wrote:
> The patch to fix this issue was submitted here:
> https://lore.kernel.org/lkml/221b9a4a-275f-80a4-bba6-fb13a3beec0a@roeck-us.net/T/
> 
> However, it's looking unlikely that it will be accepted. So I think we
> should revert a6edd5f5d9cc for now. Let me know if I need to submit a
> revert patch?

No, you don't need to send a revert patch.  I'll remove it from the queue
if the symbol can't get exported for now.

Re: linux-next: build failure after merge of the chrome-platform tree

[Stephen Rothwell]

Hi Olof,

On Thu, 8 Oct 2015 16:43:55 -0700 Olof Johansson <olof@lixom.net> wrote:
>
> Yeah, sorry about that. I got notified by the 0-day builder but by the
> time I had sorted it out you must already have pulled the tree.
> 
> Should be fine today.

Yeah, I saw that, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build failure after merge of the chrome-platform tree

[Olof Johansson]

Stephen,

On Wed, Oct 7, 2015 at 7:34 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Olof,
>
> After merging the chrome-platform tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/platform/chrome/cros_ec_vbc.c:136:2: error: unknown field 'is_bin_visible' specified in initializer
>   .is_bin_visible = cros_ec_vbc_is_visible,
>   ^
>
> Caused by commit
>
>   01e7e432df74 ("platform/chrome: Support reading/writing the vboot context")
>
> I have used the chrome-platform tree from next-20151007 for today.

Yeah, sorry about that. I got notified by the 0-day builder but by the
time I had sorted it out you must already have pulled the tree.

Should be fine today.


-Olof

linux-next: build failure after merge of the chrome-platform tree

[Stephen Rothwell]

Hi Olof,

After merging the chrome-platform tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/platform/chrome/cros_ec_vbc.c:136:2: error: unknown field 'is_bin_visible' specified in initializer
  .is_bin_visible = cros_ec_vbc_is_visible,
  ^

Caused by commit

  01e7e432df74 ("platform/chrome: Support reading/writing the vboot context")

I have used the chrome-platform tree from next-20151007 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au