* [PATCH nfs-utils] nfsd: clean up option parsing
@ 2020-12-09 12:06 Ulrich Ölmann
2020-12-16 14:28 ` Ulrich Ölmann
0 siblings, 1 reply; 3+ messages in thread
From: Ulrich Ölmann @ 2020-12-09 12:06 UTC (permalink / raw)
To: linux-nfs; +Cc: Ulrich Ölmann
Presumably by mistake in commit [1] the unknown option 'i' slipped in together
with a duplicated 't', so remove them from the optstring.
[1] fbd7623dd8d5 ("nfsd: don't enable a UDP socket by default")
Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
---
utils/nfsd/nfsd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c
index a412a026c6c5..c9f0385b5a00 100644
--- a/utils/nfsd/nfsd.c
+++ b/utils/nfsd/nfsd.c
@@ -162,7 +162,7 @@ main(int argc, char **argv)
}
}
- while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTituUrG:L:", longopts, NULL)) != EOF) {
+ while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTuUrG:L:", longopts, NULL)) != EOF) {
switch(c) {
case 'd':
xlog_config(D_ALL, 1);
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH nfs-utils] nfsd: clean up option parsing
2020-12-09 12:06 [PATCH nfs-utils] nfsd: clean up option parsing Ulrich Ölmann
@ 2020-12-16 14:28 ` Ulrich Ölmann
2020-12-16 16:14 ` Steve Dickson
0 siblings, 1 reply; 3+ messages in thread
From: Ulrich Ölmann @ 2020-12-16 14:28 UTC (permalink / raw)
To: linux-nfs; +Cc: Jeff Layton, Steve Dickson, Ulrich Ölmann
Gentle ping!
(And putting Jeff & Steve on CC).
On Wed, Dec 09 2020 at 13:06 +0100, Ulrich Ölmann <u.oelmann@pengutronix.de> wrote:
> Presumably by mistake in commit [1] the unknown option 'i' slipped in together
> with a duplicated 't', so remove them from the optstring.
>
> [1] fbd7623dd8d5 ("nfsd: don't enable a UDP socket by default")
>
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
> utils/nfsd/nfsd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c
> index a412a026c6c5..c9f0385b5a00 100644
> --- a/utils/nfsd/nfsd.c
> +++ b/utils/nfsd/nfsd.c
> @@ -162,7 +162,7 @@ main(int argc, char **argv)
> }
> }
>
> - while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTituUrG:L:", longopts, NULL)) != EOF) {
> + while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTuUrG:L:", longopts, NULL)) != EOF) {
> switch(c) {
> case 'd':
> xlog_config(D_ALL, 1);
--
Pengutronix e.K. | Ulrich Ölmann |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH nfs-utils] nfsd: clean up option parsing
2020-12-16 14:28 ` Ulrich Ölmann
@ 2020-12-16 16:14 ` Steve Dickson
0 siblings, 0 replies; 3+ messages in thread
From: Steve Dickson @ 2020-12-16 16:14 UTC (permalink / raw)
To: Ulrich Ölmann, linux-nfs; +Cc: Jeff Layton
On 12/16/20 9:28 AM, Ulrich Ölmann wrote:
> Gentle ping!
> (And putting Jeff & Steve on CC).
Sorry for the delay... Trying to burn some PTO before EOY...
>
> On Wed, Dec 09 2020 at 13:06 +0100, Ulrich Ölmann <u.oelmann@pengutronix.de> wrote:
>> Presumably by mistake in commit [1] the unknown option 'i' slipped in together
>> with a duplicated 't', so remove them from the optstring.
>>
>> [1] fbd7623dd8d5 ("nfsd: don't enable a UDP socket by default")
>>
>> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Committed!
steved.
>> ---
>> utils/nfsd/nfsd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c
>> index a412a026c6c5..c9f0385b5a00 100644
>> --- a/utils/nfsd/nfsd.c
>> +++ b/utils/nfsd/nfsd.c
>> @@ -162,7 +162,7 @@ main(int argc, char **argv)
>> }
>> }
>>
>> - while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTituUrG:L:", longopts, NULL)) != EOF) {
>> + while ((c = getopt_long(argc, argv, "dH:hN:V:p:P:stTuUrG:L:", longopts, NULL)) != EOF) {
>> switch(c) {
>> case 'd':
>> xlog_config(D_ALL, 1);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-16 16:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 12:06 [PATCH nfs-utils] nfsd: clean up option parsing Ulrich Ölmann
2020-12-16 14:28 ` Ulrich Ölmann
2020-12-16 16:14 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).