* [PATCH] nfsd: v4 support requires CRYPTO_SHA256
@ 2019-11-12 19:01 Scott Mayhew
2019-11-12 19:07 ` Chuck Lever
2019-11-12 20:00 ` J. Bruce Fields
0 siblings, 2 replies; 3+ messages in thread
From: Scott Mayhew @ 2019-11-12 19:01 UTC (permalink / raw)
To: bfields, chuck.lever; +Cc: jamie, linux-nfs
The new nfsdcld client tracking operations use sha256 to compute hashes
of the kerberos principals, so make sure CRYPTO_SHA256 is enabled.
Fixes: 6ee95d1c8991 ("nfsd: add support for upcall version 2")
Reported-by: Jamie Heilman <jamie@audible.transient.net>
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
fs/nfsd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
index 10cefb0c07c7..c4b1a89b8845 100644
--- a/fs/nfsd/Kconfig
+++ b/fs/nfsd/Kconfig
@@ -73,7 +73,7 @@ config NFSD_V4
select NFSD_V3
select FS_POSIX_ACL
select SUNRPC_GSS
- select CRYPTO
+ select CRYPTO_SHA256
select GRACE_PERIOD
help
This option enables support in your system's NFS server for
--
2.17.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nfsd: v4 support requires CRYPTO_SHA256
2019-11-12 19:01 [PATCH] nfsd: v4 support requires CRYPTO_SHA256 Scott Mayhew
@ 2019-11-12 19:07 ` Chuck Lever
2019-11-12 20:00 ` J. Bruce Fields
1 sibling, 0 replies; 3+ messages in thread
From: Chuck Lever @ 2019-11-12 19:07 UTC (permalink / raw)
To: Scott Mayhew; +Cc: Bruce Fields, jamie, Linux NFS Mailing List
> On Nov 12, 2019, at 2:01 PM, Scott Mayhew <smayhew@redhat.com> wrote:
>
> The new nfsdcld client tracking operations use sha256 to compute hashes
> of the kerberos principals, so make sure CRYPTO_SHA256 is enabled.
>
> Fixes: 6ee95d1c8991 ("nfsd: add support for upcall version 2")
> Reported-by: Jamie Heilman <jamie@audible.transient.net>
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
I recently noticed this too in passing. I didn't have a chance to
give a thought about exactly how to address it, but this looks OK
to me.
> ---
> fs/nfsd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
> index 10cefb0c07c7..c4b1a89b8845 100644
> --- a/fs/nfsd/Kconfig
> +++ b/fs/nfsd/Kconfig
> @@ -73,7 +73,7 @@ config NFSD_V4
> select NFSD_V3
> select FS_POSIX_ACL
> select SUNRPC_GSS
> - select CRYPTO
> + select CRYPTO_SHA256
> select GRACE_PERIOD
> help
> This option enables support in your system's NFS server for
> --
> 2.17.2
>
--
Chuck Lever
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nfsd: v4 support requires CRYPTO_SHA256
2019-11-12 19:01 [PATCH] nfsd: v4 support requires CRYPTO_SHA256 Scott Mayhew
2019-11-12 19:07 ` Chuck Lever
@ 2019-11-12 20:00 ` J. Bruce Fields
1 sibling, 0 replies; 3+ messages in thread
From: J. Bruce Fields @ 2019-11-12 20:00 UTC (permalink / raw)
To: Scott Mayhew; +Cc: chuck.lever, jamie, linux-nfs
Thanks, applied.--b.
On Tue, Nov 12, 2019 at 02:01:55PM -0500, Scott Mayhew wrote:
> The new nfsdcld client tracking operations use sha256 to compute hashes
> of the kerberos principals, so make sure CRYPTO_SHA256 is enabled.
>
> Fixes: 6ee95d1c8991 ("nfsd: add support for upcall version 2")
> Reported-by: Jamie Heilman <jamie@audible.transient.net>
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
> ---
> fs/nfsd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
> index 10cefb0c07c7..c4b1a89b8845 100644
> --- a/fs/nfsd/Kconfig
> +++ b/fs/nfsd/Kconfig
> @@ -73,7 +73,7 @@ config NFSD_V4
> select NFSD_V3
> select FS_POSIX_ACL
> select SUNRPC_GSS
> - select CRYPTO
> + select CRYPTO_SHA256
> select GRACE_PERIOD
> help
> This option enables support in your system's NFS server for
> --
> 2.17.2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-12 20:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 19:01 [PATCH] nfsd: v4 support requires CRYPTO_SHA256 Scott Mayhew
2019-11-12 19:07 ` Chuck Lever
2019-11-12 20:00 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).