From: Ira Weiny <ira.weiny@intel.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-nvdimm@lists.01.org
Subject: Re: [ndctl patch 4/4] load-keys: get rid of duplicate assignment
Date: Fri, 18 Oct 2019 13:57:05 -0700 [thread overview]
Message-ID: <20191018205705.GD12760@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20191018202302.8122-5-jmoyer@redhat.com>
On Fri, Oct 18, 2019 at 04:23:02PM -0400, Jeff Moyer wrote:
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> ndctl/load-keys.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ndctl/load-keys.c b/ndctl/load-keys.c
> index 981f80f..f0b7a5a 100644
> --- a/ndctl/load-keys.c
> +++ b/ndctl/load-keys.c
> @@ -185,7 +185,6 @@ static int load_keys(struct loadkeys *lk_ctx, const char *keypath,
>
> rc = chdir(keypath);
> if (rc < 0) {
> - rc = -errno;
> fprintf(stderr, "Change current work dir to %s failed: %s\n",
> param.key_path, strerror(errno));
> rc = -errno;
> --
> 2.19.1
> _______________________________________________
> Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
> To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
prev parent reply other threads:[~2019-10-18 20:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 20:22 [ndctl patch 0/4] misc. cleanups Jeff Moyer
2019-10-18 20:22 ` [ndctl patch 1/4] util/abspath: cleanup prefix_filename Jeff Moyer
2019-10-18 20:55 ` Ira Weiny
2019-10-18 20:23 ` [ndctl patch 2/4] fix building of tags tables Jeff Moyer
2019-10-18 20:56 ` Ira Weiny
2019-10-18 20:23 ` [ndctl patch 3/4] query_fw_finish_status: get rid of redundant variable Jeff Moyer
2019-10-18 20:54 ` Ira Weiny
2019-10-18 21:06 ` Jeff Moyer
2019-10-18 22:49 ` Ira Weiny
2019-10-21 17:11 ` Verma, Vishal L
2019-10-23 22:28 ` Verma, Vishal L
2019-10-23 22:51 ` Verma, Vishal L
2019-10-25 22:21 ` Ira Weiny
2019-10-25 23:51 ` Verma, Vishal L
2019-10-28 19:37 ` Jeff Moyer
2019-10-28 21:13 ` Ira Weiny
2019-10-28 21:28 ` Jeff Moyer
2019-10-28 22:12 ` Jeff Moyer
2019-10-29 16:15 ` Ira Weiny
2019-10-18 20:23 ` [ndctl patch 4/4] load-keys: get rid of duplicate assignment Jeff Moyer
2019-10-18 20:57 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018205705.GD12760@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=jmoyer@redhat.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).