From: Jeff Moyer <jmoyer@redhat.com>
To: Ira Weiny <ira.weiny@intel.com>
Cc: linux-nvdimm@lists.01.org
Subject: Re: [ndctl patch 3/4] query_fw_finish_status: get rid of redundant variable
Date: Fri, 18 Oct 2019 17:06:10 -0400 [thread overview]
Message-ID: <x49sgnp7ohp.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20191018205424.GA12760@iweiny-DESK2.sc.intel.com> (Ira Weiny's message of "Fri, 18 Oct 2019 13:54:25 -0700")
Ira Weiny <ira.weiny@intel.com> writes:
> On Fri, Oct 18, 2019 at 04:23:01PM -0400, Jeff Moyer wrote:
>> The 'done' variable only adds confusion.
>>
>> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
>> ---
>> ndctl/dimm.c | 7 +------
>> 1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/ndctl/dimm.c b/ndctl/dimm.c
>> index c8821d6..f28b9c1 100644
>> --- a/ndctl/dimm.c
>> +++ b/ndctl/dimm.c
>> @@ -682,7 +682,6 @@ static int query_fw_finish_status(struct ndctl_dimm *dimm,
>> struct ndctl_cmd *cmd;
>> int rc;
>> enum ND_FW_STATUS status;
>> - bool done = false;
>> struct timespec now, before, after;
>> uint64_t ver;
>>
>> @@ -716,7 +715,6 @@ static int query_fw_finish_status(struct ndctl_dimm *dimm,
>> ndctl_dimm_get_devname(dimm));
>> printf("Firmware version %#lx.\n", ver);
>> printf("Cold reboot to activate.\n");
>> - done = true;
>> rc = 0;
>
> Do we need "goto out" here?
Yes, I missed that one. Thanks.
>> break;
>> case FW_EBUSY:
>> @@ -753,7 +751,6 @@ static int query_fw_finish_status(struct ndctl_dimm *dimm,
>> ndctl_dimm_get_devname(dimm));
>> case FW_EINVAL_CTX:
>> case FW_ESEQUENCE:
>> - done = true;
>> rc = -ENXIO;
>> goto out;
>> case FW_ENORES:
>> @@ -761,17 +758,15 @@ static int query_fw_finish_status(struct ndctl_dimm *dimm,
>> "Firmware update sequence timed out: %s\n",
>> ndctl_dimm_get_devname(dimm));
>> rc = -ETIMEDOUT;
>> - done = true;
>> goto out;
>> default:
>> fprintf(stderr,
>> "Unknown update status: %#x on DIMM %s\n",
>> status, ndctl_dimm_get_devname(dimm));
>> rc = -EINVAL;
>> - done = true;
>> goto out;
>> }
>> - } while (!done);
>> + } while (true);
>
> I'm not a fan of "while (true)". But I'm not the maintainer. The Logic seems
> fine otherwise.
The way things stand today is a mashup of goto vs. break. I'll
follow-up with fixed up patch next week if there is consensus on the
change. If you have a suggestion for a better way, that's welcome as
well.
Thanks for looking, Ira!
-Jeff
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2019-10-18 21:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 20:22 [ndctl patch 0/4] misc. cleanups Jeff Moyer
2019-10-18 20:22 ` [ndctl patch 1/4] util/abspath: cleanup prefix_filename Jeff Moyer
2019-10-18 20:55 ` Ira Weiny
2019-10-18 20:23 ` [ndctl patch 2/4] fix building of tags tables Jeff Moyer
2019-10-18 20:56 ` Ira Weiny
2019-10-18 20:23 ` [ndctl patch 3/4] query_fw_finish_status: get rid of redundant variable Jeff Moyer
2019-10-18 20:54 ` Ira Weiny
2019-10-18 21:06 ` Jeff Moyer [this message]
2019-10-18 22:49 ` Ira Weiny
2019-10-21 17:11 ` Verma, Vishal L
2019-10-23 22:28 ` Verma, Vishal L
2019-10-23 22:51 ` Verma, Vishal L
2019-10-25 22:21 ` Ira Weiny
2019-10-25 23:51 ` Verma, Vishal L
2019-10-28 19:37 ` Jeff Moyer
2019-10-28 21:13 ` Ira Weiny
2019-10-28 21:28 ` Jeff Moyer
2019-10-28 22:12 ` Jeff Moyer
2019-10-29 16:15 ` Ira Weiny
2019-10-18 20:23 ` [ndctl patch 4/4] load-keys: get rid of duplicate assignment Jeff Moyer
2019-10-18 20:57 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49sgnp7ohp.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=ira.weiny@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).