linux-nvme.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] nvme: delete an unnecessary declaration
@ 2020-05-15 12:06 Dan Carpenter
  2020-05-16  4:30 ` Chaitanya Kulkarni
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-05-15 12:06 UTC (permalink / raw)
  To: Keith Busch
  Cc: Jens Axboe, kernel-janitors, Christoph Hellwig, linux-nvme,
	Sagi Grimberg

The nvme_put_ctrl() is implemented earlier as an inline function so
this declaration isn't required.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/nvme/host/nvme.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index f3ab17778349..86f152e777bc 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -497,7 +497,6 @@ int nvme_init_ctrl(struct nvme_ctrl *ctrl, struct device *dev,
 void nvme_uninit_ctrl(struct nvme_ctrl *ctrl);
 void nvme_start_ctrl(struct nvme_ctrl *ctrl);
 void nvme_stop_ctrl(struct nvme_ctrl *ctrl);
-void nvme_put_ctrl(struct nvme_ctrl *ctrl);
 int nvme_init_identify(struct nvme_ctrl *ctrl);
 
 void nvme_remove_namespaces(struct nvme_ctrl *ctrl);
-- 
2.26.2


_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvme: delete an unnecessary declaration
  2020-05-15 12:06 [PATCH] nvme: delete an unnecessary declaration Dan Carpenter
@ 2020-05-16  4:30 ` Chaitanya Kulkarni
  2020-05-16  6:22 ` Sagi Grimberg
  2020-05-20 17:12 ` Christoph Hellwig
  2 siblings, 0 replies; 4+ messages in thread
From: Chaitanya Kulkarni @ 2020-05-16  4:30 UTC (permalink / raw)
  To: Dan Carpenter, Keith Busch
  Cc: Jens Axboe, kernel-janitors, Christoph Hellwig, linux-nvme,
	Sagi Grimberg

On 05/15/2020 05:07 AM, Dan Carpenter wrote:
> The nvme_put_ctrl() is implemented earlier as an inline function so
> this declaration isn't required.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvme: delete an unnecessary declaration
  2020-05-15 12:06 [PATCH] nvme: delete an unnecessary declaration Dan Carpenter
  2020-05-16  4:30 ` Chaitanya Kulkarni
@ 2020-05-16  6:22 ` Sagi Grimberg
  2020-05-20 17:12 ` Christoph Hellwig
  2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2020-05-16  6:22 UTC (permalink / raw)
  To: Dan Carpenter, Keith Busch
  Cc: Jens Axboe, kernel-janitors, Christoph Hellwig, linux-nvme

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvme: delete an unnecessary declaration
  2020-05-15 12:06 [PATCH] nvme: delete an unnecessary declaration Dan Carpenter
  2020-05-16  4:30 ` Chaitanya Kulkarni
  2020-05-16  6:22 ` Sagi Grimberg
@ 2020-05-20 17:12 ` Christoph Hellwig
  2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2020-05-20 17:12 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Sagi Grimberg, kernel-janitors, linux-nvme, Jens Axboe,
	Keith Busch, Christoph Hellwig

Thanks,

applied to nvme-5.8.

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-20 17:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-15 12:06 [PATCH] nvme: delete an unnecessary declaration Dan Carpenter
2020-05-16  4:30 ` Chaitanya Kulkarni
2020-05-16  6:22 ` Sagi Grimberg
2020-05-20 17:12 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).