From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Alan Adamson <alan.adamson@oracle.com>,
Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"axboe@fb.com" <axboe@fb.com>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH 0/1] nvme: Export CSTS register via sysfs
Date: Fri, 19 Mar 2021 07:51:58 +0100 [thread overview]
Message-ID: <20210319065158.GA11263@lst.de> (raw)
In-Reply-To: <20210318194653.GA2690@dhcp-10-100-145-180.wdc.com>
On Thu, Mar 18, 2021 at 12:46:53PM -0700, Keith Busch wrote:
> I don't think it should require user space modifications. Just mmap the
> current resource as-is but let the driver allow read-only in the
> precense of CONFIG_IO_STRICT_DEVMEM. The below is a rough idea of what I
> had in mind (compile tested only, and a proper solution should restrict
> access to a specific address range)
I think this is a horrible idea. Userspace has no business touching
registers even read-only. MMIO reads can have side effects as well,
intentional or unintentional, and we also open up a whole can of worms
of mismatched memory attributes.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-19 6:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 20:46 [PATCH 0/1] nvme: Export CSTS register via sysfs Alan Adamson
2021-03-17 20:46 ` [PATCH 1/1] " Alan Adamson
2021-03-18 1:06 ` [PATCH 0/1] " Chaitanya Kulkarni
2021-03-18 4:38 ` Christoph Hellwig
2021-03-18 14:19 ` Keith Busch
2021-03-18 16:28 ` Alan Adamson
2021-03-18 16:52 ` Keith Busch
2021-03-18 18:39 ` Alan Adamson
2021-03-18 19:46 ` Keith Busch
2021-03-19 6:51 ` Christoph Hellwig [this message]
2021-03-19 15:22 ` Keith Busch
2021-03-19 15:30 ` Christoph Hellwig
2021-03-19 17:21 ` Alan Adamson
2021-03-19 17:30 ` Keith Busch
2021-03-19 17:33 ` Alan Adamson
2021-05-05 18:40 ` Alan Adamson
2021-05-05 20:11 ` Keith Busch
2021-05-05 20:23 ` Alan Adamson
2021-05-05 20:35 ` Keith Busch
2021-03-18 19:15 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319065158.GA11263@lst.de \
--to=hch@lst.de \
--cc=alan.adamson@oracle.com \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).