From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Keith Busch <kbusch@kernel.org>, Alan Adamson <alan.adamson@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"axboe@fb.com" <axboe@fb.com>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH 0/1] nvme: Export CSTS register via sysfs
Date: Thu, 18 Mar 2021 19:15:41 +0000 [thread overview]
Message-ID: <BYAPR04MB496524879B3C3A1D9F644BAF86699@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210318165213.GA31675@redsun51.ssa.fujisawa.hgst.com
On 3/18/21 09:59, Keith Busch wrote:
>>> So what is this application doings with it? Should we just have a
>>> ready attribute instead of exporting a raw register encoding?
>> Was using nvme-cli show-regs to manage nvme devices. This is no longer an option.
> Most distributions ship with kernel CONFIG_IO_STRICT_DEVMEM these days,
> so that user command will very rarely work on PCIe targets anymore.
>
> Perhaps we could introduce a driver option allowing read-only mmap on
> this memory? While you're currently asking for just one register
> attribute, it would be nice if we can make all future requests available
> without piling on more sysfs properties.
This will also avoid further code changes seems very generic to me.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2021-03-18 19:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 20:46 [PATCH 0/1] nvme: Export CSTS register via sysfs Alan Adamson
2021-03-17 20:46 ` [PATCH 1/1] " Alan Adamson
2021-03-18 1:06 ` [PATCH 0/1] " Chaitanya Kulkarni
2021-03-18 4:38 ` Christoph Hellwig
2021-03-18 14:19 ` Keith Busch
2021-03-18 16:28 ` Alan Adamson
2021-03-18 16:52 ` Keith Busch
2021-03-18 18:39 ` Alan Adamson
2021-03-18 19:46 ` Keith Busch
2021-03-19 6:51 ` Christoph Hellwig
2021-03-19 15:22 ` Keith Busch
2021-03-19 15:30 ` Christoph Hellwig
2021-03-19 17:21 ` Alan Adamson
2021-03-19 17:30 ` Keith Busch
2021-03-19 17:33 ` Alan Adamson
2021-05-05 18:40 ` Alan Adamson
2021-05-05 20:11 ` Keith Busch
2021-05-05 20:23 ` Alan Adamson
2021-05-05 20:35 ` Keith Busch
2021-03-18 19:15 ` Chaitanya Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB496524879B3C3A1D9F644BAF86699@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=alan.adamson@oracle.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).