From: Christoph Hellwig <hch@lst.de>
To: Prike Liang <Prike.Liang@amd.com>
Cc: linux-nvme@lists.infradead.org, Chaitanya.Kulkarni@wdc.com,
kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me,
Shyam-sundar.S-k@amd.com, Alexander.Deucher@amd.com
Subject: Re: [PATCH v2] nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path
Date: Thu, 1 Apr 2021 11:16:45 +0200 [thread overview]
Message-ID: <20210401091645.GA2934@lst.de> (raw)
In-Reply-To: <1617194885-459-1-git-send-email-Prike.Liang@amd.com>
On Wed, Mar 31, 2021 at 08:48:05PM +0800, Prike Liang wrote:
> The NVME device pluged in some AMD PCIE root port will resume timeout
> from s2idle which caused by NVME power CFG lost in the SMU FW restore.
> This issue can be workaround by using PCIe power set with simple
> suspend/resume process path instead of APST. In the onwards ASIC will
> try do the NVME shutdown save and restore in the BIOS and still need PCIe
> power seting to resume from RTD3 for s2idle.
Looks like this is a generic PCIe-level quirk and should go into the
core drivers/pci/ quirk table, with NVMe just looking at the
quirk flag.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-01 9:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 12:48 [PATCH v2] nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path Prike Liang
2021-03-31 20:47 ` Chaitanya Kulkarni
2021-04-01 1:04 ` Liang, Prike
2021-04-01 1:51 ` Keith Busch
2021-04-01 2:05 ` Chaitanya Kulkarni
2021-04-06 7:17 ` Liang, Prike
2021-04-01 9:16 ` Christoph Hellwig [this message]
2021-04-11 3:32 ` Liang, Prike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401091645.GA2934@lst.de \
--to=hch@lst.de \
--cc=Alexander.Deucher@amd.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Prike.Liang@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).