From: Christoph Hellwig <hch@infradead.org>
To: Prike Liang <Prike.Liang@amd.com>
Cc: linux-nvme@lists.infradead.org, Chaitanya.Kulkarni@wdc.com,
gregkh@linuxfoundation.org, hch@infradead.org,
stable@vger.kernel.org, Alexander.Deucher@amd.com,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Subject: Re: [PATCH v4 1/2] PCI: add AMD PCIe quirk for nvme shutdown opt
Date: Thu, 15 Apr 2021 09:20:57 +0100 [thread overview]
Message-ID: <20210415082057.GA1973565@infradead.org> (raw)
In-Reply-To: <1618458725-17164-1-git-send-email-Prike.Liang@amd.com>
A cover letter for the series would be really nice.
On Thu, Apr 15, 2021 at 11:52:04AM +0800, Prike Liang wrote:
> The NVME device pluged in some AMD PCIE root port will resume timeout
> from s2idle which caused by NVME power CFG lost in the SMU FW restore.
> This issue can be workaround by using PCIe power set with simple
> suspend/resume process path instead of APST. In the onwards ASIC will
> try do the NVME shutdown save and restore in the BIOS and still need PCIe
> power setting to resume from RTD3 for s2idle.
>
> In this preparation patch add a PCIe quirk for the AMD.
The above looks very hard to understand to me. It uses some AMD
specific terms, and also is overly specific to NVMe. Any other PCIe
device not doing a runtime-D3 in these slots will have the same problem.
So I think you should generalize the flag name and description to
describe what broken behavior the AMD root port has here, and only
cursory refer to drivers that are broken by it.
I'd also much prefer if the flag is used on every pci_dev that is
affected by the broken behavior rather than requiring another lookup
in the driver.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-15 8:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 3:52 [PATCH v4 1/2] PCI: add AMD PCIe quirk for nvme shutdown opt Prike Liang
2021-04-15 3:52 ` [PATCH v4 2/2] nvme-pci: add AMD PCIe quirk for suspend/resume Prike Liang
2021-04-15 6:29 ` Greg KH
2021-04-15 7:39 ` Liang, Prike
2021-04-15 8:20 ` Christoph Hellwig [this message]
2021-04-15 9:41 ` [PATCH v4 1/2] PCI: add AMD PCIe quirk for nvme shutdown opt Liang, Prike
2021-04-15 22:25 ` Keith Busch
2021-04-16 6:51 ` Liang, Prike
2021-04-30 17:50 ` Bjorn Helgaas
2021-05-03 7:14 ` Christoph Hellwig
2021-05-03 14:57 ` Keith Busch
2021-05-03 15:50 ` Bjorn Helgaas
2021-05-06 3:22 ` Liang, Prike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415082057.GA1973565@infradead.org \
--to=hch@infradead.org \
--cc=Alexander.Deucher@amd.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Prike.Liang@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-nvme@lists.infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).