From: Christoph Hellwig <hch@infradead.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Prike Liang <Prike.Liang@amd.com>,
linux-nvme@lists.infradead.org, Chaitanya.Kulkarni@wdc.com,
gregkh@linuxfoundation.org, hch@infradead.org,
stable@vger.kernel.org, Alexander.Deucher@amd.com,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
linux-pci@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v4 1/2] PCI: add AMD PCIe quirk for nvme shutdown opt
Date: Mon, 3 May 2021 08:14:07 +0100 [thread overview]
Message-ID: <20210503071407.GA3521294@infradead.org> (raw)
In-Reply-To: <20210430175049.GA664888@bjorn-Precision-5520>
On Fri, Apr 30, 2021 at 12:50:49PM -0500, Bjorn Helgaas wrote:
> This needs to be cc'd to linux-pci (I did it for you this time).
I did ask for that before.
> Sorry, I can't make any sense out of the commit log. Is this a Root
> Port defect or an NVMe device defect?
It is a root port quirk, although it appears to be intentional as Intel
is doing the same thing on some platforms.
> Patch 2/2 only uses PCI_DEV_FLAGS_AMD_NVME_SIMPLE_SUSPEND in the nvme
> driver, so AFAICT there is no reason for the PCI core to keep track of
> the flag for you.
>
> I see below that Christoph suggests it needs to be in the PCI core,
> but the reason needs to be explained in the commit log.
As far as I can tell this has nothing to do with NVMe except for the
fact that right now it mostly hits NVMe as the nvme drivers is one of
the few drivers not always doing a full device shutdown when the
system goes into the S3 power state. But various x86 platforms now
randomly power done the link in that case.
>
> I have not acked this patch. Please don't merge it before clearing
> these things up.
I would never merge PCI core changes that haven't been reviewd by the
maintainer.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-03 7:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 3:52 [PATCH v4 1/2] PCI: add AMD PCIe quirk for nvme shutdown opt Prike Liang
2021-04-15 3:52 ` [PATCH v4 2/2] nvme-pci: add AMD PCIe quirk for suspend/resume Prike Liang
2021-04-15 6:29 ` Greg KH
2021-04-15 7:39 ` Liang, Prike
2021-04-15 8:20 ` [PATCH v4 1/2] PCI: add AMD PCIe quirk for nvme shutdown opt Christoph Hellwig
2021-04-15 9:41 ` Liang, Prike
2021-04-15 22:25 ` Keith Busch
2021-04-16 6:51 ` Liang, Prike
2021-04-30 17:50 ` Bjorn Helgaas
2021-05-03 7:14 ` Christoph Hellwig [this message]
2021-05-03 14:57 ` Keith Busch
2021-05-03 15:50 ` Bjorn Helgaas
2021-05-06 3:22 ` Liang, Prike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503071407.GA3521294@infradead.org \
--to=hch@infradead.org \
--cc=Alexander.Deucher@amd.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Prike.Liang@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).