From: Sagi Grimberg <sagi@grimberg.me>
To: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, Keith Busch <keith.busch@wdc.com>
Subject: Re: [PATCH 2/2] nvme: add 'queue_if_no_path' semantics
Date: Fri, 5 Mar 2021 12:31:31 -0800 [thread overview]
Message-ID: <28830f4b-181d-2a4d-0bdd-2f63fcdbcf72@grimberg.me> (raw)
In-Reply-To: <ce2c93e1-ba38-cebb-33b3-d506116a61aa@suse.de>
> Compare that to the 'standard', non-CMIC nvme, where with the same setup
> MD would detach the nvme on its own:
>
> # cat /proc/mdstat
> Personalities : [raid10]
> md127 : active (auto-read-only) raid10 nvme2n1[1]
> 4189184 blocks super 1.2 2 near-copies [2/1] [_U]
> bitmap: 0/1 pages [0KB], 65536KB chunk
>
> unused devices: <none>
> # nvme list
> Node SN Model Namespace
> Usage Format FW Rev
> ---------------- --------------------
> ---------------------------------------- ---------
> -------------------------- ---------------- --------
> /dev/nvme0n1 SLESNVME1 QEMU NVMe Ctrl 1
> 17.18 GB / 17.18 GB 512 B + 0 B 1.0
> /dev/nvme2n1 SLESNVME3 QEMU NVMe Ctrl 1
> 4.29 GB / 4.29 GB 512 B + 0 B 1.0
>
> And yes, this is exactly the same setup, the only difference being the
> CMIC setting for the NVMe device.
I agree with Christoph that we should do exactly the same for all.
Hannes, My understanding here is that you want the device to go away
after the last path disappeared because it breaks md, why don't you
want to have this also for fabrics?
You mention that in fabrics one can manually disconnect, but why should
the user resort to a manual disconnect?
Is something else broken with this behavior? Maybe I am missing
something here?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-03-05 20:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 12:44 [RFC PATCHv3 0/2] nvme: queue_if_no_path functionality Hannes Reinecke
2020-10-05 12:44 ` [PATCH 1/2] nvme-mpath: delete disk after last connection Hannes Reinecke
2020-10-05 12:50 ` Christoph Hellwig
2021-03-05 20:06 ` Sagi Grimberg
2021-03-04 14:34 ` Daniel Wagner
2020-10-05 12:45 ` [PATCH 2/2] nvme: add 'queue_if_no_path' semantics Hannes Reinecke
2020-10-05 12:52 ` Christoph Hellwig
2020-10-06 5:48 ` Hannes Reinecke
2020-10-06 7:51 ` Christoph Hellwig
2020-10-06 8:07 ` Hannes Reinecke
2020-10-06 8:27 ` Christoph Hellwig
2020-10-06 8:29 ` Hannes Reinecke
2020-10-06 8:39 ` Christoph Hellwig
2020-10-06 13:30 ` Hannes Reinecke
2020-10-06 13:45 ` Hannes Reinecke
2021-03-05 20:31 ` Sagi Grimberg [this message]
2021-03-08 13:17 ` Hannes Reinecke
2021-03-15 17:21 ` Sagi Grimberg
2020-10-06 17:41 ` Keith Busch
2021-03-05 20:11 ` Sagi Grimberg
2021-03-11 12:41 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28830f4b-181d-2a4d-0bdd-2f63fcdbcf72@grimberg.me \
--to=sagi@grimberg.me \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).