[PATCH] nvmet-auth: return the error code to the nvmet_auth_ctrl_hash() callers

[PATCH] nvmet-auth: return the error code to the nvmet_auth_ctrl_hash() callers

[Maurizio Lombardi]

If nvmet_auth_ctrl_hash() fails, return the error code to its callers

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
 drivers/nvme/target/auth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c
index fb518b00f71f..4f08362aee8b 100644
--- a/drivers/nvme/target/auth.c
+++ b/drivers/nvme/target/auth.c
@@ -480,7 +480,7 @@ int nvmet_auth_ctrl_hash(struct nvmet_req *req, u8 *response,
 	nvme_auth_free_key(transformed_key);
 out_free_tfm:
 	crypto_free_shash(shash_tfm);
-	return 0;
+	return ret;
 }
 
 int nvmet_auth_ctrl_exponential(struct nvmet_req *req,
-- 
2.39.3

Re: [PATCH] nvmet-auth: return the error code to the nvmet_auth_ctrl_hash() callers

[Sagi Grimberg]

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

Re: [PATCH] nvmet-auth: return the error code to the nvmet_auth_ctrl_hash() callers

[Chaitanya Kulkarni]

On 4/12/24 06:41, Maurizio Lombardi wrote:
> If nvmet_auth_ctrl_hash() fails, return the error code to its callers

nit:-

If nvmet_auth_ctrl_hash() fails, return the error code to its callers.

> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck

Re: [PATCH] nvmet-auth: return the error code to the nvmet_auth_ctrl_hash() callers

[Keith Busch]

On Fri, Apr 12, 2024 at 03:41:54PM +0200, Maurizio Lombardi wrote:
> If nvmet_auth_ctrl_hash() fails, return the error code to its callers
> 
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>

Thanks, applied to nvme-6.9.