* [PATCH RESEND 1/2] nvmetcli: allow setting of the cntlid[min|max]
2020-01-09 5:04 [PATCH RESEND 0/2] nvmetcli: make model and ctrl-id configurable Chaitanya Kulkarni
@ 2020-01-09 5:04 ` Chaitanya Kulkarni
2020-03-02 17:41 ` Sagi Grimberg
2020-01-09 5:04 ` [PATCH RESEND 2/2] nvmetcli: allow setting of the subsystem model Chaitanya Kulkarni
2020-01-13 23:53 ` [PATCH RESEND 0/2] nvmetcli: make model and ctrl-id configurable Chaitanya Kulkarni
2 siblings, 1 reply; 9+ messages in thread
From: Chaitanya Kulkarni @ 2020-01-09 5:04 UTC (permalink / raw)
To: linux-nvme; +Cc: hch, Chaitanya Kulkarni, sagi
This patch allows users to set the subsystem's cntlid min and
cntlid max.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
nvmetcli | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/nvmetcli b/nvmetcli
index 3d8c16e..4fdac53 100755
--- a/nvmetcli
+++ b/nvmetcli
@@ -155,6 +155,8 @@ class UISubsystemNode(UINode):
ui_desc_attr = {
'allow_any_host': ('string', 'Allow access by any host if set to 1'),
'serial': ('string', 'Export serial number to hosts'),
+ 'cntlid_min': ('number', 'Set min ctrl id'),
+ 'cntlid_max': ('number', 'Set max ctrl id'),
'version': ('string', 'Export version number to hosts'),
}
@@ -172,6 +174,21 @@ class UISubsystemNode(UINode):
info.append("allow_any=" +
self.cfnode.get_attr("attr", "allow_any_host"))
info.append("serial=" + self.cfnode.get_attr("attr", "serial"))
+
+ try:
+ cntlid_min = str(self.cfnode.get_attr("attr", "cntlid_min"))
+ except Exception as e:
+ cntlid_min = "n/a"
+ if cntlid_min != "n/a":
+ info.append("cntlid_min=" + cntlid_min)
+
+ try:
+ cntlid_max = str(self.cfnode.get_attr("attr", "cntlid_max"))
+ except Exception as e:
+ cntlid_max = "n/a"
+ if cntlid_max != "n/a":
+ info.append("cntlid_max=" + cntlid_max)
+
return (", ".join(info), True)
--
2.22.1
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH RESEND 2/2] nvmetcli: allow setting of the subsystem model
2020-01-09 5:04 [PATCH RESEND 0/2] nvmetcli: make model and ctrl-id configurable Chaitanya Kulkarni
2020-01-09 5:04 ` [PATCH RESEND 1/2] nvmetcli: allow setting of the cntlid[min|max] Chaitanya Kulkarni
@ 2020-01-09 5:04 ` Chaitanya Kulkarni
2020-03-02 17:41 ` Sagi Grimberg
2020-01-13 23:53 ` [PATCH RESEND 0/2] nvmetcli: make model and ctrl-id configurable Chaitanya Kulkarni
2 siblings, 1 reply; 9+ messages in thread
From: Chaitanya Kulkarni @ 2020-01-09 5:04 UTC (permalink / raw)
To: linux-nvme; +Cc: hch, Chaitanya Kulkarni, sagi
From: Mark Ruijter <MRuijter@onestopsystems.com>
This patch allows users to set the subsystem's model.
Signed-off-by: Mark Ruijter <MRuijter@onestopsystems.com>
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
nvmetcli | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/nvmetcli b/nvmetcli
index 4fdac53..ea17f95 100755
--- a/nvmetcli
+++ b/nvmetcli
@@ -157,6 +157,7 @@ class UISubsystemNode(UINode):
'serial': ('string', 'Export serial number to hosts'),
'cntlid_min': ('number', 'Set min ctrl id'),
'cntlid_max': ('number', 'Set max ctrl id'),
+ 'model': ('string', 'Set a model description'),
'version': ('string', 'Export version number to hosts'),
}
@@ -189,6 +190,13 @@ class UISubsystemNode(UINode):
if cntlid_max != "n/a":
info.append("cntlid_max=" + cntlid_max)
+ try:
+ model = str(self.cfnode.get_attr("attr", "model"))
+ except Exception as e:
+ model = "n/a"
+ if model != "n/a":
+ info.append("model=" + model)
+
return (", ".join(info), True)
--
2.22.1
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH RESEND 0/2] nvmetcli: make model and ctrl-id configurable
2020-01-09 5:04 [PATCH RESEND 0/2] nvmetcli: make model and ctrl-id configurable Chaitanya Kulkarni
2020-01-09 5:04 ` [PATCH RESEND 1/2] nvmetcli: allow setting of the cntlid[min|max] Chaitanya Kulkarni
2020-01-09 5:04 ` [PATCH RESEND 2/2] nvmetcli: allow setting of the subsystem model Chaitanya Kulkarni
@ 2020-01-13 23:53 ` Chaitanya Kulkarni
2020-02-04 3:27 ` Chaitanya Kulkarni
2 siblings, 1 reply; 9+ messages in thread
From: Chaitanya Kulkarni @ 2020-01-13 23:53 UTC (permalink / raw)
To: linux-nvme; +Cc: hch, sagi
Ping?
On 01/08/2020 09:04 PM, Chaitanya Kulkarni wrote:
> Hi,
>
> This patch series allows users to set the subsys model and ctrl-id
> fields.
>
> Chaitanya Kulkarni (2):
> nvmetcli: allow setting of the cntlid[min|max]
> nvmetcli: allow setting of the subsystem model
>
> nvmetcli | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND 0/2] nvmetcli: make model and ctrl-id configurable
2020-01-13 23:53 ` [PATCH RESEND 0/2] nvmetcli: make model and ctrl-id configurable Chaitanya Kulkarni
@ 2020-02-04 3:27 ` Chaitanya Kulkarni
2020-03-01 7:43 ` Chaitanya Kulkarni
0 siblings, 1 reply; 9+ messages in thread
From: Chaitanya Kulkarni @ 2020-02-04 3:27 UTC (permalink / raw)
To: linux-nvme; +Cc: hch, sagi
Ping ?
On 01/13/2020 03:53 PM, Chaitanya Kulkarni wrote:
> Ping?
>
> On 01/08/2020 09:04 PM, Chaitanya Kulkarni wrote:
>> Hi,
>>
>> This patch series allows users to set the subsys model and ctrl-id
>> fields.
>>
>> Chaitanya Kulkarni (2):
>> nvmetcli: allow setting of the cntlid[min|max]
>> nvmetcli: allow setting of the subsystem model
>>
>> nvmetcli | 25 +++++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>>
>
>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND 0/2] nvmetcli: make model and ctrl-id configurable
2020-02-04 3:27 ` Chaitanya Kulkarni
@ 2020-03-01 7:43 ` Chaitanya Kulkarni
2020-03-12 23:41 ` Chaitanya Kulkarni
0 siblings, 1 reply; 9+ messages in thread
From: Chaitanya Kulkarni @ 2020-03-01 7:43 UTC (permalink / raw)
To: linux-nvme; +Cc: hch, sagi
Ping ?
On 02/03/2020 07:27 PM, Chaitanya Kulkarni wrote:
> Ping ?
>
> On 01/13/2020 03:53 PM, Chaitanya Kulkarni wrote:
>> Ping?
>>
>> On 01/08/2020 09:04 PM, Chaitanya Kulkarni wrote:
>>> Hi,
>>>
>>> This patch series allows users to set the subsys model and ctrl-id
>>> fields.
>>>
>>> Chaitanya Kulkarni (2):
>>> nvmetcli: allow setting of the cntlid[min|max]
>>> nvmetcli: allow setting of the subsystem model
>>>
>>> nvmetcli | 25 +++++++++++++++++++++++++
>>> 1 file changed, 25 insertions(+)
>>>
>>
>>
>
>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH RESEND 0/2] nvmetcli: make model and ctrl-id configurable
2020-03-01 7:43 ` Chaitanya Kulkarni
@ 2020-03-12 23:41 ` Chaitanya Kulkarni
0 siblings, 0 replies; 9+ messages in thread
From: Chaitanya Kulkarni @ 2020-03-12 23:41 UTC (permalink / raw)
To: hch; +Cc: linux-nvme, Chaitanya Kulkarni, sagi
Thanks Sagi for reviewing these patches.
Christoph, can you please pick up these patches ?
On 02/29/2020 11:43 PM, Chaitanya Kulkarni wrote:
> Ping ?
> On 02/03/2020 07:27 PM, Chaitanya Kulkarni wrote:
>> Ping ?
>>
>> On 01/13/2020 03:53 PM, Chaitanya Kulkarni wrote:
>>> Ping?
>>>
>>> On 01/08/2020 09:04 PM, Chaitanya Kulkarni wrote:
>>>> Hi,
>>>>
>>>> This patch series allows users to set the subsys model and ctrl-id
>>>> fields.
>>>>
>>>> Chaitanya Kulkarni (2):
>>>> nvmetcli: allow setting of the cntlid[min|max]
>>>> nvmetcli: allow setting of the subsystem model
>>>>
>>>> nvmetcli | 25 +++++++++++++++++++++++++
>>>> 1 file changed, 25 insertions(+)
>>>>
>>>
>>>
>>
>>
>
>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 9+ messages in thread