* [PATCH] NVMe: Add MAXIO 1602 to bogus nid list.
@ 2023-05-19 17:56 Tatsuki Sugiura
2023-05-20 4:22 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Tatsuki Sugiura @ 2023-05-19 17:56 UTC (permalink / raw)
To: Keith Busch
Cc: Jens Axboe, Christoph Hellwig, Sagi Grimberg, linux-nvme, sugi
HIKSEMI FUTURE M.2 SSD uses the same dummy nguid and eui64.
I confirmed it with my two devices.
This patch marks the controller as NVME_QUIRK_BOGUS_NID.
---------------------------------------------------------
sugi@tempest:~% sudo nvme id-ctrl /dev/nvme0
NVME Identify Controller:
vid : 0x1e4b
ssvid : 0x1e4b
sn : 30096022612
mn : HS-SSD-FUTURE 2048G
fr : SN10542
rab : 0
ieee : 000000
cmic : 0
mdts : 7
cntlid : 0
ver : 0x10400
rtd3r : 0x7a120
rtd3e : 0x1e8480
oaes : 0x200
ctratt : 0x2
rrls : 0
cntrltype : 1
fguid : 00000000-0000-0000-0000-000000000000
<snip...>
---------------------------------------------------------
---------------------------------------------------------
sugi@tempest:~% sudo nvme id-ns /dev/nvme0n1
NVME Identify Namespace 1:
<snip...>
nguid : 00000000000000000000000000000000
eui64 : 0000000000000002
lbaf 0 : ms:0 lbads:9 rp:0 (in use)
---------------------------------------------------------
Signed-off-by: Tatsuki Sugiura <sugi@nemui.org>
---
drivers/nvme/host/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 7f25c0fe3a0b..dae0f8ed0af9 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3422,6 +3422,8 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1e4B, 0x1202), /* MAXIO MAP1202 */
.driver_data = NVME_QUIRK_BOGUS_NID, },
+ { PCI_DEVICE(0x1e4B, 0x1602), /* MAXIO MAP1602 like HIKSEMI FUTURE NVMe SSD */
+ .driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1cc1, 0x5350), /* ADATA XPG GAMMIX S50 */
.driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1dbe, 0x5236), /* ADATA XPG GAMMIX S70 */
--
2.40.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] NVMe: Add MAXIO 1602 to bogus nid list.
2023-05-19 17:56 [PATCH] NVMe: Add MAXIO 1602 to bogus nid list Tatsuki Sugiura
@ 2023-05-20 4:22 ` Christoph Hellwig
2023-05-20 11:27 ` Tatsuki Sugiura
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2023-05-20 4:22 UTC (permalink / raw)
To: Tatsuki Sugiura
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, linux-nvme
On Sat, May 20, 2023 at 02:56:03AM +0900, Tatsuki Sugiura wrote:
> HIKSEMI FUTURE M.2 SSD uses the same dummy nguid and eui64.
> I confirmed it with my two devices.
>
> This patch marks the controller as NVME_QUIRK_BOGUS_NID.
>
> ---------------------------------------------------------
> sugi@tempest:~% sudo nvme id-ctrl /dev/nvme0
> NVME Identify Controller:
> vid : 0x1e4b
> ssvid : 0x1e4b
> sn : 30096022612
> mn : HS-SSD-FUTURE 2048G
> fr : SN10542
> rab : 0
> ieee : 000000
> cmic : 0
> mdts : 7
> cntlid : 0
> ver : 0x10400
> rtd3r : 0x7a120
> rtd3e : 0x1e8480
> oaes : 0x200
> ctratt : 0x2
> rrls : 0
> cntrltype : 1
> fguid : 00000000-0000-0000-0000-000000000000
> <snip...>
> ---------------------------------------------------------
>
> ---------------------------------------------------------
> sugi@tempest:~% sudo nvme id-ns /dev/nvme0n1
> NVME Identify Namespace 1:
> <snip...>
> nguid : 00000000000000000000000000000000
> eui64 : 0000000000000002
> lbaf 0 : ms:0 lbads:9 rp:0 (in use)
> ---------------------------------------------------------
>
> Signed-off-by: Tatsuki Sugiura <sugi@nemui.org>
> ---
> drivers/nvme/host/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 7f25c0fe3a0b..dae0f8ed0af9 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3422,6 +3422,8 @@ static const struct pci_device_id nvme_id_table[] = {
> .driver_data = NVME_QUIRK_BOGUS_NID, },
> { PCI_DEVICE(0x1e4B, 0x1202), /* MAXIO MAP1202 */
> .driver_data = NVME_QUIRK_BOGUS_NID, },
> + { PCI_DEVICE(0x1e4B, 0x1602), /* MAXIO MAP1602 like HIKSEMI FUTURE NVMe SSD */
It seems like the vendor ID is MAXIO, so I'd remove the
˝like HIKSEMI FUTURE NVMe SSD" here.
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] NVMe: Add MAXIO 1602 to bogus nid list.
2023-05-20 4:22 ` Christoph Hellwig
@ 2023-05-20 11:27 ` Tatsuki Sugiura
2023-05-20 12:23 ` Tatsuki Sugiura
0 siblings, 1 reply; 6+ messages in thread
From: Tatsuki Sugiura @ 2023-05-20 11:27 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme
On Sat, 20 May 2023 13:22:46 +0900,
Christoph Hellwig wrote:
> It seems like the vendor ID is MAXIO, so I'd remove the
> ˝like HIKSEMI FUTURE NVMe SSD" here.
>
> Otherwise this looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
Thanks.
OK. I'll send cleanup version by next email.
--
Tatsuki Sugiura mailto:sugi@nemui.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] NVMe: Add MAXIO 1602 to bogus nid list.
2023-05-20 11:27 ` Tatsuki Sugiura
@ 2023-05-20 12:23 ` Tatsuki Sugiura
2023-05-23 6:14 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Tatsuki Sugiura @ 2023-05-20 12:23 UTC (permalink / raw)
To: Keith Busch
Cc: Jens Axboe, Christoph Hellwig, Sagi Grimberg, linux-nvme, sugi
HIKSEMI FUTURE M.2 SSD uses the same dummy nguid and eui64.
I confirmed it with my two devices.
This patch marks the controller as NVME_QUIRK_BOGUS_NID.
---------------------------------------------------------
sugi@tempest:~% sudo nvme id-ctrl /dev/nvme0
NVME Identify Controller:
vid : 0x1e4b
ssvid : 0x1e4b
sn : 30096022612
mn : HS-SSD-FUTURE 2048G
fr : SN10542
rab : 0
ieee : 000000
cmic : 0
mdts : 7
cntlid : 0
ver : 0x10400
rtd3r : 0x7a120
rtd3e : 0x1e8480
oaes : 0x200
ctratt : 0x2
rrls : 0
cntrltype : 1
fguid : 00000000-0000-0000-0000-000000000000
<snip...>
---------------------------------------------------------
---------------------------------------------------------
sugi@tempest:~% sudo nvme id-ns /dev/nvme0n1
NVME Identify Namespace 1:
<snip...>
nguid : 00000000000000000000000000000000
eui64 : 0000000000000002
lbaf 0 : ms:0 lbads:9 rp:0 (in use)
---------------------------------------------------------
Signed-off-by: Tatsuki Sugiura <sugi@nemui.org>
---
drivers/nvme/host/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 7f25c0fe3a0b..ee234fd27896 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3422,6 +3422,8 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1e4B, 0x1202), /* MAXIO MAP1202 */
.driver_data = NVME_QUIRK_BOGUS_NID, },
+ { PCI_DEVICE(0x1e4B, 0x1602), /* MAXIO MAP1602 */
+ .driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1cc1, 0x5350), /* ADATA XPG GAMMIX S50 */
.driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1dbe, 0x5236), /* ADATA XPG GAMMIX S70 */
--
2.40.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] NVMe: Add MAXIO 1602 to bogus nid list.
2023-05-20 12:23 ` Tatsuki Sugiura
@ 2023-05-23 6:14 ` Christoph Hellwig
2023-05-25 15:31 ` Keith Busch
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2023-05-23 6:14 UTC (permalink / raw)
To: Tatsuki Sugiura
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, linux-nvme
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] NVMe: Add MAXIO 1602 to bogus nid list.
2023-05-23 6:14 ` Christoph Hellwig
@ 2023-05-25 15:31 ` Keith Busch
0 siblings, 0 replies; 6+ messages in thread
From: Keith Busch @ 2023-05-25 15:31 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Tatsuki Sugiura, Jens Axboe, Sagi Grimberg, linux-nvme
Thanks, applied for nvme-6.4.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-25 15:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-19 17:56 [PATCH] NVMe: Add MAXIO 1602 to bogus nid list Tatsuki Sugiura
2023-05-20 4:22 ` Christoph Hellwig
2023-05-20 11:27 ` Tatsuki Sugiura
2023-05-20 12:23 ` Tatsuki Sugiura
2023-05-23 6:14 ` Christoph Hellwig
2023-05-25 15:31 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).